From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BC07AA04AC;
	Mon, 24 Aug 2020 17:14:33 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 26770F90;
	Mon, 24 Aug 2020 17:14:33 +0200 (CEST)
Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com
 [209.85.214.171]) by dpdk.org (Postfix) with ESMTP id 9D101F12
 for <dev@dpdk.org>; Mon, 24 Aug 2020 17:14:31 +0200 (CEST)
Received: by mail-pl1-f171.google.com with SMTP id bh1so4360032plb.12
 for <dev@dpdk.org>; Mon, 24 Aug 2020 08:14:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=uZgp7bjhpZp23HWklfm9ZRKOig6qGJj8S0AozeehH84=;
 b=q+8V8zhFPB/YyAU/4ybNvWoSqHTzC6xB8ZaNMNWIDXJllsP3Pxwjmn5P+8anggC01C
 T9a3z6nsabCFTyamkoL6Df11jVP36Syr99G/Qmb/6rxjSIlGuExzL3i0X2AEQeIe0yF8
 CBmDnLApApanVOjqUbcAUkZRAff1PrtJIeaOioSIyk80yZPIz7cq02Q99AvdkqsroLhV
 mLUFJeCCSG1fNot6FoQ0vjaDW89kEpkcdO4LF/4ZCyiEJ2YZMuyXcbByW0wHeeAP5nxf
 dm0OWlmd0QMD9xmeDGV4259cBDV6deyA7k/3mU8OgMyWtmLrvnTrQXIYU0WDZ5s/keY8
 fGkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=uZgp7bjhpZp23HWklfm9ZRKOig6qGJj8S0AozeehH84=;
 b=PbiYYL6jeDidMGb/8ZSVxT9ZB7zOS9UlBEXZ6FVu3RNVPKGB9lLoH4IfVILSuHKjB3
 MM6qEIJ55WscB6p6lyi/vUsWQ+PCQBbHZ314zrqDV83p586Bez2mXYZNFT9PAbK77yic
 GX8q1FCL0Tzi2hxT93fGPmumhbbs4mNCT/8JZ+ydHJkuUi/9YUIPt5Vjym36+41OftE+
 42Uq14BNudgrGrqpSWD4wWjo2Ku/Qkzij5Pnv73xy0ncM8Lxcd8928oq44AZqmCUz7gf
 eg9Aqx2gq4ODyNBjsPLZNj+2wDLVk4uAeb+38QXYNbNLiOylK+mLG/PJrzUK63u8xy1T
 EQgA==
X-Gm-Message-State: AOAM532LXPzJoNsvMDI/7vJng1wnv30NAHp6zlOrBqt5id+SKT8KDD/I
 uqfipcstL7dqbpYJTTKkj9Cweg==
X-Google-Smtp-Source: ABdhPJxYrWRk11U14mSCxcxwCp6NS+Ks+NwoQuSPTokCDC5jhT2Qjic28E8YL5JpBgVMDgPBNjk4uQ==
X-Received: by 2002:a17:902:bcca:: with SMTP id
 o10mr4280693pls.132.1598282070774; 
 Mon, 24 Aug 2020 08:14:30 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id h5sm12808011pfk.0.2020.08.24.08.14.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 24 Aug 2020 08:14:30 -0700 (PDT)
Date: Mon, 24 Aug 2020 08:14:22 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: rohit.raj@nxp.com
Cc: Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
 dev@dpdk.org
Message-ID: <20200824081422.52dc4d7e@hermes.lan>
In-Reply-To: <20200824082414.30535-1-rohit.raj@nxp.com>
References: <20200824082414.30535-1-rohit.raj@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal: add API for bus close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 24 Aug 2020 13:54:12 +0530
rohit.raj@nxp.com wrote:

> +	if (vbus) {
> +		if (vbus->close) {

Looks good, minor nit.
This could be:
	if (vbus && vbus->close) {