From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75488A04B1; Tue, 25 Aug 2020 13:44:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C08B1C11B; Tue, 25 Aug 2020 13:44:54 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0FF091C116 for ; Tue, 25 Aug 2020 13:44:52 +0200 (CEST) IronPort-SDR: tWoTBs+lOsSLLov0B083dxi4JifNQhKzOMkz3P0RLE7iuDxPD7hcyg3/VUY9P59CYTmO6iWXWV 49O6Hl6rf8gA== X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="217640595" X-IronPort-AV: E=Sophos;i="5.76,352,1592895600"; d="scan'208";a="217640595" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 04:44:52 -0700 IronPort-SDR: 4tHUEIwlrKkHvbrNHNQjKROmP0GNkb80cwK2tRouwC04UYBxn8q3zntf4Uqhpimsbd8h6HZimX GDCQZRXgqjfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,352,1592895600"; d="scan'208";a="443603511" Received: from silpixa00399126.ir.intel.com ([10.237.222.56]) by orsmga004.jf.intel.com with ESMTP; 25 Aug 2020 04:44:51 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: bluca@debian.org, Bruce Richardson Date: Tue, 25 Aug 2020 12:44:46 +0100 Message-Id: <20200825114447.135030-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 1/2] config: remove explicit undefinition of unset values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Rather than explicitly clearing any setting of undefined values in our rte_config.h file, it's better to instead just add a comment that the value is not set. Using a comment allows the user to set the value using CFLAGS or similar mechanism without the config file clearing the value again. The text used " is not set" is modelled after the kernel approach of doing the same thing. Signed-off-by: Bruce Richardson --- config/rte_config.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/config/rte_config.h b/config/rte_config.h index 9bb915347c..1c5a86d6a7 100644 --- a/config/rte_config.h +++ b/config/rte_config.h @@ -85,17 +85,17 @@ /* ip_fragmentation defines */ #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4 -#undef RTE_LIBRTE_IP_FRAG_TBL_STAT +// RTE_LIBRTE_IP_FRAG_TBL_STAT is not set /* rte_power defines */ #define RTE_MAX_LCORE_FREQS 64 /* rte_sched defines */ -#undef RTE_SCHED_RED -#undef RTE_SCHED_COLLECT_STATS -#undef RTE_SCHED_SUBPORT_TC_OV +// RTE_SCHED_RED is not set +// RTE_SCHED_COLLECT_STATS is not set +// RTE_SCHED_SUBPORT_TC_OV is not set #define RTE_SCHED_PORT_N_GRINDERS 8 -#undef RTE_SCHED_VECTOR +// RTE_SCHED_VECTOR is not set /* KNI defines */ #define RTE_KNI_PREEMPT_DEFAULT 1 @@ -123,7 +123,7 @@ /* i40e defines */ #define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC 1 -#undef RTE_LIBRTE_I40E_16BYTE_RX_DESC +// RTE_LIBRTE_I40E_16BYTE_RX_DESC is not set #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64 #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4 #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4 -- 2.25.1