From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A8F4A04B1; Wed, 26 Aug 2020 17:43:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8E991BECF; Wed, 26 Aug 2020 17:43:43 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 2A38C1BECC for ; Wed, 26 Aug 2020 17:43:42 +0200 (CEST) IronPort-SDR: 71mEHr2y7hULnisv0Aol2qiGVU8vB6rKFJSne6+4MbhjdmqYNRlyFM+9SqrFaS7lH4bM5AGQ/K cBdMPZ9Gprzg== X-IronPort-AV: E=McAfee;i="6000,8403,9725"; a="136379282" X-IronPort-AV: E=Sophos;i="5.76,356,1592895600"; d="scan'208";a="136379282" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 08:43:42 -0700 IronPort-SDR: 2WtgBv7VekAbgucLuo2+BWR+4sph/bYhf89TysBjMZ6Eh8CK2IdVBpiLPWUTjY3K43kQMtVHm6 L4cYA0TofwEQ== X-IronPort-AV: E=Sophos;i="5.76,356,1592895600"; d="scan'208";a="474818883" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.1.248]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 26 Aug 2020 08:43:40 -0700 Date: Wed, 26 Aug 2020 16:43:37 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: Thomas Monjalon , dev@dpdk.org Message-ID: <20200826154337.GA564@bricha3-MOBL.ger.corp.intel.com> References: <20200129155907.20556-1-stephen@networkplumber.org> <20200714232101.32544-1-stephen@networkplumber.org> <3584477.4m1K3HXnfP@thomas> <20200826081230.1bf539d8@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200826081230.1bf539d8@hermes.lan> Subject: Re: [dpdk-dev] [PATCH v5] devtools: add new SPDX license compliance checker X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 26, 2020 at 08:12:30AM -0700, Stephen Hemminger wrote: > On Fri, 31 Jul 2020 00:06:23 +0200 > Thomas Monjalon wrote: > > > 15/07/2020 01:21, Stephen Hemminger: > > > Simple script to look for drivers and scripts that > > > are missing requires SPDX header. > > > > > > Signed-off-by: Stephen Hemminger > > [...] > > > +#! /bin/sh > > > +# SPDX-License-Identifier: BSD-3-Clause > > > +# Copyright 2020 Microsoft Corporation > > > +# > > > +# Produce a list of files with incorrect license tags > > > + > > > +errors=0 > > > +warnings=0 > > > +quiet=false > > > +verbose=false > > > + > > > +print_usage () { > > > + echo "usage: $(basename $0) [-q] [-v]" > > > + exit 1 > > > +} > > > + > > > +check_spdx() { > > > + if $verbose; then > > > + echo "Files without SPDX License" > > > + echo "--------------------------" > > > + fi > > > + git grep -L SPDX-License-Identifier -- \ > > > + ':^.git*' ':^.ci/*' ':^.travis.yml' \ > > > + ':^README' ':^MAINTAINERS' ':^VERSION' ':^ABI_VERSION' \ > > > + ':^*/Kbuild' ':^*/README' \ > > > + ':^license/' ':^config/' ':^buildtools/' \ > > > + ':^*.cocci' ':^*.abignore' \ > > > + ':^*.def' ':^*.map' ':^*.ini' ':^*.data' ':^*.cfg' ':^*.txt' \ > > > + ':^*.svg' ':^*.png'\ > > > > I don't agree with this list of files. > > But I guess we can start with that and be more strict in future. > > I suppose README, MAINTAINERS, .ini and .txt files could be removed from the exception list. We also want to scan the files in config and buildtools.