From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FE1FA04B1; Thu, 27 Aug 2020 11:14:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E71F21C125; Thu, 27 Aug 2020 11:14:39 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6063B1C124; Thu, 27 Aug 2020 11:14:38 +0200 (CEST) IronPort-SDR: mhBWNkZVwpCw3IG44mxM2MQ/Xeg0oKEsZ/oqBkKstScmNfXqMRk3vHiwAoCFA9zqQP7pUh/tf8 TeTOwbLF5muA== X-IronPort-AV: E=McAfee;i="6000,8403,9725"; a="136514605" X-IronPort-AV: E=Sophos;i="5.76,359,1592895600"; d="scan'208";a="136514605" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2020 02:14:37 -0700 IronPort-SDR: JUCKpztGy80FZVNrbT9Hg9VJPPTelDsK/Gdt2SrB09EZPtWZJ2QDTME7Nh5qbF5QiDPNI9+hY7 BrcvEAeTtxBw== X-IronPort-AV: E=Sophos;i="5.76,359,1592895600"; d="scan'208";a="475132778" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.94.132]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 27 Aug 2020 02:14:34 -0700 Date: Thu, 27 Aug 2020 10:14:31 +0100 From: Bruce Richardson To: Ciara Power Cc: dev@dpdk.org, mike.ximing.chen@intel.com, gage.eads@intel.com, sundar.vedantham@intel.com, stable@dpdk.org, Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Nipun Gupta , Hemant Agrawal , Kevin Laatz , Keith Wiles Message-ID: <20200827091431.GB569@bricha3-MOBL.ger.corp.intel.com> References: <20200827083922.64442-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200827083922.64442-1-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH v2] lib/telemetry: fix passing full params string to command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 27, 2020 at 09:39:22AM +0100, Ciara Power wrote: > Telemetry only passed the first param to the command handler if multiple > were entered by the user, separated by commas. Telemetry is required to > pass the full params string to the command, by splitting by a comma > delimiter only once to remove the command part of the string. This will > enable future commands to take multiple param values. > > Fixes: b1ad0e124536 ("rawdev: add telemetry callbacks") > Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks") > Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") > Cc: bruce.richardson@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power > Missed threading with V1, but otherwise LGTM. Acked-by: Bruce Richardson