From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6637DA04B1;
Thu, 27 Aug 2020 18:14:48 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 0429F1C0D9;
Thu, 27 Aug 2020 18:13:50 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id 7BB291C0B0
for <dev@dpdk.org>; Thu, 27 Aug 2020 18:13:40 +0200 (CEST)
IronPort-SDR: 8a0kXChYMU7l8q4HlTiDCuv9bGVxYGE11ra2/fj6dls9g1RMORYDjrIfVDk6VvHfHhDw9EtOD/
cdmTjyTTaH7Q==
X-IronPort-AV: E=McAfee;i="6000,8403,9726"; a="220767018"
X-IronPort-AV: E=Sophos;i="5.76,360,1592895600"; d="scan'208";a="220767018"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
27 Aug 2020 09:13:27 -0700
IronPort-SDR: Oi4FkF092IfUDtHwclcK2n5h5o5iU1jY/09qNV5j/+6H0tVasmNz3WSVl0SBBuTiqyYDYcW5p3
TI7xn5ENBuxg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.76,360,1592895600"; d="scan'208";a="280681504"
Received: from silpixa00399953.ir.intel.com (HELO
silpixa00399953.ger.corp.intel.com) ([10.237.222.53])
by fmsmga007.fm.intel.com with ESMTP; 27 Aug 2020 09:13:26 -0700
From: Ciara Power <ciara.power@intel.com>
To: dev@dpdk.org
Cc: Ciara Power <ciara.power@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>
Date: Thu, 27 Aug 2020 17:12:55 +0100
Message-Id: <20200827161304.32300-9-ciara.power@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20200827161304.32300-1-ciara.power@intel.com>
References: <20200807155859.63888-1-ciara.power@intel.com>
<20200827161304.32300-1-ciara.power@intel.com>
Subject: [dpdk-dev] [PATCH v2 08/17] net/fm10k: add checks for max SIMD
bitwidth
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
When choosing a vector path to take, an extra condition must be
satisfied to ensure the max SIMD bitwidth allows for the CPU enabled
path.
Cc: Qi Zhang <qi.z.zhang@intel.com>
Cc: Xiao Wang <xiao.w.wang@intel.com>
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
drivers/net/fm10k/fm10k_ethdev.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index b574693bca..f7c41d4377 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -2937,7 +2937,9 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)
if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
/* primary process has set the ftag flag and offloads */
txq = dev->data->tx_queues[0];
- if (fm10k_tx_vec_condition_check(txq)) {
+ if (fm10k_tx_vec_condition_check(txq) ||
+ rte_get_max_simd_bitwidth()
+ < RTE_MAX_128_SIMD) {
dev->tx_pkt_burst = fm10k_xmit_pkts;
dev->tx_pkt_prepare = fm10k_prep_pkts;
PMD_INIT_LOG(DEBUG, "Use regular Tx func");
@@ -2956,7 +2958,8 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)
txq = dev->data->tx_queues[i];
txq->tx_ftag_en = tx_ftag_en;
/* Check if Vector Tx is satisfied */
- if (fm10k_tx_vec_condition_check(txq))
+ if (fm10k_tx_vec_condition_check(txq) ||
+ rte_get_max_simd_bitwidth() < RTE_MAX_128_SIMD)
use_sse = 0;
}
@@ -2990,7 +2993,9 @@ fm10k_set_rx_function(struct rte_eth_dev *dev)
* conditions to be met.
*/
if (!fm10k_rx_vec_condition_check(dev) &&
- dev_info->rx_vec_allowed && !rx_ftag_en) {
+ dev_info->rx_vec_allowed && !rx_ftag_en &&
+ rte_get_max_simd_bitwidth()
+ >= RTE_MAX_128_SIMD) {
if (dev->data->scattered_rx)
dev->rx_pkt_burst = fm10k_recv_scattered_pkts_vec;
else
--
2.17.1