From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D007A04AC; Tue, 1 Sep 2020 14:47:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2DAA1C1C7; Tue, 1 Sep 2020 14:47:56 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id DB4A81C1A3; Tue, 1 Sep 2020 14:47:54 +0200 (CEST) IronPort-SDR: IrgbYwSOh1KpeK/KhvfntApvZWv6bembAXLV7dYsooaFVUY+XCzQOmWwojBOAqeN7/zv2oO8TN FGFJFYvJ5iPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="137202319" X-IronPort-AV: E=Sophos;i="5.76,379,1592895600"; d="scan'208";a="137202319" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 05:47:52 -0700 IronPort-SDR: PY8gXJkbGz/5DByUm03IWe9PAFfF4it6EDJkVikbgWZrH+mf/mLeEVrEQb/BKIRm7N9KM/xIlE 6gaMxjiYJPHQ== X-IronPort-AV: E=Sophos;i="5.76,379,1592895600"; d="scan'208";a="477185662" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.80.162]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Sep 2020 05:47:50 -0700 Date: Tue, 1 Sep 2020 13:47:47 +0100 From: Bruce Richardson To: Christian Ehrhardt Cc: Luca Boccassi , stable@dpdk.org, dev , sunil.pai.g@intel.com, ian.stokes@intel.com Message-ID: <20200901124747.GB1047@bricha3-MOBL.ger.corp.intel.com> References: <20200818181222.8462-1-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] 19.11.4 patches review and test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 01, 2020 at 02:32:26PM +0200, Christian Ehrhardt wrote: > On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi wrote: > > > > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote: > > > Hi all, > > > > > > Here is a list of patches targeted for stable release 19.11.4. > > > > > > The planned date for the final release is August 31st. > > > > > > Please help with testing and validation of your use cases and report > > > any issues/results with reply-all to this mail. For the final release > > > the fixes and reported validations will be added to the release notes. > > > > > > A release candidate tarball can be found at: > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1 > > > > > > These patches are located at branch 19.11 of dpdk-stable repo: > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > Thanks. > > > > > > Luca Boccassi > > > > Microsoft's regression tests are still running, delaying until Thursday > > the 3rd. Apologies for any inconvenience. > > Due to report on OVS failing to build I happened to find that 19.11.4 > has massively changed linking. > => https://paste.ubuntu.com/p/znCRR4gpjP/ > > This was meant to be helpful for sure and I assume is around: > 48f7fd27f6 build/pkg-config: prevent overlinking > 2d1535d592 build/pkg-config: improve static linking flags > 9fb13a12c1 build/pkg-config: output drivers first for static build > 59b108d824 build/pkg-config: move pkg-config file creation > aea915e944 devtools: test static linkage with pkg-config > > But overlinking has effectively become underlinking now > https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o): > in function `rte_eth_from_rings': > (.text+0x91c): undefined reference to `rte_vdev_init' > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o): > in function `vdrvinitfn_pmd_ring_drv': > (.text.startup+0x28): undefined reference to `rte_vdev_register' > collect2: error: ld returned 1 exit status > > Also as you can see in the pastebin above, CFlags and Libs massively > shrunk and likely too much so. > > Given that this should be a stable release I'd ask to back out those > changes so that a test build creates the same .pc file as before - > would that make sense? > > Adding some OVS folks on CC. The request for backporting these actually came from the OVS side, since they were deemed necessary to enable OVS to switch to use DPDK pkg-config rather than the older approach using a makefile-based build. However, it appears you guys were already building OVS using the pkg-config file, and since this causes issues where there were none, backing it out seems a prudent choice. Ian, Sunil, any comments here. Regards /Bruce