From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9EC97A04D7;
	Thu,  3 Sep 2020 11:21:02 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 434B61C0AF;
	Thu,  3 Sep 2020 11:21:02 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 1DDEDE07
 for <dev@dpdk.org>; Thu,  3 Sep 2020 11:21:00 +0200 (CEST)
IronPort-SDR: R8K1gDY+1ZzjF3GNsEV3N9UPrZYiE/bGTtmbhfV/VMDsbv1FV8svZKwX1UOexhXMcMSN5JEM8v
 4pcHImGfsJDw==
X-IronPort-AV: E=McAfee;i="6000,8403,9732"; a="137596177"
X-IronPort-AV: E=Sophos;i="5.76,386,1592895600"; d="scan'208";a="137596177"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 03 Sep 2020 02:21:00 -0700
IronPort-SDR: FPrKxHWFYMH5txNY1Ct6coTNGjv0MhjSgG/3jktSMVmS9ReIhrxraX/WYWZv6iDiLs0YiaNOzA
 /nP4owFb1buQ==
X-IronPort-AV: E=Sophos;i="5.76,386,1592895600"; d="scan'208";a="477985155"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.24.168])
 by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 03 Sep 2020 02:20:56 -0700
Date: Thu, 3 Sep 2020 10:20:52 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Jie Zhou <jizh@microsoft.com>,
 Ranjit Menon <ranjit.menon@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Beilei Xing <beilei.xing@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>,
 Ori Kam <orika@mellanox.com>, Marko Kovacevic <marko.kovacevic@intel.com>,
 Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>,
 Tomasz Kantecki <tomasz.kantecki@intel.com>,
 Sunil Kumar Kori <skori@marvell.com>,
 Pavan Nikhilesh <pbhagavatula@marvell.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbo.xia@intel.com>, Zhihong Wang <zhihong.wang@intel.com>,
 David Hunt <david.hunt@intel.com>
Message-ID: <20200903092052.GA1615@bricha3-MOBL.ger.corp.intel.com>
References: <20200821184855.2220-1-dmitry.kozliuk@gmail.com>
 <20200902183805.5421-1-dmitry.kozliuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200902183805.5421-1-dmitry.kozliuk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows
	system types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote:
> cmdline_numtype member names clash with Windows system identifiers.
> Add CMDLINE_ prefix to cmdline constants to avoid this and possible
> future conflicts.
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Suggested-by: Ranjit Menon <ranjit.menon@intel.com>
> ---

Is CMDLINE the best prefix to use here. The DPDK standard is obviously RTE_
as a prefix. This is one I suggested previously (over a year ago, actually):

http://patches.dpdk.org/patch/52644/

/Bruce