From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A33F0A04D7; Thu, 3 Sep 2020 11:40:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AF351BEAF; Thu, 3 Sep 2020 11:40:43 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id ABE83E07 for ; Thu, 3 Sep 2020 11:40:40 +0200 (CEST) IronPort-SDR: omOr/THy31LEuRKtMcuZF1cx8f30N9c+sSrr2PMFcT4FDsjvfnpVUQXSzhodQjGElHuShNeP8e 638kQ45O0JDA== X-IronPort-AV: E=McAfee;i="6000,8403,9732"; a="145241208" X-IronPort-AV: E=Sophos;i="5.76,386,1592895600"; d="scan'208";a="145241208" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 02:40:39 -0700 IronPort-SDR: WLiPcX3uT3Kd52Pj+mySBj2tfvad6pfLbtVnR7kSAVr4bJhSM3l/+I/yEq4kQ0rHQzIWnhLeYn XlBMq4l4lHyg== X-IronPort-AV: E=Sophos;i="5.76,386,1592895600"; d="scan'208";a="446842612" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.24.168]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 03 Sep 2020 02:40:34 -0700 Date: Thu, 3 Sep 2020 10:40:31 +0100 From: Bruce Richardson To: Dmitry Kozlyuk Cc: dev@dpdk.org, Jie Zhou , Ranjit Menon , Olivier Matz , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Ori Kam , Marko Kovacevic , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Pavan Nikhilesh , Cristian Dumitrescu , Jasvinder Singh , Maxime Coquelin , Chenbo Xia , Zhihong Wang , David Hunt Message-ID: <20200903094031.GB1615@bricha3-MOBL.ger.corp.intel.com> References: <20200821184855.2220-1-dmitry.kozliuk@gmail.com> <20200902183805.5421-1-dmitry.kozliuk@gmail.com> <20200903092052.GA1615@bricha3-MOBL.ger.corp.intel.com> <20200903123056.0aad9d5b@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903123056.0aad9d5b@sovereign> Subject: Re: [dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows system types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 03, 2020 at 12:30:56PM +0300, Dmitry Kozlyuk wrote: > On Thu, 3 Sep 2020 10:20:52 +0100, Bruce Richardson wrote: > > On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote: > > > cmdline_numtype member names clash with Windows system identifiers. > > > Add CMDLINE_ prefix to cmdline constants to avoid this and possible > > > future conflicts. > > > > > > Signed-off-by: Dmitry Kozlyuk > > > Suggested-by: Ranjit Menon > > > --- > > > > Is CMDLINE the best prefix to use here. The DPDK standard is obviously RTE_ > > as a prefix. This is one I suggested previously (over a year ago, actually): > > > > http://patches.dpdk.org/patch/52644/ > > RTE_ is the standard indeed. I went with CMDLINE_, because this is the prefix > librte_cmdline uses for its main routines. Will change in v3 if no objections > arise. Yes, I suggest waiting for other inputs.