From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31395A04D7; Thu, 3 Sep 2020 11:31:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7FB3FE07; Thu, 3 Sep 2020 11:31:01 +0200 (CEST) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 2C5E4DE0 for ; Thu, 3 Sep 2020 11:30:59 +0200 (CEST) Received: by mail-lj1-f193.google.com with SMTP id b19so2772435lji.11 for ; Thu, 03 Sep 2020 02:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZmunjcQ/hE1Vls1jNxAwlnmfyF+KwqS0ODHyllrcWIg=; b=B18RZBNXQX+PG+tZFoxaQn4/t9428WhHd+u+/uu/BGy+H8SrHDJMcLXBooB4ImaXbV MXHvqsQ5p+5rvYCWw+GdYBanVbj6NH0jgq60iD+FefQTriIaIQb17w37D2esHZfvZuIH gDucXJYgcFsKkToyETCU5eipJ1udGnR4/FKdwmLkLHQb4TUuTzdHb36sH9Y/VZDYgyVd rXyeW1EKwPe2iJeNnhfjXwsDsu9myCbcZt+uoGpBUfd5LMZUKCt5uFbjKeY7DnI/c2/O Pi8btp00lsac45VHyyJTXZPlh8+yMDiFqLo3UW5LRs2P6CIq2eq8tP10Kd17eWot/qEV aG2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZmunjcQ/hE1Vls1jNxAwlnmfyF+KwqS0ODHyllrcWIg=; b=SAOTRtTYeusMJanpKzy2OlFcPlqD0IAWZQdIyAuMjouuhWaSwOLcQ2POT5Mb9RJ1G+ iu2AD/qZ1QCbRP/agDLhfTgmsn/jP/qTxlme7PZ2FmtZiuR8TwmzUIwTYHU106LhcBO+ q0XORc2Q1bTMQ0EsYakOoSKl4E69XWnk8BwJMPCfRmGheQU9ny5CaerDtdPItSPo0sHD 60pmHJ5YrldrHJmea4XJ4sDedbPfTUIhaJ0k/DtGJ57IpYQY62Gb25A1+0W/x7g+M6xv 4JY6FrMyyTekb2l8RyATVMsGx71CU3+3bedpqCEUeMiN6nrDOEGn/8DRhxZB8fUNllut lGnw== X-Gm-Message-State: AOAM533Blpmczpf2RW63GUMSMo+L9veAsLahCazKIufIn4OpR9aLDH1z 3JEUaR7v6rFCFicCbnVEHwk= X-Google-Smtp-Source: ABdhPJwYDUZGqEZe3WUiY+fj9MSlGUaQ3Vf/1LN9ABTE9etu7Q/nxR410f3gQeNKXQeQVOtx6LiFzQ== X-Received: by 2002:a2e:9b59:: with SMTP id o25mr881030ljj.264.1599125458645; Thu, 03 Sep 2020 02:30:58 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id t25sm479840ljk.71.2020.09.03.02.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 02:30:57 -0700 (PDT) Date: Thu, 3 Sep 2020 12:30:56 +0300 From: Dmitry Kozlyuk To: Bruce Richardson Cc: dev@dpdk.org, Jie Zhou , Ranjit Menon , Olivier Matz , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Ori Kam , Marko Kovacevic , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Pavan Nikhilesh , Cristian Dumitrescu , Jasvinder Singh , Maxime Coquelin , Chenbo Xia , Zhihong Wang , David Hunt Message-ID: <20200903123056.0aad9d5b@sovereign> In-Reply-To: <20200903092052.GA1615@bricha3-MOBL.ger.corp.intel.com> References: <20200821184855.2220-1-dmitry.kozliuk@gmail.com> <20200902183805.5421-1-dmitry.kozliuk@gmail.com> <20200903092052.GA1615@bricha3-MOBL.ger.corp.intel.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows system types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 3 Sep 2020 10:20:52 +0100, Bruce Richardson wrote: > On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote: > > cmdline_numtype member names clash with Windows system identifiers. > > Add CMDLINE_ prefix to cmdline constants to avoid this and possible > > future conflicts. > > > > Signed-off-by: Dmitry Kozlyuk > > Suggested-by: Ranjit Menon > > --- > > Is CMDLINE the best prefix to use here. The DPDK standard is obviously RTE_ > as a prefix. This is one I suggested previously (over a year ago, actually): > > http://patches.dpdk.org/patch/52644/ RTE_ is the standard indeed. I went with CMDLINE_, because this is the prefix librte_cmdline uses for its main routines. Will change in v3 if no objections arise.