DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc/prog_guide: fix formatting of notes in meson chapter
@ 2020-09-03 14:00 Bruce Richardson
  2020-09-04  8:05 ` [dpdk-dev] [dpdk-stable] " Mcnamara, John
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2020-09-03 14:00 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson, stable

The "note" callouts in the chapter describing the meson build were
incorrectly formatted, so adjust to use the correct markdown syntax.

Fixes: 9c3adc289c5e ("doc: add instructions on build using meson")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 doc/guides/prog_guide/build-sdk-meson.rst | 25 ++++++++++++++---------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/doc/guides/prog_guide/build-sdk-meson.rst b/doc/guides/prog_guide/build-sdk-meson.rst
index 44d1cafdf..d621bea56 100644
--- a/doc/guides/prog_guide/build-sdk-meson.rst
+++ b/doc/guides/prog_guide/build-sdk-meson.rst
@@ -102,14 +102,17 @@ Examples of setting some of the same options using meson configure::
 
 	meson configure -Denable_trace_fp=true
 
-NOTE: once meson has been run to configure a build in a directory, it
-cannot be run again on the same directory. Instead ``meson configure``
-should be used to change the build settings within the directory, and when
-``ninja`` is called to do the build itself, it will trigger the necessary
-re-scan from meson.
+.. note::
 
-NOTE: machine=default uses a config that works on all supported architectures
-regardless of the capabilities of the machine where the build is happening.
+        once meson has been run to configure a build in a directory, it
+        cannot be run again on the same directory. Instead ``meson configure``
+        should be used to change the build settings within the directory, and when
+        ``ninja`` is called to do the build itself, it will trigger the necessary
+        re-scan from meson.
+
+.. note::
+        machine=default uses a config that works on all supported architectures
+        regardless of the capabilities of the machine where the build is happening.
 
 As well as those settings taken from ``meson configure``, other options
 such as the compiler to use can be passed via environment variables. For
@@ -117,9 +120,11 @@ example::
 
 	CC=clang meson clang-build
 
-NOTE: for more comprehensive overriding of compilers or other environment
-settings, the tools for cross-compilation may be considered. However, for
-basic overriding of the compiler etc., the above form works as expected.
+.. note::
+
+        for more comprehensive overriding of compilers or other environment
+        settings, the tools for cross-compilation may be considered. However, for
+        basic overriding of the compiler etc., the above form works as expected.
 
 
 Performing the Build
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] doc/prog_guide: fix formatting of notes in meson chapter
  2020-09-03 14:00 [dpdk-dev] [PATCH] doc/prog_guide: fix formatting of notes in meson chapter Bruce Richardson
@ 2020-09-04  8:05 ` Mcnamara, John
  2020-10-05 21:57   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Mcnamara, John @ 2020-09-04  8:05 UTC (permalink / raw)
  To: Richardson, Bruce, dev; +Cc: Richardson, Bruce, stable

> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of Bruce Richardson
> Sent: Thursday, September 3, 2020 3:01 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; stable@dpdk.org
> Subject: [dpdk-stable] [PATCH] doc/prog_guide: fix formatting of notes in
> meson chapter
> 
> The "note" callouts in the chapter describing the meson build were
> incorrectly formatted, so adjust to use the correct markdown syntax.
> 
> Fixes: 9c3adc289c5e ("doc: add instructions on build using meson")
> Cc: stable@dpdk.org


Acked-by: John McNamara <john.mcnamara@intel.com>






^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] doc/prog_guide: fix formatting of notes in meson chapter
  2020-09-04  8:05 ` [dpdk-dev] [dpdk-stable] " Mcnamara, John
@ 2020-10-05 21:57   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-10-05 21:57 UTC (permalink / raw)
  To: Richardson, Bruce; +Cc: dev, stable, Mcnamara, John

> > The "note" callouts in the chapter describing the meson build were
> > incorrectly formatted, so adjust to use the correct markdown syntax.
> > 
> > Fixes: 9c3adc289c5e ("doc: add instructions on build using meson")
> > Cc: stable@dpdk.org
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-05 21:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 14:00 [dpdk-dev] [PATCH] doc/prog_guide: fix formatting of notes in meson chapter Bruce Richardson
2020-09-04  8:05 ` [dpdk-dev] [dpdk-stable] " Mcnamara, John
2020-10-05 21:57   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).