From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B4F9A04C5; Fri, 4 Sep 2020 20:42:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21B37E07; Fri, 4 Sep 2020 20:42:48 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 1CFB8255 for ; Fri, 4 Sep 2020 20:42:46 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id a8so1574689plm.2 for ; Fri, 04 Sep 2020 11:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NAL7kLJ3i0YTLqtbwn8R9qCb2yMu7hrzeLc7deictic=; b=HV7U3OeWlfyyj0yHYKzcjCvi4I7qw7UW54Vw2+HzsJkic8g4Fs8FGbZ2zMILnWXemA /q7nmP/BhDHoEMqXZKIJwE8F1PcqdChHToNYYMkuGQe0cZaTnl/pDSbNEnQ/MVfitJj2 zcAPaMpePTUe52gAQtn0goOYVC8MaTi9WiPVqOSWuII5S2aUrLcAJaxLkO8LX10EPzgz /lnWQTPdErymooL1rhxoDv+ppJXgVlWJueo4xEvM1HNyiXWeO+fIcTdUvWrgWXQJZiZW KdiurCbWxJn+6aygX2VhkAaq/G58kZTCN15O2n/OHoK5r5s0waHzsiYSr4D6FmEJW2e2 FEpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NAL7kLJ3i0YTLqtbwn8R9qCb2yMu7hrzeLc7deictic=; b=e3gb68rutiLXU3/Olz+7bcSK/QTVRnNF8O4Ev+hy5rBhxJGD8LYlLTb8VnSSClq5NL Abbo3lnFyq9R3A6aoaULwr1pDavEVWu5Bjoyf7pUm1xKn6qJvSr1Ko6Bv7Noy3RJYp81 RrbyHrEZEXWlDAvXXcIeXlfV9V1oxr0ri5w+7CsyRhKhsar7TbSEYFpOoG5SzRA30Jyy Fz0VXCI/N574+zBkJ1TaiLBNgUDwzte6wwBHD0RQZ6E2rqepSynB9fGIaCGalHZTYUqG 3HUYULX6dMpNXW1N5qej9d9RZO0Bdizyy/uyVsAXSL0LXHXeqvYr9yVA6lLd6QNVt4Pp 2xtQ== X-Gm-Message-State: AOAM53389zmJSaG60w3zFuiZnsgheM2vVqpLizCwkvdvnEezAzO+7KjR ottpG9LCSKoyDuw/DDI3K8XC5g== X-Google-Smtp-Source: ABdhPJwNMvD173EnaKX6+z10DhztAZAs2TpuaoAqbbJ2zSLR8t3xs3yqex0mYIyeqY0v12cFFP9iMA== X-Received: by 2002:a17:902:be0f:: with SMTP id r15mr9942437pls.84.1599244965188; Fri, 04 Sep 2020 11:42:45 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u8sm7187829pfm.133.2020.09.04.11.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 11:42:44 -0700 (PDT) Date: Fri, 4 Sep 2020 11:42:37 -0700 From: Stephen Hemminger To: Liang Ma Cc: dev@dpdk.org, david.hunt@intel.com, anatoly.burakov@intel.com Message-ID: <20200904114237.1586821a@hermes.lan> In-Reply-To: <1599214740-3927-1-git-send-email-liang.j.ma@intel.com> References: <1597141666-20621-1-git-send-email-liang.j.ma@intel.com> <1599214740-3927-1-git-send-email-liang.j.ma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 4 Sep 2020 11:18:55 +0100 Liang Ma wrote: > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these instructions. > > The power management instructions provide an architecture-specific > function to either wait until a specified TSC timestamp is reached, or > optionally wait until either a TSC timestamp is reached or a memory > location is written to. The monitor function also provides an optional > comparison, to avoid sleeping when the expected write has already > happened, and no more writes are expected. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov Before this is merged, please work with Arm maintainers to have a version that works on Arm 64 as well. Don't think this should be merged unless the two major platforms supported by DPDK can work with it. Also, not sure if this mechanism can work with other drivers. You need to work with other vendors to show that the same infrastructure can work with their hardware. Once again, I don't think this can go in if it only can work on Intel. It needs to work on Broadcom, Mellanox to be useful. Will it work in a VM? Will it work with virtio or vmxnet3? Having a single vendor solution is a non-starter for me. They don't all have to be there to get it merged, but if the design only works on single platform then it is not helpful.