From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 016C8A04C5; Fri, 4 Sep 2020 15:34:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F7F11C0CA; Fri, 4 Sep 2020 15:34:23 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AFDA91C0C0 for ; Fri, 4 Sep 2020 15:34:21 +0200 (CEST) IronPort-SDR: Y8Zhp1u+m/8XLuB8sx8RY+9ChmvmmoM3+2GFBa6EYRj9s7VXlRxPlKwZ3IZqTzD+TjrllQSq0y sxg8+aTHOFrA== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="242559330" X-IronPort-AV: E=Sophos;i="5.76,389,1592895600"; d="scan'208";a="242559330" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2020 06:34:20 -0700 IronPort-SDR: +lneX/0LPghKNBvhQ0ndJfCTiIp7CUeaYSKxqnbApQ4HoM7rdxfgY2QYL/VN2neiM2ntf7QRrR 6v+omGgV/xKA== X-IronPort-AV: E=Sophos;i="5.76,389,1592895600"; d="scan'208";a="478490121" Received: from wgleeso1-mobl.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.4.76]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 04 Sep 2020 06:34:18 -0700 Date: Fri, 4 Sep 2020 14:34:15 +0100 From: Bruce Richardson To: "Pattan, Reshma" Cc: "Power, Ciara" , "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" , "Doherty, Declan" , "Tahhan, Maryam" , "Chautru, Nicolas" , Jerin Jacob Message-ID: <20200904133415.GA301@bricha3-MOBL.ger.corp.intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20200903152717.42095-1-ciara.power@intel.com> <20200903152717.42095-36-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v3 35/37] doc: remove reference to make in tools guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 04, 2020 at 09:04:48AM +0000, Pattan, Reshma wrote: > > > > -----Original Message----- From: Power, Ciara > > > > diff --git a/doc/guides/tools/pdump.rst b/doc/guides/tools/pdump.rst > > index + * The ``dpdk-pdump`` tool depends on libpcap based PMD > > which must be + installed on the board. + Once the > > libpcap development files are installed, recompile the DPDK. > > > > Might be rewrite the sentence as below > > The ``dpdk-pdump`` tool depends on DPDK pcap PMD, so the system should > have libpcap development files installed and the pcap PMD enabled in the > build. > Sounds good, though I'd suggest changing "enabled" to "not disabled" since all drivers are enabled if their dependencies are present, unless they are explicitly disabled.