From: Stephen Hemminger <stephen@networkplumber.org>
To: Chengchang Tang <tangchengchang@huawei.com>
Cc: <dev@dpdk.org>, <linuxarm@huawei.com>, <thomas@monjalon.net>,
<arybchenko@solarflare.com>, <ferruh.yigit@intel.com>,
<wenzhuo.lu@intel.com>, <maryam.tahhan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/5] ethdev: add a field for rxq info structure
Date: Sat, 5 Sep 2020 09:50:41 -0700 [thread overview]
Message-ID: <20200905095041.3fb6ea5b@hermes.lan> (raw)
In-Reply-To: <1599296854-56620-2-git-send-email-tangchengchang@huawei.com>
On Sat, 5 Sep 2020 17:07:30 +0800
Chengchang Tang <tangchengchang@huawei.com> wrote:
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index 70295d7..859111a 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -1420,6 +1420,8 @@ struct rte_eth_rxq_info {
> struct rte_eth_rxconf conf; /**< queue config parameters. */
> uint8_t scattered_rx; /**< scattered packets RX supported. */
> uint16_t nb_desc; /**< configured number of RXDs. */
> + /**< Buffer size used for HW when receive packets. */
> + uint16_t rx_buf_size;
Minor suggestion.
If you shorten the comment (which is not that useful) and use the same
case, then it will fit on the same line and look like the rest of the code.
uint16_t rx_buf_size; /**< hardware receive buffer size */
next prev parent reply other threads:[~2020-09-05 16:50 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 12:35 [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info Chengchang Tang
2020-08-26 1:57 ` [dpdk-dev] [PATCH 0/3] add RX buffer size " Chengchang Tang
2020-08-26 1:57 ` [dpdk-dev] [PATCH 1/3] ethdev: add a field " Chengchang Tang
2020-08-26 1:57 ` [dpdk-dev] [PATCH 2/3] app/testpmd: Add RX buffer size display in queue info querry Chengchang Tang
2020-08-26 1:57 ` [dpdk-dev] [PATCH 3/3] net/hns3: add RX buffer size to rx qinfo querry Chengchang Tang
2020-08-26 7:12 ` [dpdk-dev] [PATCH v2 0/3] add Rx buffer size for rxq info structure Chengchang Tang
2020-08-26 7:12 ` [dpdk-dev] [PATCH v2 1/3] ethdev: add a field " Chengchang Tang
2020-08-26 7:29 ` Wei Hu (Xavier)
2020-08-26 7:12 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: add Rx buffer size display in queue info query Chengchang Tang
2020-08-26 7:28 ` Wei Hu (Xavier)
2020-08-26 14:42 ` Stephen Hemminger
2020-08-29 6:48 ` Chengchang Tang
2020-08-26 7:12 ` [dpdk-dev] [PATCH v2 3/3] net/hns3: add Rx buffer size to Rx qinfo query Chengchang Tang
2020-08-26 7:20 ` Wei Hu (Xavier)
2020-08-29 7:13 ` [dpdk-dev] [PATCH v3 0/4] add Rx buffer size for rxq info structure Chengchang Tang
2020-08-29 7:13 ` [dpdk-dev] [PATCH v3 1/4] ethdev: add a field " Chengchang Tang
2020-09-01 15:33 ` Matan Azrad
2020-09-02 3:52 ` Chengchang Tang
2020-09-02 7:19 ` Matan Azrad
2020-09-02 10:01 ` Chengchang Tang
2020-09-02 10:30 ` Matan Azrad
2020-09-03 1:48 ` Chengchang Tang
2020-09-06 13:45 ` Matan Azrad
2020-09-07 7:47 ` Chengchang Tang
2020-09-07 8:28 ` Matan Azrad
2020-09-07 12:06 ` Chengchang Tang
2020-09-07 13:02 ` Matan Azrad
2020-09-03 15:00 ` Ferruh Yigit
2020-09-03 14:55 ` Ferruh Yigit
2020-09-03 15:01 ` Ferruh Yigit
2020-09-04 1:43 ` Chengchang Tang
2020-09-03 15:35 ` Bruce Richardson
2020-09-04 14:25 ` Ferruh Yigit
2020-09-04 15:14 ` Bruce Richardson
2020-09-04 15:30 ` Bruce Richardson
2020-08-29 7:13 ` [dpdk-dev] [PATCH v3 2/4] app/testpmd: add Rx buffer size display in queue info query Chengchang Tang
2020-08-29 7:13 ` [dpdk-dev] [PATCH v3 3/4] app/procinfo: add Rx buffer size to --show-port Chengchang Tang
2020-08-29 7:13 ` [dpdk-dev] [PATCH v3 4/4] net/hns3: add Rx buffer size to Rx qinfo query Chengchang Tang
2020-09-05 9:07 ` [dpdk-dev] [PATCH v4 0/5] add Rx buffer size for rxq info structure Chengchang Tang
2020-09-05 9:07 ` [dpdk-dev] [PATCH v4 1/5] ethdev: add a field " Chengchang Tang
2020-09-05 16:50 ` Stephen Hemminger [this message]
2020-09-05 9:07 ` [dpdk-dev] [PATCH v4 2/5] app/testpmd: add Rx buffer size display in queue info query Chengchang Tang
2020-09-18 8:54 ` Ferruh Yigit
2020-09-20 8:47 ` Chengchang Tang
2020-09-05 9:07 ` [dpdk-dev] [PATCH v4 3/5] app/procinfo: add Rx buffer size to --show-port Chengchang Tang
2020-09-05 16:59 ` Stephen Hemminger
2020-09-07 9:14 ` Chengchang Tang
2020-09-18 22:11 ` Stephen Hemminger
2020-09-21 2:06 ` Chengchang Tang
2020-09-21 11:26 ` Ferruh Yigit
2020-09-05 9:07 ` [dpdk-dev] [PATCH v4 4/5] net/hns3: add Rx buffer size to Rx qinfo query Chengchang Tang
2020-09-05 9:07 ` [dpdk-dev] [PATCH v4 5/5] doc: remove rxq info structure deprecation notice Chengchang Tang
2020-09-05 16:33 ` Thomas Monjalon
2020-09-07 9:12 ` Chengchang Tang
2020-09-21 13:22 ` [dpdk-dev] [PATCH v5 0/2] add Rx buffer size for rxq info structure Chengchang Tang
2020-09-21 13:22 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add a field " Chengchang Tang
2020-09-21 14:18 ` Ferruh Yigit
2020-09-21 13:22 ` [dpdk-dev] [PATCH v5 2/2] net/hns3: add Rx buffer size to Rx qinfo query Chengchang Tang
2020-09-21 14:19 ` [dpdk-dev] [PATCH v5 0/2] add Rx buffer size for rxq info structure Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200905095041.3fb6ea5b@hermes.lan \
--to=stephen@networkplumber.org \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linuxarm@huawei.com \
--cc=maryam.tahhan@intel.com \
--cc=tangchengchang@huawei.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).