From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D43EA04B9; Mon, 7 Sep 2020 10:18:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF6F71BE0C; Mon, 7 Sep 2020 10:18:35 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 4439D2BAB for ; Mon, 7 Sep 2020 10:18:34 +0200 (CEST) IronPort-SDR: Cq1Q2yf8BhRw2mVC+ZUBuwTVwDDBABDkEX4q66OoVkbNXm4gDNSuI9Vi+m+Fg/Q+pSB6GoML87 1hWwbQIQS6yQ== X-IronPort-AV: E=McAfee;i="6000,8403,9736"; a="145680256" X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="145680256" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2020 01:18:33 -0700 IronPort-SDR: rXPo3bBUfS6SfBVj0YfFspuhGst0xbj2B5VXzA882INTZsyJ9QRKb4NJoIyRlLzDYzA7QlhioA 9jQWSQhP9lwQ== X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="448342174" Received: from rnkellet-mobl.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.251.80.24]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Sep 2020 01:18:31 -0700 Date: Mon, 7 Sep 2020 09:18:28 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Ciara Power , dev@dpdk.org, Anatoly Burakov , Beilei Xing , Jeff Guo Message-ID: <20200907081828.GA312@bricha3-MOBL.ger.corp.intel.com> References: <20200903152717.42095-17-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v3 16/37] drivers: remove references to make config options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Sep 06, 2020 at 12:24:49PM +0200, Thomas Monjalon wrote: > On Thu Sep 3, 2020 at 6:26 PM CEST, Ciara Power wrote: > > Make is no longer supported for compiling DPDK, references are now > > removed in code comments. > > It should be squashed with the patch removing the config options. > > In general, I feel this patchset would benefit a bit more squashing. Yes, but that makes it harder to review and work with. For example, for removing the config options each document needs to be modified to remove references to those, and once make itself is removed again all docs need to be modified. To review properly, the doc needs to be scanned to check no references, especially indirect references, are missed. Given that e.g. the NIC guide doc is 55 chapters, that's a whole lot of reviewing you want to minimize, so having all changes to that one doc in one patch is much more feasible. Really, removing the whole build system could all be done in one patch, as removing parts a bit at a time doesn't really make sense as it's all broken once one part is gone. However, the resulting patch would be enormous, so I suggest keeping the parts separate for review and then squash on merge if so desired. /Bruce