From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 689EDA04B7; Mon, 7 Sep 2020 13:12:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 493371BE85; Mon, 7 Sep 2020 13:12:57 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4EB511BE0C for ; Mon, 7 Sep 2020 13:12:55 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 087BBYoL014413; Mon, 7 Sep 2020 04:12:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0220; bh=3akHCvQYPp1CYvZ0mnWBPtEppKgP7pEdqh+huQchDyY=; b=DDXsaOfeT4Ll91x0iZ41dyCg9cPquIFdPSUXfC2dg+ZKtYKdSsPqEIJXX4dXTCM5r/wz AcM2Ggfav4KreByL4jXrRtdM9qK+rWPCuqB6xHLW92n5Ziz4eoJaoc2aoSwcbO3DGgVx AtQ6pgdSEI82gG0ErlgH7MLmU89Jey9UTA0dcX29TOjMkxH8ZQKKW/GNJMbRFTGR96q6 CgP0MKEVQWfMAddhU0+udrwIKZVzJ6ggUXhufCeL6lrNAmfzK3OFjzvXw5wqMjHWXlMS ffdNDCfmqZYh5wLF2D4g7MGx2SRQEpVgs6Hjp3IOUl4HaBIg6Cpn3oDYCcP4HGU2D16l UA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 33c81pqptq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 07 Sep 2020 04:12:48 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Sep 2020 04:12:47 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.54) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 7 Sep 2020 04:12:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gYUmooLEhbB9SRYGk89XkQnSTExIuNRHq8Qsg07PQxd+T7WR7SG5i8AWKqCYaKVFX8xImuZh6QIU/c5K4WP0ifDdYboPhOt0HiQ/8/JiZZ78s63MygaGDkKHUFpne+9bfGKOu7AlHIbjT6kEhq5LhxasQws7CZ/pB/Xk8gRN/eHg4eiGC3vU9jpyNkBZyfU0T/mNms2fA1V/7zAttQokqrI5nCDXwM3gpfFWrexRT0hlTzRooRWmhKKOaa5OiQXLmrcDyE1nwOimJHfS2p2rBfo8yleFTDvrpLO6BPxzbPJ9aXVMdK7sazy5Cg420Yj/FZEKy+kkGKTIsEiSTKxYig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3akHCvQYPp1CYvZ0mnWBPtEppKgP7pEdqh+huQchDyY=; b=MwNUK7ndsFQPuN/IpUAuiMEeKurSzstfaxhjZB0zVMSkWCc96qmGd95K+flZu1L5lHHnuznu9tmX2YtJJrufR1urAJQUPx92EpmaRV50Cj6lJ2gFCje9a1ZpT7S7EBMkDvseCbvz0cSU79Y3VeA2QkWdIkQeJxyndnRff6nG5w9MTI3FW75+Bii9T//MVMZkdbS5+4ADd/2TeXxEiLKl6xVX5pEKjHu3smC08h/LXFJ3sGYjGrqA8tE8dTAPfn4SE3u59+GRpifaXB6GWpdBRledn8UghmJPOEFIzOpy3pFVG1nQb5vKs/7HWa9GqKSQOC4hAd4PUX11pRCOW5Izyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3akHCvQYPp1CYvZ0mnWBPtEppKgP7pEdqh+huQchDyY=; b=e0dympU046xuElKtCltgShmk6IbV54rxHI3uCsAH4VabDXZM8Mxr1YPYZCVIJFpSvX0yQKru2y1POH72qOLB95kFPl967uGbBCuFlv/KejP/7xrUyPZ6EDimd7mHYMTzdqyJEWxrdO5ApkLuaeIdDKlIJBhFxupwpYIMzBUFg2Y= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; Received: from BN8PR18MB2386.namprd18.prod.outlook.com (2603:10b6:408:68::25) by BN6PR18MB0915.namprd18.prod.outlook.com (2603:10b6:404:72::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Mon, 7 Sep 2020 11:12:45 +0000 Received: from BN8PR18MB2386.namprd18.prod.outlook.com ([fe80::69ba:f95b:c06b:150e]) by BN8PR18MB2386.namprd18.prod.outlook.com ([fe80::69ba:f95b:c06b:150e%4]) with mapi id 15.20.3348.019; Mon, 7 Sep 2020 11:12:45 +0000 Date: Mon, 7 Sep 2020 16:42:28 +0530 From: Nithin Dabilpuram To: Ferruh Yigit CC: "Dumitrescu, Cristian" , "jerinj@marvell.com" , Bruce Richardson , Thomas Monjalon , Jerin Jacob , Luca Boccassi , Nithin Dabilpuram , "Singh, Jasvinder" , Andrew Rybchenko , "dev@dpdk.org" , "kkanas@marvell.com" , "Kinsella, Ray" , Neil Horman , Kevin Traynor , David Marchand Message-ID: <20200907111228.GA14807@outlook.office365.com> References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200428144535.GC1897@bricha3-MOBL.ger.corp.intel.com> <19c8b69f68bcdb7ac23126e63456223f7aff0465.camel@debian.org> <1923738.gORTcIGjah@thomas> <20200429090354.GA1903@bricha3-MOBL.ger.corp.intel.com> <74165680-6b05-a7c3-21a7-c66372b462e4@intel.com> <20200501131634.GA24835@outlook.office365.com> <1a6121c7-58d6-a2e4-e93d-fe50dfd58bb0@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a6121c7-58d6-a2e4-e93d-fe50dfd58bb0@intel.com> User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: BM1PR0101CA0024.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::34) To BN8PR18MB2386.namprd18.prod.outlook.com (2603:10b6:408:68::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by BM1PR0101CA0024.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16 via Frontend Transport; Mon, 7 Sep 2020 11:12:41 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: accaffe4-3e46-44c9-9acb-08d8531ef241 X-MS-TrafficTypeDiagnostic: BN6PR18MB0915: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ucEJY6lVE3C+/imjQUNOt8HahXFFycfMhgOiEKaWIyUba2yf9QBFU3anjs+oaU4LQJUgkXSFkcSOJeaWqYqygaebN8//yDdvFODv+e2o6s2751hjVQP4KhTho2/vDWSzGEpCV05MM9wrd17ct9PPVMslE72smasEXnBgqGyDMRs7mzmW2VnBzuBARZBbSfYuRtslVa2A4AmmIcvzh3C1lti8yilMROHXbO2dHZOXJrtwU03J+M8WKtiL9V0de7a0ckwtCKLAXlBF6a90mwHbRR4ZZbwDrKXod6pTULsZMp5lUc8IbAHRfTrK0yrW8F5+rS0UVwmsoBgRDGvBhFzAkamxFeagUeo+n08vM+fj+0ojir7GxKQ4p4O9PP/XRLtYurpnc8MSbyZHRVK7WVpBTg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR18MB2386.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39850400004)(346002)(396003)(376002)(136003)(1076003)(2906002)(6916009)(966005)(53546011)(55016002)(86362001)(4326008)(16526019)(26005)(6506007)(186003)(52116002)(7696005)(33656002)(55236004)(83380400001)(8676002)(8936002)(316002)(54906003)(478600001)(5660300002)(956004)(9686003)(7416002)(6666004)(66946007)(66556008)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: YnCB0KmvzpS6pfhrCfLoiniutfUvKcPJp3Pb/t99LSVal9LWl1iH84Xbcu9AdYO2JWf9IwjEuQ4RQYTurJd5CrlARe65ISxE6Xn9Hx3FoIGEu3rhDmzGsIN38mTR/roayPWOvGpvyUYo90pKuvKZm/BMrvbezNxnqGuanNLDR32HNxve7n12aHGVwEu/DK5S17RGyf5rod9y1OzgUquPig4xpGJifZ+btb8F2ZeK5Wk3EiCEbQ++1F2xXM72OINZoZCjBBt1IRk7Up8Ni5/uJHzBzF/Gilf3kDsGTkf6mt/NUQhI6FUClRiAcK24C1ALj8cd+jY4iWb5wkj11yLIfPMUlxXLiF6DuXNyfsfWvoZRzjV7d8MXQlgOw+Fg/IzFLWIUnehgUtM/2SYMvJGmIeo9WuSF+kFZCgEgjPf7I8NvEBhNTVSnF/ykE3Zmpta+EXkYVmwAh1Ei7eJdo+TE2MYBJKHCyZ0nGAeAUhu5QvBjmRaNX751lsuGhXKRJOpVmBDBvRexLXdELOXeNcxwUpooxy24s5uWYafGlcPJTWdLHnE8vZ4G9sjr5mLBoQ7lLEVVY+sgzDJ52aQ2NWDqivRSGEav6DCt6JzKCtpaNMgBktQ8CBJdWQg8aOj/klJ3yYGxgX4mTYoD8REiqs1LoQ== X-MS-Exchange-CrossTenant-Network-Message-Id: accaffe4-3e46-44c9-9acb-08d8531ef241 X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2386.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2020 11:12:45.5602 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uy9q83vJS8WMdfMMxEgR7s8HVSNgVlhRRqavp9DUfwqrmqLYwGlogABUId4PtkYkNO5iNwHS39uN/rvh1tQNAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB0915 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-07_06:2020-09-07, 2020-09-07 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 25, 2020 at 05:59:10PM +0100, Ferruh Yigit wrote: > On 5/1/2020 2:16 PM, Nithin Dabilpuram wrote: > > On Fri, May 01, 2020 at 11:27:02AM +0100, Ferruh Yigit wrote: > >> External Email > >> > >> ---------------------------------------------------------------------- > >> On 4/29/2020 10:03 AM, Bruce Richardson wrote: > >>> On Wed, Apr 29, 2020 at 09:45:44AM +0100, Dumitrescu, Cristian wrote: > >>>> > >>>> > >>>>> -----Original Message----- > >>>>> From: Thomas Monjalon > >>>>> Sent: Tuesday, April 28, 2020 4:54 PM > >>>>> To: Jerin Jacob ; Dumitrescu, Cristian > >>>>> > >>>>> Cc: Richardson, Bruce ; Yigit, Ferruh > >>>>> ; Luca Boccassi ; Nithin > >>>>> Dabilpuram ; Singh, Jasvinder > >>>>> ; Andrew Rybchenko > >>>>> ; dev@dpdk.org; jerinj@marvell.com; > >>>>> kkanas@marvell.com; Nithin Dabilpuram ; > >>>>> Kinsella, Ray ; Neil Horman > >>>>> ; Kevin Traynor ; David > >>>>> Marchand > >>>>> Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper > >>>>> config in pkt mode > >>>>> > >>>>> 28/04/2020 17:04, Luca Boccassi: > >>>>>> On Tue, 2020-04-28 at 15:45 +0100, Bruce Richardson wrote: > >>>>>>> On Tue, Apr 28, 2020 at 03:06:20PM +0100, Ferruh Yigit wrote: > >>>>>>>> On 4/27/2020 5:59 PM, Jerin Jacob wrote: > >>>>>>>>> On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit > >>>>> wrote: > >>>>>>>>>> On 4/27/2020 5:29 PM, Jerin Jacob wrote: > >>>>>>>>>>> On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit > >>>>> wrote: > >>>>>>>>>>>> On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: > >>>>>>>>>>>>> From: Yigit, Ferruh > >>>>>>>>>>>>>> On 4/24/2020 11:28 AM, Dumitrescu, Cristian wrote: > >>>>>>>>>>>>>>> From: Nithin Dabilpuram > >>>>>>>>>>>>>>>> This patch also updates tm port/level/node capability > >>>>> structures with > >>>>>>>>>>>>>>>> exiting features of scheduler wfq packet mode, > >>>>> scheduler wfq byte mode > >>>>>>>>>>>>>>>> and private/shared shaper byte mode. > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> SoftNIC PMD is also updated with new capabilities. > >>>>> [...] > >>>>>>>>>>>>>> Hi Nithin, > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> It looks like patch is causing ABI break, I am getting following > >>>>> warning [1], > >>>>>>>>>>>>>> can you please check? > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> [1] > >>>>>>>>>>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__pastebin.com_XYNFg14u&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=FZ_tPCbgFOh18zwRPO9H0yDx8VW38vuapifdDfc8SFQ&m=ej5sP3-cEhEoCTZOia-QivXqgljtzBcMLtZGs-5c-Uc&s=B8z_5mQ2xO3C1izjmRe2zBApMrCUcW6KcAN-adglhJQ&e= > >>>>>>>>>>>>> > >>>>>>>>>>>>> Hi Ferruh, > >>>>>>>>>>>>> > >>>>>>>>>>>>> The RTE_TM API is marked as experimental, > >>>>>>>>>>>>> but it looks that this was not correctly marked > >>>>>>>>>>>>> when __rte_experimental ABI checker was introduced. > >>>>>>>>>>>>> > >>>>>>>>>>>>> It is marked as experimental at the top of the rte_tm.h, > >>>>>>>>>>>>> similarly to other APIs introduced around same time, > >>>>>>>>>>>>> but it was not correctly picked up by the ABI check procedure > >>>>>>>>>>>>> when later introduced, so __rte_experimental was not added > >>>>> to every function. > >>>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> :( > >>>>>>>>>>>> > >>>>>>>>>>>> Is it time to mature them? > >>>>>>>>>>>> > >>>>>>>>>>>> As you said they are not marked as experimental both in header > >>>>> file (function > >>>>>>>>>>>> declarations) and .map file. > >>>>>>>>>>>> > >>>>>>>>>>>> The problem is, they are not marked as experimental in > >>>>> DPDK_20.0 ABI (v19.11), > >>>>>>>>>>>> so marking them as experimental now will break the ABI. Not > >>>>> sure what to do, > >>>>>>>>>>>> cc'ed a few ABI related names for comment. > >>>>>>>>>>>> > >>>>>>>>>>>> For me, we need to proceed as the experimental tag removed > >>>>> and APIs become > >>>>>>>>>>>> mature starting from v19.11, since this is what happened in > >>>>> practice, and remove > >>>>>>>>>>>> a few existing being experimental references in the doxygen > >>>>> comments. > >>>>>>>>>>> > >>>>>>>>>>> I think, accidentally we can not make a library as NON- > >>>>> experimental. > >>>>>>>>>>> TM never went through experimental to mature transition(see git > >>>>> log > >>>>>>>>>>> lib/librte_ethdev/rte_tm.h) > >>>>>>>>>>> It was a bug to not mark as experimental in each function in the > >>>>> ABI process. > >>>>>>>>>>> Some of the features like packet marking are not even > >>>>> implemented by any HW. > >>>>>>>>>>> I think, we can make API stable only all the features are > >>>>> implemented > >>>>>>>>>>> by one or two HW. > >>>>> > >>>>> Yes this is what was decided one or two years ago I think. > >>>>> But rte_tm API was introduced 3 years ago and is implemented by 6 PMDs. > >>>>> > >>>>> > >>>>> > >>>>>>>>>> Fair enough, specially if the API is not ready yet. > >>>>>>>>>> > >>>>>>>>>> But they were part of stable ABI, and marking them as experimental > >>>>> now will > >>>>>>>>>> break the old applications using these APIs. > >>>>>>>>> > >>>>>>>>> it is still marked as EXPERIMENTAL everywhere and API is not ready > >>>>> yet. > >>>>> > >>>>> rte_tm is implemented in 6 PMDs. > >>>>> > >>>>> > >>>>>>>> Existing experimental marks are text only for human parsing. > >>>>>>>> > >>>>>>>> The compiler attribute and build time checks are missing, and the > >>>>> symbol in the > >>>>>>>> binary doesn't have experimental tag. Our scripts and automated > >>>>> checks won't > >>>>>>>> detect it as experimental. > >>>>>>>> > >>>>>>>> My point is just having experimental comment in header file is not > >>>>> enough to > >>>>>>>> qualify the APIs as experimental. > >>>>>>>> > >>>>>>>>> Anyway, we need to break the ABI to make it work on various HW. > >>>>> > >>>>> Yes this is why I was asking in 19.11 to check our API, > >>>>> in order to avoid such situation. > >>>>> > >>>>> > >>>>>>>>> I am not sure what to do? > >>>>> > >>>>> Either manage ABI versioning, or wait 20.11. > >>>>> > >>>>> > >>>>>>>>> IMO, We need to send a patch as Fixes: for the bug of not adding > >>>>>>>>> __rte_experimental in each function. > >>>>> > >>>>> No, this is wrong. > >>>>> > >>>> > >>>> Why exactly is this wrong? This is the gap that caused the current discussion, right? > >>>> > >>> It's wrong for this release, since we can't change things from stable back > >>> to experimental. Any such patch will have to wait for 20.11, as agreed in > >>> the discussion. > >>> > >> > >> Deferring the patchet for this release. > >> > >> Reminder that if the option "to mark rte_tm_* as experimental in v20.11" > >> selected, requires deprecation notice before v20.11. > > > > Thanks Ferruh for reminder. I'll send a deprecation notice patch for the same. > > > > Hi Nithin Kumar, Cristian, Jerin, > > Who is working on updating APIs as experimental? We need that patch to proceed > with this one. Hi Ferruh, I'll send out a patch marking all TM API's experimental.