From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8502A04AA; Tue, 8 Sep 2020 10:18:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D57B02BAB; Tue, 8 Sep 2020 10:18:17 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 801EC2BA8 for ; Tue, 8 Sep 2020 10:18:15 +0200 (CEST) IronPort-SDR: XWQMTceFmwA2EJR7staMsAUjlfHoee5dxiNV9zjKBh1DtwT5Uq/KfXNPRwr4xCSU85DiBDoWf/ IZlJ/EBXP+2A== X-IronPort-AV: E=McAfee;i="6000,8403,9737"; a="157359801" X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="157359801" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 01:18:13 -0700 IronPort-SDR: hCr2pKV4+dp3zmU/tJjvUzXwN/GucUECsbaOwsF9hmlg5NQFTBC9UqWrjJQ608TcLgK6Q06Z9h PeYVzX6Ue7xQ== X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="448696376" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.81.164]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 08 Sep 2020 01:18:12 -0700 Date: Tue, 8 Sep 2020 09:18:08 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: Ferruh Yigit , dev@dpdk.org Message-ID: <20200908081808.GB351@bricha3-MOBL.ger.corp.intel.com> References: <20200901165643.15668-1-stephen@networkplumber.org> <20200906034247.25111-1-stephen@networkplumber.org> <20200907085827.GC312@bricha3-MOBL.ger.corp.intel.com> <20200907102013.71343968@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200907102013.71343968@hermes.lan> Subject: Re: [dpdk-dev] [PATCH v5] usertools: add huge page setup script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 07, 2020 at 10:20:13AM -0700, Stephen Hemminger wrote: > On Mon, 7 Sep 2020 09:58:27 +0100 > Bruce Richardson wrote: > > > On Mon, Sep 07, 2020 at 09:54:29AM +0100, Ferruh Yigit wrote: > > > On 9/6/2020 4:42 AM, Stephen Hemminger wrote: > > > > This is an improved version of the setup of huge pages > > > > bases on earlier DPDK setup. Differences are: > > > > * it autodetects NUMA vs non NUMA > > > > * it allows setting different page sizes > > > > recent kernels support multiple sizes. > > > > * it accepts a parameter in bytes (not pages). > > > > > > > > If necessary the steps of clearing old settings and mounting/umounting > > > > can be done individually. > > > > > > > > Signed-off-by: Stephen Hemminger > > > > > > <...> > > > > > > > @@ -1,4 +1,9 @@ > > > > # SPDX-License-Identifier: BSD-3-Clause > > > > # Copyright(c) 2017 Intel Corporation > > > > > > > > -install_data(['dpdk-devbind.py', 'dpdk-pmdinfo.py', 'dpdk-telemetry.py'], install_dir: 'bin') > > > > +install_data([ > > > > + 'dpdk-devbind.py', > > > > + 'dpdk-pmdinfo.py', > > > > + 'dpdk-telemetry.py', > > > > + 'hugepage_setup.py' > > > > +],install_dir: 'bin') > > > > > > > > > > Should script name has 'dpdk-' prefix as others do? > > > > +1 to that. > > Ok but - in the name violates Python lint naming for modules. > The standard is underscore. We don't really need 100% lint cleanliness for all our scripts, 95% is surely enough. However, if you feel strongly, then I suggest we prefix all our python scripts with "dpdk_", rather than "dpdk-".