From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C387A04AA; Tue, 8 Sep 2020 10:26:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E6542BAB; Tue, 8 Sep 2020 10:26:04 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id EA76F1DB8 for ; Tue, 8 Sep 2020 10:26:02 +0200 (CEST) IronPort-SDR: sZ+0yyTlj4wI9urpL09lMw3axFp5B0SfAjyXqtG5988PCEeoJj30zhczcpuYLQEE0gTJUCAXbE bRDQyPlGhOYQ== X-IronPort-AV: E=McAfee;i="6000,8403,9737"; a="138140371" X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="138140371" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 01:26:02 -0700 IronPort-SDR: 0baCCdc3kCeoVlqRwNOJC6B+CqhBcen2XfoBDtwD2E/yMc+g8YC8cW2Oz07RlTbTX+GCTNc435 77IsSWvkr+ug== X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="448698489" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.81.164]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 08 Sep 2020 01:26:00 -0700 Date: Tue, 8 Sep 2020 09:25:57 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@intel.com, jerinj@marvell.com, stephen@networkplumber.org Message-ID: <20200908082557.GC351@bricha3-MOBL.ger.corp.intel.com> References: <20200907225049.547832-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] kernel: remove igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 08, 2020 at 02:14:02AM +0200, Thomas Monjalon wrote: > On Tue Sep 8, 2020 at 2:50 AM CEST, Thomas Monjalon wrote: > > As decided in the Technical Board in November 2019, > > the kernel module igb_uio is moved to the dpdk-kmods repository > > in the /linux/igb_uio/ directory. > > The code is moved with its git history in > http://git.dpdk.org/dpdk-kmods/ > > The move process started with these commands: > cd dpdk > dir=igb_uio > path1=lib/librte_eal/linuxapp/$dir > path2=kernel/linux/$dir > git format-patch -o $dir 0c9a540ed2.. -- $path1 $path2 > find $dir -type f -exec sed -i "s,$path1\|$path2,linux/$dir," '{}' \; > cd ../dpdk-kmods > git am ../dpdk/$dir/* > git filter-branch --force > --index-filter "git rm --cached --ignore-unmatch linux/$dir/Makefile" > --prune-empty --tag-name-filter cat -- --all > > Makefile and meson.build files were not imported at all. > Some other commits were skipped (virtio, vmxnet3 and Xen dom0 support), > because they were not very useful and reverted later in the history. > Anyway the original history is available forever in dpdk.git. > > Currently it cannot compile because the file rte_pci_dev_feature_defs.h > is missing, defining enum rte_intr_mode. An option is to import this file. > > It would be nice to add a README file in the new igb_uio directory. > Volunteers welcome :) In terms of building the module, one option which I think is worth considering is to try and use meson subject/wrap support to download and build this module as part of the main DPDK build, as now, when enable_kmods option is set. With a wrap file in DPDK it can automatically pull down and build the code as part of a main project build. I assume that integration into main DPDK build is still something worth having? The only thing I don't like about using a wrap file is that it has to be placed in a folder called "subproject" at the top level of the DPDK project. Thoughts, /Bruce