From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 90641A04B5;
	Wed,  9 Sep 2020 20:58:38 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 3E9281BE0C;
	Wed,  9 Sep 2020 20:58:38 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by dpdk.org (Postfix) with ESMTP id 577321DB8
 for <dev@dpdk.org>; Wed,  9 Sep 2020 20:58:37 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id A878920942AE; Wed,  9 Sep 2020 11:58:36 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A878920942AE
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1599677916;
 bh=lPVdtfyVAMvfS5w4Edvkv53iwgLqGBnO+6dzPTayGdA=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=fknuWgRZglgRzvK7zcATygFCndg8H2rs3U8UEM7a6F/SVT+8NV8Hbkgpq1L7x8Kmv
 FzhnvzDfwETiCABtjH8Rtsv1Iy+uH3y67y53PfxLzhvj6hymgLlR2kRRsIEaq7wsbK
 xUmmMhsTbxhhA2b+Man3ZvtsNcN2cB9irT4W1TSQ=
Date: Wed, 9 Sep 2020 11:58:36 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Ranjit Menon <ranjit.menon@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ocardona@microsoft.com,
 haramakr@linux.microsoft.com, pallavi.kadam@intel.com,
 dmitry.kozliuk@gmail.com, dmitrym@microsoft.com,
 Narcisa Vasile <navasile@microsoft.com>,
 Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>
Message-ID: <20200909185836.GB13245@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1597962235-4787-1-git-send-email-navasile@linux.microsoft.com>
 <c0c8dd7c-e1fb-5c35-0436-23a3452a28fa@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c0c8dd7c-e1fb-5c35-0436-23a3452a28fa@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v2] windows/netuio: add Windows NetUIO kernel
	driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Aug 20, 2020 at 06:32:02PM -0700, Ranjit Menon wrote:
> Hi, Naty
> 
> On 8/20/2020 3:23 PM, Narcisa Ana Maria Vasile wrote:
> >From: Narcisa Vasile <navasile@microsoft.com>
> >
> >The Windows NetUIO kernel driver allows the DPDK userspace
> >application to directly access the hardware.
> >
> >Cc: Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>
> >Cc: Omar Cardona <ocardona@microsoft.com>
> >Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> >---
> >
> I haven't reviewed the code yet, but a few general suggestions and
> observations:
> 
> 1. This code is going into the dpdk-kmods repo, so we don't need the
> four-level deep directory path for the source.
> 
> 2. The code can simply be in the windows/netuio directory (don't
> need 'kernel')
> 
> 3. The 'virt2phys' module that is already in the repo puts the
> build-related files (project files, solution files etc) in the same
> folder as the source files. We should do the same here. We don't
> need the mk/exec-env subfolder for these files. They can be in the
> same directory as the source.
> 
> 4. Remove the .vcxproj.user file from the patch. It is not required.
> 
> 5. The README should be renamed to simply README.rst and it can also
> be in this windows/netuio folder
> 
> 6. The existing README.rst in the windows folder contains
> information on how to build and load kernel modules in Windows. This
> new README can reference the root-level README, if required. (Also
> some of the information in this new README is out-of-date. I'll
> review that separately)
> 
> 
> ranjit m.
> 
Thank you, Ranjit! I've cleaned it up and sent v3.