From: Nithin Dabilpuram <ndabilpuram@marvell.com>
To: <ferruh.yigit@intel.com>, <bruce.richardson@intel.com>,
<cristian.dumitrescu@intel.com>, <thomas@monjalon.net>,
<bluca@debian.org>, <jasvinder.singh@intel.com>,
<arybchenko@solarflare.com>, <ray.kinsella@intel.com>,
<nhorman@tuxdriver.com>, <ktraynor@redhat.com>,
<david.marchand@redhat.com>, Ray Kinsella <mdr@ashroe.eu>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>
Subject: [dpdk-dev] [PATCH v3] ethdev: mark all traffic manager API as experimental
Date: Thu, 10 Sep 2020 15:39:29 +0530 [thread overview]
Message-ID: <20200910100929.25759-1-ndabilpuram@marvell.com> (raw)
In-Reply-To: <20200909172200.30610-1-ndabilpuram@marvell.com>
This patch marks all traffic manager API as experimental as
per deprecation notice[1] and discussion[2] mentioned in following
threads.
[1] https://mails.dpdk.org/archives/dev/2020-May/166221.html
[2] https://mails.dpdk.org/archives/dev/2020-April/165364.html
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 7 ----
lib/librte_ethdev/rte_ethdev_version.map | 62 ++++++++++++++++----------------
lib/librte_ethdev/rte_tm.h | 33 ++++++++++++++++-
3 files changed, 64 insertions(+), 38 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index dae4dbf..cd6b2c8 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -237,13 +237,6 @@ Deprecation Notices
following the IPv6 header, as proposed in RFC
https://mails.dpdk.org/archives/dev/2020-August/177257.html.
-* traffic manager: All traffic manager API's in ``rte_tm.h`` were mistakenly made
- ABI stable in the v19.11 release. The TM maintainer and other contributors have
- agreed to keep the TM APIs as experimental in expectation of additional spec
- improvements. Therefore, all APIs in ``rte_tm.h`` will be marked back as
- experimental in v20.11 DPDK release. For more details, please see `the thread
- <https://mails.dpdk.org/archives/dev/2020-April/164970.html>`_.
-
* pmd_dpaa: The API ``rte_pmd_dpaa_set_tx_loopback`` will have extended
``port_id`` definition from ``uint8_t`` to ``uint16_t``.
diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map
index 1212a17..3da4512 100644
--- a/lib/librte_ethdev/rte_ethdev_version.map
+++ b/lib/librte_ethdev/rte_ethdev_version.map
@@ -135,36 +135,6 @@ DPDK_20.0 {
rte_flow_isolate;
rte_flow_query;
rte_flow_validate;
- rte_tm_capabilities_get;
- rte_tm_get_number_of_leaf_nodes;
- rte_tm_hierarchy_commit;
- rte_tm_level_capabilities_get;
- rte_tm_mark_ip_dscp;
- rte_tm_mark_ip_ecn;
- rte_tm_mark_vlan_dei;
- rte_tm_node_add;
- rte_tm_node_capabilities_get;
- rte_tm_node_cman_update;
- rte_tm_node_delete;
- rte_tm_node_parent_update;
- rte_tm_node_resume;
- rte_tm_node_shaper_update;
- rte_tm_node_shared_shaper_update;
- rte_tm_node_shared_wred_context_update;
- rte_tm_node_stats_read;
- rte_tm_node_stats_update;
- rte_tm_node_suspend;
- rte_tm_node_type_get;
- rte_tm_node_wfq_weight_mode_update;
- rte_tm_node_wred_context_update;
- rte_tm_shaper_profile_add;
- rte_tm_shaper_profile_delete;
- rte_tm_shared_shaper_add_update;
- rte_tm_shared_shaper_delete;
- rte_tm_shared_wred_context_add_update;
- rte_tm_shared_wred_context_delete;
- rte_tm_wred_profile_add;
- rte_tm_wred_profile_delete;
local: *;
};
@@ -241,6 +211,38 @@ EXPERIMENTAL {
__rte_ethdev_trace_rx_burst;
__rte_ethdev_trace_tx_burst;
rte_flow_get_aged_flows;
+
+ # Marked as experimental in 20.11
+ rte_tm_capabilities_get;
+ rte_tm_get_number_of_leaf_nodes;
+ rte_tm_hierarchy_commit;
+ rte_tm_level_capabilities_get;
+ rte_tm_mark_ip_dscp;
+ rte_tm_mark_ip_ecn;
+ rte_tm_mark_vlan_dei;
+ rte_tm_node_add;
+ rte_tm_node_capabilities_get;
+ rte_tm_node_cman_update;
+ rte_tm_node_delete;
+ rte_tm_node_parent_update;
+ rte_tm_node_resume;
+ rte_tm_node_shaper_update;
+ rte_tm_node_shared_shaper_update;
+ rte_tm_node_shared_wred_context_update;
+ rte_tm_node_stats_read;
+ rte_tm_node_stats_update;
+ rte_tm_node_suspend;
+ rte_tm_node_type_get;
+ rte_tm_node_wfq_weight_mode_update;
+ rte_tm_node_wred_context_update;
+ rte_tm_shaper_profile_add;
+ rte_tm_shaper_profile_delete;
+ rte_tm_shared_shaper_add_update;
+ rte_tm_shared_shaper_delete;
+ rte_tm_shared_wred_context_add_update;
+ rte_tm_shared_wred_context_delete;
+ rte_tm_wred_profile_add;
+ rte_tm_wred_profile_delete;
};
INTERNAL {
diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h
index f9c0cf3..c80c0bc 100644
--- a/lib/librte_ethdev/rte_tm.h
+++ b/lib/librte_ethdev/rte_tm.h
@@ -16,7 +16,8 @@
* traffic shaping, congestion management, packet marking, etc.
*
* @warning
- * @b EXPERIMENTAL: this API may change without prior notice
+ * @b EXPERIMENTAL:
+ * All functions in this file may be changed or removed without prior notice.
*/
#include <stdint.h>
@@ -1050,6 +1051,7 @@ struct rte_tm_error {
* @return
* 0 on success, non-zero error code otherwise.
*/
+__rte_experimental
int
rte_tm_get_number_of_leaf_nodes(uint16_t port_id,
uint32_t *n_leaf_nodes,
@@ -1074,6 +1076,7 @@ rte_tm_get_number_of_leaf_nodes(uint16_t port_id,
* @return
* 0 on success, non-zero error code otherwise.
*/
+__rte_experimental
int
rte_tm_node_type_get(uint16_t port_id,
uint32_t node_id,
@@ -1092,6 +1095,7 @@ rte_tm_node_type_get(uint16_t port_id,
* @return
* 0 on success, non-zero error code otherwise.
*/
+__rte_experimental
int
rte_tm_capabilities_get(uint16_t port_id,
struct rte_tm_capabilities *cap,
@@ -1112,6 +1116,7 @@ rte_tm_capabilities_get(uint16_t port_id,
* @return
* 0 on success, non-zero error code otherwise.
*/
+__rte_experimental
int
rte_tm_level_capabilities_get(uint16_t port_id,
uint32_t level_id,
@@ -1132,6 +1137,7 @@ rte_tm_level_capabilities_get(uint16_t port_id,
* @return
* 0 on success, non-zero error code otherwise.
*/
+__rte_experimental
int
rte_tm_node_capabilities_get(uint16_t port_id,
uint32_t node_id,
@@ -1157,6 +1163,7 @@ rte_tm_node_capabilities_get(uint16_t port_id,
*
* @see struct rte_tm_capabilities::cman_wred_context_n_max
*/
+__rte_experimental
int
rte_tm_wred_profile_add(uint16_t port_id,
uint32_t wred_profile_id,
@@ -1180,6 +1187,7 @@ rte_tm_wred_profile_add(uint16_t port_id,
*
* @see struct rte_tm_capabilities::cman_wred_context_n_max
*/
+__rte_experimental
int
rte_tm_wred_profile_delete(uint16_t port_id,
uint32_t wred_profile_id,
@@ -1211,6 +1219,7 @@ rte_tm_wred_profile_delete(uint16_t port_id,
*
* @see struct rte_tm_capabilities::cman_wred_context_shared_n_max
*/
+__rte_experimental
int
rte_tm_shared_wred_context_add_update(uint16_t port_id,
uint32_t shared_wred_context_id,
@@ -1235,6 +1244,7 @@ rte_tm_shared_wred_context_add_update(uint16_t port_id,
*
* @see struct rte_tm_capabilities::cman_wred_context_shared_n_max
*/
+__rte_experimental
int
rte_tm_shared_wred_context_delete(uint16_t port_id,
uint32_t shared_wred_context_id,
@@ -1259,6 +1269,7 @@ rte_tm_shared_wred_context_delete(uint16_t port_id,
*
* @see struct rte_tm_capabilities::shaper_n_max
*/
+__rte_experimental
int
rte_tm_shaper_profile_add(uint16_t port_id,
uint32_t shaper_profile_id,
@@ -1282,6 +1293,7 @@ rte_tm_shaper_profile_add(uint16_t port_id,
*
* @see struct rte_tm_capabilities::shaper_n_max
*/
+__rte_experimental
int
rte_tm_shaper_profile_delete(uint16_t port_id,
uint32_t shaper_profile_id,
@@ -1311,6 +1323,7 @@ rte_tm_shaper_profile_delete(uint16_t port_id,
*
* @see struct rte_tm_capabilities::shaper_shared_n_max
*/
+__rte_experimental
int
rte_tm_shared_shaper_add_update(uint16_t port_id,
uint32_t shared_shaper_id,
@@ -1334,6 +1347,7 @@ rte_tm_shared_shaper_add_update(uint16_t port_id,
*
* @see struct rte_tm_capabilities::shaper_shared_n_max
*/
+__rte_experimental
int
rte_tm_shared_shaper_delete(uint16_t port_id,
uint32_t shared_shaper_id,
@@ -1402,6 +1416,7 @@ rte_tm_shared_shaper_delete(uint16_t port_id,
* @see RTE_TM_NODE_LEVEL_ID_ANY
* @see struct rte_tm_capabilities
*/
+__rte_experimental
int
rte_tm_node_add(uint16_t port_id,
uint32_t node_id,
@@ -1435,6 +1450,7 @@ rte_tm_node_add(uint16_t port_id,
*
* @see RTE_TM_UPDATE_NODE_ADD_DELETE
*/
+__rte_experimental
int
rte_tm_node_delete(uint16_t port_id,
uint32_t node_id,
@@ -1459,6 +1475,7 @@ rte_tm_node_delete(uint16_t port_id,
* @see rte_tm_node_resume()
* @see RTE_TM_UPDATE_NODE_SUSPEND_RESUME
*/
+__rte_experimental
int
rte_tm_node_suspend(uint16_t port_id,
uint32_t node_id,
@@ -1482,6 +1499,7 @@ rte_tm_node_suspend(uint16_t port_id,
* @see rte_tm_node_suspend()
* @see RTE_TM_UPDATE_NODE_SUSPEND_RESUME
*/
+__rte_experimental
int
rte_tm_node_resume(uint16_t port_id,
uint32_t node_id,
@@ -1523,6 +1541,7 @@ rte_tm_node_resume(uint16_t port_id,
* @see rte_tm_node_add()
* @see rte_tm_node_delete()
*/
+__rte_experimental
int
rte_tm_hierarchy_commit(uint16_t port_id,
int clear_on_fail,
@@ -1563,6 +1582,7 @@ rte_tm_hierarchy_commit(uint16_t port_id,
* @see RTE_TM_UPDATE_NODE_PARENT_KEEP_LEVEL
* @see RTE_TM_UPDATE_NODE_PARENT_CHANGE_LEVEL
*/
+__rte_experimental
int
rte_tm_node_parent_update(uint16_t port_id,
uint32_t node_id,
@@ -1592,6 +1612,7 @@ rte_tm_node_parent_update(uint16_t port_id,
*
* @see struct rte_tm_capabilities::shaper_private_n_max
*/
+__rte_experimental
int
rte_tm_node_shaper_update(uint16_t port_id,
uint32_t node_id,
@@ -1619,6 +1640,7 @@ rte_tm_node_shaper_update(uint16_t port_id,
*
* @see struct rte_tm_capabilities::shaper_shared_n_max
*/
+__rte_experimental
int
rte_tm_node_shared_shaper_update(uint16_t port_id,
uint32_t node_id,
@@ -1646,6 +1668,7 @@ rte_tm_node_shared_shaper_update(uint16_t port_id,
* @see enum rte_tm_stats_type
* @see RTE_TM_UPDATE_NODE_STATS
*/
+__rte_experimental
int
rte_tm_node_stats_update(uint16_t port_id,
uint32_t node_id,
@@ -1674,6 +1697,7 @@ rte_tm_node_stats_update(uint16_t port_id,
* @see RTE_TM_UPDATE_NODE_WFQ_WEIGHT_MODE
* @see RTE_TM_UPDATE_NODE_N_SP_PRIORITIES
*/
+__rte_experimental
int
rte_tm_node_wfq_weight_mode_update(uint16_t port_id,
uint32_t node_id,
@@ -1697,6 +1721,7 @@ rte_tm_node_wfq_weight_mode_update(uint16_t port_id,
*
* @see RTE_TM_UPDATE_NODE_CMAN
*/
+__rte_experimental
int
rte_tm_node_cman_update(uint16_t port_id,
uint32_t node_id,
@@ -1721,6 +1746,7 @@ rte_tm_node_cman_update(uint16_t port_id,
*
* @see struct rte_tm_capabilities::cman_wred_context_private_n_max
*/
+__rte_experimental
int
rte_tm_node_wred_context_update(uint16_t port_id,
uint32_t node_id,
@@ -1746,6 +1772,7 @@ rte_tm_node_wred_context_update(uint16_t port_id,
*
* @see struct rte_tm_capabilities::cman_wred_context_shared_n_max
*/
+__rte_experimental
int
rte_tm_node_shared_wred_context_update(uint16_t port_id,
uint32_t node_id,
@@ -1778,6 +1805,7 @@ rte_tm_node_shared_wred_context_update(uint16_t port_id,
*
* @see enum rte_tm_stats_type
*/
+__rte_experimental
int
rte_tm_node_stats_read(uint16_t port_id,
uint32_t node_id,
@@ -1815,6 +1843,7 @@ rte_tm_node_stats_read(uint16_t port_id,
*
* @see struct rte_tm_capabilities::mark_vlan_dei_supported
*/
+__rte_experimental
int
rte_tm_mark_vlan_dei(uint16_t port_id,
int mark_green,
@@ -1865,6 +1894,7 @@ rte_tm_mark_vlan_dei(uint16_t port_id,
* @see struct rte_tm_capabilities::mark_ip_ecn_tcp_supported
* @see struct rte_tm_capabilities::mark_ip_ecn_sctp_supported
*/
+__rte_experimental
int
rte_tm_mark_ip_ecn(uint16_t port_id,
int mark_green,
@@ -1913,6 +1943,7 @@ rte_tm_mark_ip_ecn(uint16_t port_id,
*
* @see struct rte_tm_capabilities::mark_ip_dscp_supported
*/
+__rte_experimental
int
rte_tm_mark_ip_dscp(uint16_t port_id,
int mark_green,
--
2.8.4
next prev parent reply other threads:[~2020-09-10 10:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 17:16 [dpdk-dev] [PATCH] doc: deprication notice to mark tm spec " Nithin Dabilpuram
2020-05-05 6:47 ` Ray Kinsella
2020-05-05 7:45 ` [dpdk-dev] [EXT] " Nithin Dabilpuram
2020-05-05 8:07 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
2020-05-05 8:10 ` Ray Kinsella
2020-05-05 8:55 ` Dumitrescu, Cristian
2020-05-21 10:49 ` Jerin Jacob
2020-05-24 20:58 ` Nithin Kumar D
2020-05-24 23:33 ` Thomas Monjalon
2020-09-09 17:22 ` [dpdk-dev] [PATCH] ethdev: mark all traffic manager API " Nithin Dabilpuram
2020-09-09 17:49 ` Dumitrescu, Cristian
2020-09-09 18:23 ` Ferruh Yigit
2020-09-10 8:05 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
2020-09-10 8:30 ` Kinsella, Ray
2020-09-10 10:56 ` [dpdk-dev] [EXT] " Nithin Dabilpuram
2020-09-10 11:01 ` Kinsella, Ray
2020-09-10 11:22 ` Nithin Dabilpuram
2020-09-10 8:36 ` [dpdk-dev] " Ferruh Yigit
2020-09-10 8:37 ` Dumitrescu, Cristian
2020-09-10 9:54 ` [dpdk-dev] [EXT] " Nithin Dabilpuram
2020-09-10 9:51 ` [dpdk-dev] [EXT] " Nithin Dabilpuram
2020-09-10 10:09 ` Nithin Dabilpuram [this message]
2020-09-10 11:34 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910100929.25759-1-ndabilpuram@marvell.com \
--to=ndabilpuram@marvell.com \
--cc=arybchenko@solarflare.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jasvinder.singh@intel.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=ktraynor@redhat.com \
--cc=marko.kovacevic@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=ray.kinsella@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).