From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 267AEA04B5;
Thu, 10 Sep 2020 16:21:38 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 20C351C0CD;
Thu, 10 Sep 2020 16:21:32 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by dpdk.org (Postfix) with ESMTP id EFE2C1BFC3
for <dev@dpdk.org>; Thu, 10 Sep 2020 16:21:29 +0200 (CEST)
IronPort-SDR: sGSXef6SVPUCeJW4Drt9uzxC1Os3kDSGNaxNgdb+c58jnbwft75DaaIPFkGJ5S6D4xO00xPXMq
0CLsJtecL89A==
X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="138054689"
X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="138054689"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
10 Sep 2020 07:21:29 -0700
IronPort-SDR: 2mk+vFyQJGjlQXo1hx/nYNPO+ZvgskuIZkZHQrZXk3vbiqVNZhm3u7rWfcCJcadK48zBJxcENJ
v2JAQ5C+l4+w==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="329346313"
Received: from silpixa00400466.ir.intel.com ([10.237.213.195])
by fmsmga004.fm.intel.com with ESMTP; 10 Sep 2020 07:21:27 -0700
From: Conor Walsh <conor.walsh@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, ray.kinsella@intel.com, nhorman@tuxdriver.com,
aconole@redhat.com, maicolgabriel@hotmail.com, thomas@monjalon.net,
bruce.richardson@intel.com, Conor Walsh <conor.walsh@intel.com>
Date: Thu, 10 Sep 2020 14:21:18 +0000
Message-Id: <20200910142121.3995680-2-conor.walsh@intel.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20200910142121.3995680-1-conor.walsh@intel.com>
References: <20200910140116.3995345-1-conor.walsh@intel.com>
<20200910142121.3995680-1-conor.walsh@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v2 1/4] devtools: bug fix for gen-abi.sh
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
This patch fixes a bug with the gen-abi.sh script in devtools.
When ran on an install directory the script would try to generate
.dump files from directories as well as the .so files which is
not correct.
Example error: abidw: gcc/lib/librte_net.so.21.0.p is not a regular file
To rectify this the regex that finds the appropriate .so files has been
changed and the file test has been removed.
This change was tested with the ABI_CHECK Travis checks in DPDK 20.08.
Travis build:
https://travis-ci.com/github/conorwalsh-intel/dpdk/jobs/382812849
Signed-off-by: Conor Walsh <conor.walsh@intel.com>
---
devtools/gen-abi.sh | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/devtools/gen-abi.sh b/devtools/gen-abi.sh
index c44b0e228..da6fe0556 100755
--- a/devtools/gen-abi.sh
+++ b/devtools/gen-abi.sh
@@ -16,11 +16,7 @@ fi
dumpdir=$installdir/dump
rm -rf $dumpdir
mkdir -p $dumpdir
-for f in $(find $installdir -name "*.so.*"); do
- if test -L $f; then
- continue
- fi
-
+for f in $(find $installdir -name "*.so"); do
libname=$(basename $f)
abidw --out-file $dumpdir/${libname%.so*}.dump $f
done
--
2.25.1