From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15060A04B5; Fri, 11 Sep 2020 03:58:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B12951C11D; Fri, 11 Sep 2020 03:56:59 +0200 (CEST) Received: from mail-pg1-f226.google.com (mail-pg1-f226.google.com [209.85.215.226]) by dpdk.org (Postfix) with ESMTP id 364441C116 for ; Fri, 11 Sep 2020 03:56:58 +0200 (CEST) Received: by mail-pg1-f226.google.com with SMTP id 34so5429530pgo.13 for ; Thu, 10 Sep 2020 18:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MI/JHiC96O4c/wpe25GoQoUhMeU7wrr2yTdttTOusdw=; b=QU/dmZSFlYZKgadBaYc3Gcb4CM9bPlg4+ju+gd1wQhaiwKqWARULm56Eqfj8/5VoBu lphofd24AEPzMEJCCVc/zeP8AwaPtXcInYw3OnbhslT+cHpDZRYcznUJRtVke3S0n7ks jw/JhH0yQ280KieHlCbyuIcvcNh3+o4V4gUiM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MI/JHiC96O4c/wpe25GoQoUhMeU7wrr2yTdttTOusdw=; b=Djkevwwpx5gXkDq7ijiK7Dc5R7Oxb10yUAoZH7RsCnIXl0uG7LJl5QnjBWm2TP/TZE tX0NK5H/lOcw+nd/4RVP1Mt4V9PsK1mudtyYmINC35lwtECsH4IHnjo2qtM1m69zVTj6 1TjQZSWPX6mVTlVdWQGHzTuVfQGebTeRLwY/XH5rC9+TkQpoV8c1j8MtoOAAiIXPsJQ2 /yLn5LDijpx/0/hsb2mgCkCf9wprpDIy0KFIUg0TwsbI6kaBjY5uQXerJjSZvh9z8nIc GOmJ7FvCWtlBceIkK6N/FFKo2azjfwz1uQV8pgiADckp3DLBJQBsAk6ZmbLVT/MCHTj2 wEmw== X-Gm-Message-State: AOAM531cCbwrxAqQKkUPQtgA3wrewJi5jllGvXFbA5YAsLjh49ngz8FD KW8AMkKoy98t/gjNKuTZ6z9tkn+Kb83xY7QpEITa9ovg71jIe3M0B4HJOiMA/uS2eiXkATMhUko xLP8gc/ih/ZRpajMUjjBcS8yb21NlcXqTUHKagiP/sXzf1/dMUCSQv6ssps8uequD7qxuUEFwRH OGcA== X-Google-Smtp-Source: ABdhPJzDLKWsz24SKwBSMKIHhi0dYDbE2H4SpnkS4STl3PBDh0rsNNbup3sZu8VLdhPDj5gmy3eLb3Sd+oz+ X-Received: by 2002:a17:902:9a88:: with SMTP id w8mr8381754plp.67.1599789417017; Thu, 10 Sep 2020 18:56:57 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id cl6sm80986pjb.15.2020.09.10.18.56.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2020 18:56:56 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde To: dev@dpdk.org Cc: Somnath Kotur , Venkat Duvvuru Date: Thu, 10 Sep 2020 18:55:49 -0700 Message-Id: <20200911015603.88359-12-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200911015603.88359-1-ajit.khaparde@broadcom.com> References: <20200911015603.88359-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 11/25] net/bnxt: fix crash in VF rep queue selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Somnath Kotur Instead of bounds checking against max possible rings while selecting queue index for the VF rep, do it against the configured number of rings. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Somnath Kotur Reviewed-by: Venkat Duvvuru --- drivers/net/bnxt/bnxt_reps.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c index 9f535c0ce..6fa867a8a 100644 --- a/drivers/net/bnxt/bnxt_reps.c +++ b/drivers/net/bnxt/bnxt_reps.c @@ -45,9 +45,12 @@ bnxt_vfr_recv(uint16_t port_id, uint16_t queue_id, struct rte_mbuf *mbuf) vfr_eth_dev = &rte_eth_devices[port_id]; vfr_bp = vfr_eth_dev->data->dev_private; - /* If rxq_id happens to be > max rep_queue, use rxq0 */ - que = queue_id < BNXT_MAX_VF_REP_RINGS ? queue_id : 0; + /* If rxq_id happens to be > nr_rings, use ring 0 */ + que = queue_id < vfr_bp->rx_nr_rings ? queue_id : 0; rep_rxq = vfr_bp->rx_queues[que]; + /* Ideally should not happen now, paranoid check */ + if (!rep_rxq) + return 1; rep_rxr = rep_rxq->rx_ring; mask = rep_rxr->rx_ring_struct->ring_mask; -- 2.21.1 (Apple Git-122.3)