From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DA5FA04B5; Fri, 11 Sep 2020 03:57:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 388E81C11E; Fri, 11 Sep 2020 03:56:48 +0200 (CEST) Received: from mail-pg1-f228.google.com (mail-pg1-f228.google.com [209.85.215.228]) by dpdk.org (Postfix) with ESMTP id 0BC7B1C0D1 for ; Fri, 11 Sep 2020 03:56:44 +0200 (CEST) Received: by mail-pg1-f228.google.com with SMTP id j34so5451894pgi.7 for ; Thu, 10 Sep 2020 18:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k5iA3VSOPpVCKM7yb/hTCjmh/EUNfiDd+JGte8YnMSU=; b=RL+ON7ju+HUByZXdTW4t+s/Ufsp23WMdaVzQCT9SeK/MsFtJBW8CdKKSY4qcMHZI5O 1EqzhNKBj+Zlt+3LT9eTRwEQ1jIceRKpEmI73euKjfgObvbUCPg/VRkwlbi4YSKmJ1vU rkucbTtHcGxp1xlq+B3KqJTnXU2F/2mWuItnk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k5iA3VSOPpVCKM7yb/hTCjmh/EUNfiDd+JGte8YnMSU=; b=XKe77u9dv0IY6C/6AfuMEZ9mE/pMvzE7exrGB5h8RRuiOhibePmgvPVaiDm2hMTmYp 9dJNRRtMxpRKT2XaGte6R+DOnpGc7dvN5C1zlocARQazl3B49AXCtsISS09Z3GYX+k9z Ej/Ki1ZnUnnNEJs8p0uuB5skzVl0vajr6YnkF5NZvg1KYAziaTHM0LPbQoJYEznTq0Rr b+bd8kibkjGlZOrsJrZkWOIjyExmrmY0/k/hPdtcu5bRcDEpZjonSn+UEY0uMHUDXDgJ mWBAA7zZpmeCB6sYtu3lrSCUE9Rbn3jUqR4X7FjsFTWqU2DjySrYnxZPOWjkMvdskaBJ Ny5g== X-Gm-Message-State: AOAM531UsO2IXRX3l0PFAA3h0WfYfGb19xGSKEh/2vow5u2Zz2VK6Y/m JlQ8TnJJlqrzdwWOyiK63ZHsqkyi8gIiJJ1jTIu9iQfw3DZpB3hDwMMpzl2VzosR0yDAdMaGQYa CZH84ahyJ+qiXHaV40b/JjC8LaY8cOLL/QVRpM92Mh/TAXtIV35PgTY0CIVSxyNJvP7cD87PHv1 prLg== X-Google-Smtp-Source: ABdhPJzBUFKiHVwSfestRL9XSMPzPMu0Pmc0W1nUWCtfmZmW3coWBaL9hsXJRRwweIUbLKBOTeSXp3mxorZu X-Received: by 2002:aa7:9548:0:b029:13e:d13d:a08d with SMTP id w8-20020aa795480000b029013ed13da08dmr48078pfq.36.1599789403246; Thu, 10 Sep 2020 18:56:43 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id cl6sm80986pjb.15.2020.09.10.18.56.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2020 18:56:43 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde To: dev@dpdk.org Cc: Mike Baucom Date: Thu, 10 Sep 2020 18:55:44 -0700 Message-Id: <20200911015603.88359-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200911015603.88359-1-ajit.khaparde@broadcom.com> References: <20200911015603.88359-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 06/25] net/bnxt: free the em index on failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Mike Baucom When a Internal EM entry fails insertion, the allocated index needs to be pushed back to the allocation stack. Signed-off-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_em_internal.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/tf_core/tf_em_internal.c b/drivers/net/bnxt/tf_core/tf_em_internal.c index 462d0fa76..c95515b1b 100644 --- a/drivers/net/bnxt/tf_core/tf_em_internal.c +++ b/drivers/net/bnxt/tf_core/tf_em_internal.c @@ -175,8 +175,11 @@ tf_em_insert_int_entry(struct tf *tfp, &rptr_index, &rptr_entry, &num_of_entries); - if (rc) + if (rc) { + /* Free the allocated index before returning */ + stack_push(pool, index); return -1; + } PMD_DRV_LOG (DEBUG, -- 2.21.1 (Apple Git-122.3)