From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F330A04B5; Fri, 11 Sep 2020 10:37:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F72F1C0CD; Fri, 11 Sep 2020 10:36:46 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 5B69A1B9B7 for ; Fri, 11 Sep 2020 10:36:44 +0200 (CEST) IronPort-SDR: mKhL1If8ObVsqCX1IbwENJjJ2Nzs1oqO0H0zO3ociXjEDUD5KczIDeLJJc5XoQ1EEk/4QJZkgc W4uGJ1ImXmNg== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="146445783" X-IronPort-AV: E=Sophos;i="5.76,414,1592895600"; d="scan'208";a="146445783" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 01:36:43 -0700 IronPort-SDR: tewuhRCcuWv9/3aY1kg5a4XzvRcpRNIXaLcgTKM2jzB/Lq7DVdSVcUC3qg2N3CCGCvNejYysMC c8bTTULms+2Q== X-IronPort-AV: E=Sophos;i="5.76,414,1592895600"; d="scan'208";a="481249684" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.81.59]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 Sep 2020 01:36:41 -0700 Date: Fri, 11 Sep 2020 09:36:38 +0100 From: Bruce Richardson To: David Marchand Cc: SteveX Yang , dev , Wenzhuo Lu , Beilei Xing , Qiming Yang , Kevin Traynor , Luca Boccassi Message-ID: <20200911083638.GA732@bricha3-MOBL.ger.corp.intel.com> References: <20200910015525.59124-1-stevex.yang@intel.com> <20200911055811.16474-1-stevex.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 11, 2020 at 09:43:37AM +0200, David Marchand wrote: > On Fri, Sep 11, 2020 at 8:15 AM SteveX Yang wrote: > > > > The depended pmd bond is missing for test-pmd. Add the pmd_bond to deps, > > and replace the relative MACRO name with new RTE_LIBRTE_BOND_PMD. > > meson changed the name of the driver define (when compared to make). > We can't backport this patch. > > How/who will fix this in stable branches? > For backports, would it be good to add into config/rte_config.h a compatibility macro something like: #if defined RTE_LIBRTE_BOND_PMD && !defined RTE_LIBRTE_PMD_BOND #define RTE_LIBRTE_PMD_BOND 1 #endif