From: Bruce Richardson <bruce.richardson@intel.com>
To: "Yang, SteveX" <stevex.yang@intel.com>
Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
Kevin Traynor <ktraynor@redhat.com>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded
Date: Fri, 11 Sep 2020 10:40:54 +0100 [thread overview]
Message-ID: <20200911094054.GB732@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <DM6PR11MB436292727A47B651746AB246F9240@DM6PR11MB4362.namprd11.prod.outlook.com>
On Fri, Sep 11, 2020 at 10:16:08AM +0100, Yang, SteveX wrote:
> Hi Bruce,
>
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > Sent: Friday, September 11, 2020 4:37 PM
> > To: David Marchand <david.marchand@redhat.com>
> > Cc: Yang, SteveX <stevex.yang@intel.com>; dev <dev@dpdk.org>; Lu,
> > Wenzhuo <wenzhuo.lu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> > Yang, Qiming <qiming.yang@intel.com>; Kevin Traynor
> > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>
> > Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed
> > when enabled pmd_bonded
> >
> > On Fri, Sep 11, 2020 at 09:43:37AM +0200, David Marchand wrote:
> > > On Fri, Sep 11, 2020 at 8:15 AM SteveX Yang <stevex.yang@intel.com>
> > wrote:
> > > >
> > > > The depended pmd bond is missing for test-pmd. Add the pmd_bond to
> > > > deps, and replace the relative MACRO name with new
> > RTE_LIBRTE_BOND_PMD.
> > >
> > > meson changed the name of the driver define (when compared to make).
> > > We can't backport this patch.
> > >
> > > How/who will fix this in stable branches?
> > >
> > For backports, would it be good to add into config/rte_config.h a
> > compatibility macro something like:
> >
> > #if defined RTE_LIBRTE_BOND_PMD && !defined RTE_LIBRTE_PMD_BOND
> > #define RTE_LIBRTE_PMD_BOND 1 #endif
>
> Should I add above MACRO definition into config/rte_config.h with this fix patch?
> Or somebody else will fix it with another patch?
This would be a separate patch for backporting, rather than something that
is necessarily needed in your patch. However, if you want to add it for
backward compatibility of other external applications that may use the old
macro, feel free to do so.
If you can do it, probably the simplest solution is to do two separate
patches in a set - this patch for 20.11 only, and a second to add the
compatibility macro which can apply to 20.11 and be backported too.
/Bruce
next prev parent reply other threads:[~2020-09-11 9:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 1:55 [dpdk-dev] [PATCH v1] " SteveX Yang
2020-09-10 9:16 ` Bruce Richardson
2020-09-10 11:12 ` Bruce Richardson
2020-09-11 5:58 ` [dpdk-dev] [PATCH v2] " SteveX Yang
2020-09-11 7:23 ` Yang, Qiming
2020-09-11 7:43 ` David Marchand
2020-09-11 8:36 ` Bruce Richardson
[not found] ` <DM6PR11MB436292727A47B651746AB246F9240@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-09-11 9:40 ` Bruce Richardson [this message]
[not found] ` <DM6PR11MB4362CF8D42FE275B79B84978F9230@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-09-14 8:33 ` Bruce Richardson
2020-09-14 16:24 ` Bruce Richardson
2020-09-11 11:32 ` David Marchand
2020-09-11 14:45 ` Bruce Richardson
2020-09-14 8:46 ` David Marchand
2020-09-16 16:46 ` Richardson, Bruce
2020-09-15 2:24 ` [dpdk-dev] [PATCH v3] " SteveX Yang
2020-09-30 16:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911094054.GB732@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=beilei.xing@intel.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).