From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B632EA04C9; Mon, 14 Sep 2020 10:34:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FB971C0CF; Mon, 14 Sep 2020 10:34:50 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id F40732BAB for ; Mon, 14 Sep 2020 10:34:48 +0200 (CEST) IronPort-SDR: ohEEmGplNuTRK896Rctdrs1Dnt+G4juYFf/6Tb4N+fQpfSIzxILIdMnDEQk1D1bxMF1bB0ZoSS Ky1iFj4+BV4w== X-IronPort-AV: E=McAfee;i="6000,8403,9743"; a="156439602" X-IronPort-AV: E=Sophos;i="5.76,425,1592895600"; d="scan'208";a="156439602" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 01:34:48 -0700 IronPort-SDR: bZ0Dktef5hPnZ6pJ5wNspCUjCRMov6FgGTl9TiQPltupN4rJQFwdUiZdQXfuy099SJue9kBkyB RAzJeoKCXipQ== X-IronPort-AV: E=Sophos;i="5.76,425,1592895600"; d="scan'208";a="482252612" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.7.231]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 14 Sep 2020 01:34:46 -0700 Date: Mon, 14 Sep 2020 09:34:43 +0100 From: Bruce Richardson To: "Yang, SteveX" Cc: "dev@dpdk.org" , "Lu, Wenzhuo" , "Xing, Beilei" , "Yang, Qiming" Message-ID: <20200914083443.GC737@bricha3-MOBL.ger.corp.intel.com> References: <20200910022018.8955-1-stevex.yang@intel.com> <20200910092341.GD1789@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v1] app/test-pmd: fix meson build failed when used latency stats lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 14, 2020 at 09:00:19AM +0100, Yang, SteveX wrote: > Hi Bruce, > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Thursday, September 10, 2020 5:24 PM > > To: Yang, SteveX > > Cc: dev@dpdk.org; Lu, Wenzhuo ; Xing, Beilei > > ; Yang, Qiming > > Subject: Re: [dpdk-dev] [PATCH v1] app/test-pmd: fix meson build failed > > when used latency stats lib > > > > On Thu, Sep 10, 2020 at 02:20:18AM +0000, SteveX Yang wrote: > > > meson build cannot find the header rte_latencystats.h when build DPDK > > > first time or never installed DPDK lib after build via meson/ninja. > > > > > > Because the corresponding header directory isn't included after > > > enabled RTE_LIBRTE_LATENCY_STATS flag. > > > > > > Add the header file location and link library to meson.build of > > > test-pmd > > > > > > Signed-off-by: SteveX Yang > > > --- > > > > As before, I think we have a mismatch in old vs new macro names which is > > why this wasn't caught before. Therefore I suggest we just change testpmd > > to use the new macro to keep things standardized. [Other alternatives if we > > want to keep compatibility are to rename the latencystats directory to have > > an underscore in it, or to override the name (which I'd rather not go for)] > > Got it, I can change the old macro to new one RTE_LIBRTE_LATENCYSTATS. > > > > > > app/test-pmd/meson.build | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build index > > > db0ff02eb..6ee7af750 100644 > > > --- a/app/test-pmd/meson.build > > > +++ b/app/test-pmd/meson.build > > > @@ -9,6 +9,10 @@ if dpdk_conf.has('RTE_LIBRTE_BOND_PMD') > > > cflags += '-I' + meson.source_root() + '/drivers/net/bonding' > > > endif > > > > > > +if dpdk_conf.has('RTE_LIBRTE_LATENCYSTATS') > > > +cflags += '-I' + meson.source_root() + '/lib/librte_latencystats' > > > +endif > > > + > > > > Rather than working with long cflags, just add latencystats as a dependency > > of testpmd. > > If I add the latencystats as a dependency, that means the flag will be **always enabled** no matter if the RTE_LIBRTE_LATENCY_STATS flag is set from compiler cmdline. > Is it expected behavior for test-pmd app? > Not sure what you mean here, but so long as latency stats is available it should be a dependency of testpmd, so that the functionality is available. /Bruce