From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB9AFA04C7; Mon, 14 Sep 2020 18:39:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 887A72BAB; Mon, 14 Sep 2020 18:39:42 +0200 (CEST) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id CFFB2160 for ; Mon, 14 Sep 2020 18:39:40 +0200 (CEST) Received: by mail-pj1-f66.google.com with SMTP id q4so98778pjh.5 for ; Mon, 14 Sep 2020 09:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nLL6f6cPJiwiN3QvUR8kqrH3K9zftAQI8NIdrDCqrek=; b=SOaYrj/RU2rUehUU1i8V+N5BC+woOM1FgYiblPBvYA8r1aTaL7zAYs3Q2XAGQM/ptK ZpGiopW6FZlAf2CPztaSVefnLmeCPk6PamYWOdAkCW/ATSqD7eqR3u0aUMpgtM/DNg8h 3DBqpeK4mf+vyFVKYlhbkYR9yu+oIWNNmAthSrKByftLoVMLQ0/XYs6bweLRnx02bpFX 3Bc7EIkNX3+PAWvUTd5OLmpuLWcArmOROi3Vc/4U5ISspd17ltBnBbikleXK9TdJ9joS +eZCNKEqzuPFPNApyWdeWkBZPBSDqzTE4yvR5j2jPpyVDN4kJvll7ujz8MKPkpgIWBGK HrsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nLL6f6cPJiwiN3QvUR8kqrH3K9zftAQI8NIdrDCqrek=; b=TmmtQF+5U1aRNeXJu4UUtVkDu7xPjFtkoz9Ay9kyXfZf/ExV/Y66YmL5upvU+MR3SH NHxEFZ06jppj2koMw/3nVBrVgyoYgwynxGHx4qzLIeBjuXommtxiaQvzgtV4qvYYR/uV JU2UB5t/vybNbQ/MEXfyU7Xl1TEQ4F4np2jxm0W0+9V4w/EKBLygkEhDI3YSeoWzJczi A0k2BsSEZigqHNOlpMo3LOKN/xVenFaAzwJCYGM6PhlhLJfPFoYCu6f2hh8fqN7wmwsm KvsJEgXIDnst0aITmc0+vU24DFJgWCyiPmO7Nqxcjo9H9D6gXG+qOOpk+e5Osx51M6lG nPkQ== X-Gm-Message-State: AOAM533KWGxCkptacYq9a837OMFZcYiYzSOtCC3dvOnleaIzZzZ1slDK 0JBLVlAEMyHhncCaOxKAeHoiIVAAv3hJLQ== X-Google-Smtp-Source: ABdhPJy8SvnBFm65EPllqPvclm68ubi8Ayh/VJZEKnItKLQnb0n90SA1Z4LICjeQYUsgdBSMrAWsOg== X-Received: by 2002:a17:90a:ec05:: with SMTP id l5mr226013pjy.172.1600101580112; Mon, 14 Sep 2020 09:39:40 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m14sm10726115pfo.202.2020.09.14.09.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 09:39:39 -0700 (PDT) Date: Mon, 14 Sep 2020 09:39:36 -0700 From: Stephen Hemminger To: David Marchand Cc: dev , Harman Kalra Message-ID: <20200914093936.2a069054@hermes.lan> In-Reply-To: References: <20190724172037.7776-1-stephen@networkplumber.org> <20200903232822.19167-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal/interrupts: add function to allow interruptible epoll X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 14 Sep 2020 10:56:33 +0200 David Marchand wrote: > On Fri, Sep 4, 2020 at 1:28 AM Stephen Hemminger > wrote: > > > > The existing definition of rte_epoll_wait retries if interrupted > > by a signal. This behavior makes it hard to use rte_epoll_wait > > for applications that want to use signals do do things like > > exit polling loop and shutdown. > > > > Since changing existing semantic might break applications, add > > a new rte_epoll_wait_interruptible() function that does the > > same thing as rte_epoll_wait but will return -1 and errno of EINTR > > if it receives a signal. > > > > Signed-off-by: Stephen Hemminger > > Reviewed-by: Harman Kalra > > You will certainly argue that the existing function had no unit test > but we want to fix this at some point. > Can a unit test be added? The whole interrupt system really has no test, if it did then epoll would be part of that.