From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 663F2A04C7;
	Mon, 14 Sep 2020 23:04:16 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id E2BEE2BAB;
	Mon, 14 Sep 2020 23:04:14 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 78A89FFA
 for <dev@dpdk.org>; Mon, 14 Sep 2020 23:04:13 +0200 (CEST)
IronPort-SDR: HSIbINsuLHgGHViiz5U1zoYBDFVxxLjTqaAaQ5LIBERBUTCWURIPysYvVA3l9po/zohvfaooka
 tOfkgYNfXTlA==
X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="177225479"
X-IronPort-AV: E=Sophos;i="5.76,427,1592895600"; d="scan'208";a="177225479"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 14 Sep 2020 14:04:12 -0700
IronPort-SDR: UgVWa57CB2NUKCUT8zg0IgV814/6dG23TiNIO3am/mVKZPEDDVxgEnhJTjOChw94RLUuRyDvpF
 SLUzuUUdg5Ng==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.76,427,1592895600"; d="scan'208";a="335416228"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by orsmga008.jf.intel.com with ESMTP; 14 Sep 2020 14:04:10 -0700
Received: from sivswdev09.ir.intel.com (sivswdev09.ir.intel.com
 [10.237.217.48])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 08EL4AuA027471; Mon, 14 Sep 2020 22:04:10 +0100
Received: from sivswdev09.ir.intel.com (localhost [127.0.0.1])
 by sivswdev09.ir.intel.com with ESMTP id 08EL4A15029734;
 Mon, 14 Sep 2020 22:04:10 +0100
Received: (from lma25@localhost)
 by sivswdev09.ir.intel.com with LOCAL id 08EL4ABI029730;
 Mon, 14 Sep 2020 22:04:10 +0100
Date: Mon, 14 Sep 2020 22:04:10 +0100
From: "Liang, Ma" <liang.j.ma@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, david.hunt@intel.com, anatoly.burakov@intel.com
Message-ID: <20200914210410.GA27127@sivswdev09.ir.intel.com>
References: <1597141666-20621-1-git-send-email-liang.j.ma@intel.com>
 <1599214740-3927-1-git-send-email-liang.j.ma@intel.com>
 <1599214740-3927-2-git-send-email-liang.j.ma@intel.com>
 <20200904093711.6e5d44eb@hermes.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200904093711.6e5d44eb@hermes.lan>
Subject: Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add simple power management
	API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

agree, will be addressed 
On 04 Sep 09:37, Stephen Hemminger wrote:
> On Fri,  4 Sep 2020 11:18:56 +0100
> Liang Ma <liang.j.ma@intel.com> wrote:
> 
> 
> 
> > +#define ETH_EMPTYPOLL_MAX          512 /**< Empty poll number threshlold */
> 
> Spelling here.
> 
> Also, shouldn't this be a per-device (or per-queue) configuration value.