From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98F56A04C7; Wed, 16 Sep 2020 11:11:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78CFB1C1FC; Wed, 16 Sep 2020 11:11:42 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C5DD11C1FB for ; Wed, 16 Sep 2020 11:11:40 +0200 (CEST) IronPort-SDR: 6A+SZ3CiofwCNIATBNwtiONy2JPgF4VqJNqEvCfa/ZNmpIYSq8OnwJCq+T0NgjrgklbFdbWtCY KknhDGeYeZ3w== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="158710719" X-IronPort-AV: E=Sophos;i="5.76,432,1592895600"; d="scan'208";a="158710719" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 02:11:37 -0700 IronPort-SDR: iBx+BVguemh3kM/UG0DHzGFNQySXNudjQituldBeEf//iVG34zmkCOiY5A96ZeFERaZug6sQoR XRiAaqtf60lQ== X-IronPort-AV: E=Sophos;i="5.76,432,1592895600"; d="scan'208";a="483227734" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.245.198]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 16 Sep 2020 02:11:34 -0700 Date: Wed, 16 Sep 2020 10:11:28 +0100 From: Bruce Richardson To: Konstantin Ananyev Cc: dev@dpdk.org, jerinj@marvell.com, ruifeng.wang@arm.com, vladimir.medvedkin@intel.com Message-ID: <20200916091128.GA1849@bricha3-MOBL.ger.corp.intel.com> References: <20200807162829.11690-1-konstantin.ananyev@intel.com> <20200915165025.543-1-konstantin.ananyev@intel.com> <20200915165025.543-8-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915165025.543-8-konstantin.ananyev@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 07/12] acl: add infrastructure to support AVX512 classify X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 15, 2020 at 05:50:20PM +0100, Konstantin Ananyev wrote: > Add necessary changes to support new AVX512 specific ACL classify > algorithm: > - changes in meson.build to check that build tools > (compiler, assembler, etc.) do properly support AVX512. > - run-time checks to make sure target platform does support AVX512. > - dummy rte_acl_classify_avx512() for targets where AVX512 > implementation couldn't be properly supported. > > Signed-off-by: Konstantin Ananyev > --- This all looks correct, though I wonder do you really need to check all those AVX512 flags in each case? Since "F" is always present in any AVX512 implementation perhaps it can be checked, though if the other three always need to be checked I can understand if you want to keep it there for completeness. [Are all the other 3 used in your code?] Acked-by: Bruce Richardson