From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E47E0A04C0; Thu, 17 Sep 2020 19:05:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB0B91C1AD; Thu, 17 Sep 2020 19:05:54 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id D56481C10C for ; Thu, 17 Sep 2020 19:05:52 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id z19so1604374pfn.8 for ; Thu, 17 Sep 2020 10:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i7JrdQ8wdl6mv7aKPq5O5LNonNSsrHTP2A2Gr9Yjyd4=; b=r/ao1fkZLSnh2oWqh4cw9krTjl+6QZ1IXa1TBLhGtluO7KrsPLeTPXereO4Hwcnwoj bPW/XvUnnyaLcHaR4t9sH4g4rTc1WQAMOfxzBfza515B4G0coqFLitd0D+uwWdKjV4eI p0Yc30NG/5zPgKDPhVvOqu1mcSpg+G189h4YpVOOSf/hUdrqKqgUkthmUrox9dthXFWB srERPLx1lQc2HFDAOaYxRgM7gQZLrvUxrcAbRExBd8TSiSd6iMfOntJjwrL+lM+jZn9U F6vGsFS2/Oz8IU3B+rG539nUK/39Sugqwy6UG3btz+tVlCZ6vr7yFMClI11DSVR4zcoZ CTJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i7JrdQ8wdl6mv7aKPq5O5LNonNSsrHTP2A2Gr9Yjyd4=; b=cGFlEVrYRoqyhEM1ofl4ISZl7Hv2Es4yqd+VKm9a/Uldcct3VTt7QcsdS7J/kGFblP mTYJsZtrFOydk9YoOAuyxI1xZ7TiFcFCzEHhWijQ9CUoBO8tDoh8g/6v2x27V2ZI3hDa NXtblvJZLo/zsPxHoEqYhuKuGXvo85set2JIFiS9vQ7zgcQjsczqnAXwSSCFOtePfhdL 98L5C83TSasCk1gj4V/atGp3R3d987RX2IbXDbu0Mq2hm4jC9BhDhdXQ+rSJiYjlWvpr NWVyZ3EjN9/nhPCGzG3iJRW3Mdo6rDm7adxKa64PjKWAXUhyiOZ6bh9pt1pqNSulWNhU v+yQ== X-Gm-Message-State: AOAM533i0ZLFWDG7jjoey1TX1LG32KnGXuCITy4FrSDNMhZDZAZe3Dvt tKsm4HHckmmCx96iCZY1CeNAvREpAXFbtA== X-Google-Smtp-Source: ABdhPJyg/kskv+js343cTLSB5qgQSPkNXl+CkHMq2G+TmRieAfO3Ps0zCINaUcR2AlHx13g87ZUwRA== X-Received: by 2002:a63:1d5c:: with SMTP id d28mr22220679pgm.82.1600362352079; Thu, 17 Sep 2020 10:05:52 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p11sm160358pfq.130.2020.09.17.10.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 10:05:51 -0700 (PDT) Date: Thu, 17 Sep 2020 10:05:48 -0700 From: Stephen Hemminger To: Olivier Matz Cc: Dmitry Kozlyuk , dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , "Kadam, Pallavi" , Ray Kinsella , Neil Horman Message-ID: <20200917100548.37f7cfb0@hermes.lan> In-Reply-To: <20200917133443.GR21395@platinum> References: <20200620210511.13134-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-2-dmitry.kozliuk@gmail.com> <20200917133443.GR21395@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 17 Sep 2020 15:34:43 +0200 Olivier Matz wrote: > Hi Dmitry, > > On Fri, Jul 31, 2020 at 12:06:45AM +0300, Dmitry Kozlyuk wrote: > > struct cmdline exposes platform-specific members it contains, most > > notably struct termios that is only available on Unix. Make the > > structure opaque. > > > > Remove tests checking struct cmdline content as meaningless. > > > > Add cmdline_get_rdline() to access history buffer. > > The new function is currently used only in tests. > > > > Signed-off-by: Dmitry Kozlyuk > > First, please forgive me for the very late feedback. It is all the more > problematic because I think this patch introduces an ABI breakage, that > should have been announced. Since 20.11 is a API/ABI breaking release, I think breaking ABI is okay without announcement. What matters more is if that API would need to be impacted. API changes need some announcement.