From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86667A04BB; Thu, 17 Sep 2020 16:15:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5136E1D663; Thu, 17 Sep 2020 16:15:43 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id C50851BEA1 for ; Thu, 17 Sep 2020 16:15:41 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id g4so2262747wrs.5 for ; Thu, 17 Sep 2020 07:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xs6wOw4Uw8RG9DiPje9NmHduTho+riMEayonWQokOHI=; b=Tmn4EeK9KlvDoh+ie/EdIdkm9n1kGx3H1SAnc/QnOoTUjCUQ+SyxL+uZfRedG88GoI +RixbdaqH8Q3uZR5LJ/gonCNssGHx5fHp0AdPMAbjUEz6I5A4UdVFa15oJFUVKnRpu2/ NXnkQOOMw5no1w5XzAtyccBsH/S452S6gTzJ8TAHghuMSTvCKLk5Yn72lRvKm0jBbZGa xmfhkn/yvKYCtJr/XQAyhduOp5NW+uJ0gMgcgAdqiXF22zCy5Zwb9QMXFYAwI0/cWVUw LGZ85IoJm5HHjZJK0+ve7hKECbbI0PmsS/DkrnckFDW35RBQ9NC49PB20w3WfB8wBTuC YkRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xs6wOw4Uw8RG9DiPje9NmHduTho+riMEayonWQokOHI=; b=bwXe38xXVUHSAsxn+A5vAFkn5k8z5sumc1o4vPxC3QivaHMVs6BqFdW3frM+TVOkk+ LRErFuYbC6+58dofoF6Q2MovbxxJgNP3lHOd/0vOpWDOJsFe3QhGucs30iBBxauHf1tY js8z7u7hvl9buZWJjELb/QePif7p58gaY2lD2ilM17tfiYOTkZHF3l7YTSoP8Y5Jv6/9 cRnqpxcVttfuYDPT4WO5yzwdIBQRbufE8CX13O5c6DPqgp0y2ae8W3eHvImhzlaK/nNG sq0lCPZcoSDpiLMKFJcLJHliHJBIoUC36TGEi8OnGnHduj17bPqEt1GdgB0ubipMnLHl aQcg== X-Gm-Message-State: AOAM5302l1QKHJnoKSVL36au+zmqUOcnNQgQxTe1DvS0Arqd2NK6SFWh 4dWSD43M7hEwggVGjp0FwhqS9w== X-Google-Smtp-Source: ABdhPJzDyPG5ynu97HI/whX8/zkoig9ftyE76qDc8czTqz3tbmI7AQwXHI3pI1ipjJBQjPC55iQ03A== X-Received: by 2002:a05:6000:1c8:: with SMTP id t8mr32249094wrx.3.1600352141495; Thu, 17 Sep 2020 07:15:41 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id t6sm43565494wre.30.2020.09.17.07.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 07:15:40 -0700 (PDT) Date: Thu, 17 Sep 2020 16:15:39 +0200 From: Olivier Matz To: Bruce Richardson Cc: Dmitry Kozlyuk , dev@dpdk.org, Jie Zhou , Ranjit Menon , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Ori Kam , Marko Kovacevic , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Pavan Nikhilesh , Cristian Dumitrescu , Jasvinder Singh , Maxime Coquelin , Chenbo Xia , Zhihong Wang , David Hunt Message-ID: <20200917141539.GT21395@platinum> References: <20200821184855.2220-1-dmitry.kozliuk@gmail.com> <20200902183805.5421-1-dmitry.kozliuk@gmail.com> <20200903092052.GA1615@bricha3-MOBL.ger.corp.intel.com> <20200903123056.0aad9d5b@sovereign> <20200903094031.GB1615@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903094031.GB1615@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows system types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Thu, Sep 03, 2020 at 10:40:31AM +0100, Bruce Richardson wrote: > On Thu, Sep 03, 2020 at 12:30:56PM +0300, Dmitry Kozlyuk wrote: > > On Thu, 3 Sep 2020 10:20:52 +0100, Bruce Richardson wrote: > > > On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote: > > > > cmdline_numtype member names clash with Windows system identifiers. > > > > Add CMDLINE_ prefix to cmdline constants to avoid this and possible > > > > future conflicts. > > > > > > > > Signed-off-by: Dmitry Kozlyuk > > > > Suggested-by: Ranjit Menon > > > > --- > > > > > > Is CMDLINE the best prefix to use here. The DPDK standard is obviously RTE_ > > > as a prefix. This is one I suggested previously (over a year ago, actually): > > > > > > http://patches.dpdk.org/patch/52644/ > > > > RTE_ is the standard indeed. I went with CMDLINE_, because this is the prefix > > librte_cmdline uses for its main routines. Will change in v3 if no objections > > arise. > > Yes, I suggest waiting for other inputs. +1 for RTE_ prefix