From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35589A04C0; Thu, 17 Sep 2020 17:29:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05CB51D68F; Thu, 17 Sep 2020 17:29:32 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 24EC81BEA1; Thu, 17 Sep 2020 17:29:28 +0200 (CEST) IronPort-SDR: Tyw1H7hc88pgIRSvh3khRR0DTC7Fh1J1N0xdbzxP68q4hXPh6kKQ8+eYs7q/2OQYNm9OJn8pk8 vJO1VuMijlmg== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="244557635" X-IronPort-AV: E=Sophos;i="5.77,271,1596524400"; d="scan'208";a="244557635" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 08:29:26 -0700 IronPort-SDR: rIo9p2l78ny1vQG+7Eb/0iVn/y2ns153xsTDXSriMwcXOk1b8miQKwA9DJnznzYOBzQEdSbgmM NRwh2kzGVhpg== X-IronPort-AV: E=Sophos;i="5.77,271,1596524400"; d="scan'208";a="452356046" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.24.6]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 17 Sep 2020 08:29:24 -0700 Date: Thu, 17 Sep 2020 16:29:20 +0100 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Fan Zhang , Luca Boccassi Message-ID: <20200917152920.GH1568@bricha3-MOBL.ger.corp.intel.com> References: <20200917150917.22945-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917150917.22945-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote: > The headers variable is only used in lib/meson.build context. > For drivers, an explicit install_headers() is necessary. > > Reproduced while compiling the l2fwd-crypto example out of meson > (which can be done by adding it in devtools/test-meson-builds.sh > examples build test). > > Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/crypto/scheduler/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Originally I only put the "headers" variable in the "lib" folder meson.build because it was not expected that many drivers should have private headers. However, perhaps it's worthwhile adding it now: a) because private headers, while not common, are not unusual b) for consistency and ease of use. Thoughts? /Bruce