From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53220A04C3; Fri, 18 Sep 2020 01:13:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D2511D6E6; Fri, 18 Sep 2020 01:13:40 +0200 (CEST) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id 1D0511C1D5 for ; Fri, 18 Sep 2020 01:13:39 +0200 (CEST) Received: by mail-lf1-f66.google.com with SMTP id q8so4027330lfb.6 for ; Thu, 17 Sep 2020 16:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w8s5CK2nTf6XR/YLH6PJ1JMU8I776bREylDU2JDOsmU=; b=NArLgMv7EgthAfL9J1Anxl2nksC1oPtGX0GMa6UEC1RZtowiUHF8Ew74odxYk4FxyN CyXv6nLZr7i6pwqMxymctNsp8W0a0zceRrm866yrzH9/3iE4XhdP3yOVBkIrKJ+RFtLZ OaZYfH+SvD7BkyFxq6KXYskFSCJVzObCv6wQHD4oocsLFTtF0BALObBJcd90jUKhCBxL oO+6H2siEUFZkl1QWCFbeNYFxtmZmXsG/fROVKmmH/hCv0CHc459FI0LpLnAGc2932ww JHiaHLZxCz21J30XeHsG1leh2FjTcAU04i6zT/9yWUL6Z6MPchkVJSZJmtfjRDeBReW/ Y/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w8s5CK2nTf6XR/YLH6PJ1JMU8I776bREylDU2JDOsmU=; b=SMClx8sgkvsoSK75u5GeAUaeIkNSiYiVaQXRMZRoL2ZMQUuXO92X+U0i1BanmedpV/ AzPgqCvoVGuizQ0ldi9bjrLESMDsTz2pBn2toL+lcbNN2DRQ5CWm2Iqze3hJtp23w2G1 OnIYTaQLz6qLsfxQtvxRz+emT1k2O7ex8/4Wrr6EJSeuC+btp7+UfFz3yejTUDSO/HuI gNc1okqDZZdTWjagUBpzxHXLDLJig52RKRd7+jXDmlc/A8YljO43mu61z7OHI+7htypA JKQF9PJQURfWUB6c2wO3/UuYh2jI5xIwU411Xp8FNqTvFT6Yk7XEImx/L41Pv5a7AwyR lpTg== X-Gm-Message-State: AOAM530e4URU8389oyOs8WBBF4tqLgtKCfijwftBDZGkzkvc8LeRGwZ9 izz5PEJWIeBhv/GHpslaPRE= X-Google-Smtp-Source: ABdhPJwBp1HaKt2Y3qC9Rs/gVeKS4s7EpCocjcLxtpI23xClwQ1U96Cb4WLdbol7lF8jDn0HgK8+QA== X-Received: by 2002:ac2:4c19:: with SMTP id t25mr10711991lfq.503.1600384418593; Thu, 17 Sep 2020 16:13:38 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id b7sm200354lfi.123.2020.09.17.16.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 16:13:37 -0700 (PDT) Date: Fri, 18 Sep 2020 02:13:36 +0300 From: Dmitry Kozlyuk To: Olivier Matz Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , "Kadam, Pallavi" , Ray Kinsella , Neil Horman Message-ID: <20200918021336.58c264c2@sovereign> In-Reply-To: <20200917133443.GR21395@platinum> References: <20200620210511.13134-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-2-dmitry.kozliuk@gmail.com> <20200917133443.GR21395@platinum> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Olivier, thanks for the review. > In my opinion, we could accept the patch for 20.11, knowing it reduce > the risk of future ABI breakage, and that cmdline is not a core > component of DPDK. However it has to be discussed and accepted by other > people. > > Else, the patch would be delayed for 21.11. From what I see from the > other patches, it looks possible to keep cmdline struct public without > breaking the existing ABI by adding #ifdef CONFIG_RTE_EXEC_ENV_WINDOWS, > is it correct? Windows team is now working on getting testpmd, tests, and examples functional. librte_cmdline is essential for that, so delaying to 21.11 is the worst option. If unannounced ABI breakage is deemed intolerable, I'd certainly go with #ifdef.