From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 139B4A04DE; Tue, 22 Sep 2020 03:43:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 564061DA66; Tue, 22 Sep 2020 03:42:59 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 50A5D1D95A for ; Tue, 22 Sep 2020 03:42:55 +0200 (CEST) IronPort-SDR: dZLgem72O5s+AESUV6rTH7ac2/9BsKJh2WHibUrna6ceos8b5TCGEISybOkExeCIJ0RkxCfAck UsbTzROD24lQ== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="148265189" X-IronPort-AV: E=Sophos;i="5.77,288,1596524400"; d="scan'208";a="148265189" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 18:42:54 -0700 IronPort-SDR: 7R0UJ6vzp4r8momQvl1klHfIwrOPG2K2hR1OqBIjRXNCl3oIjULzlZ3DkmuIGtZDhcQRrAdoZ5 eSUbhYUtEmcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,288,1596524400"; d="scan'208";a="322045718" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by orsmga002.jf.intel.com with ESMTP; 21 Sep 2020 18:42:52 -0700 From: SteveX Yang To: dev@dpdk.org Cc: wei.zhao1@intel.com, jia.guo@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, konstantin.ananyev@intel.com, SteveX Yang Date: Tue, 22 Sep 2020 01:23:35 +0000 Message-Id: <20200922012338.11277-3-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200922012338.11277-1-stevex.yang@intel.com> References: <20200916055212.25019-1-stevex.yang@intel.com> <20200922012338.11277-1-stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v2 2/5] net/igc: fix max mtu size packets with vlan tag cannot be received by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. igc can support single vlan tag that need more 4 bytes for max packet size, so, configures the correct max packet size in dev_config ops. Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx") Signed-off-by: SteveX Yang --- drivers/net/igc/igc_ethdev.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c index 810568bc5..36ef325a4 100644 --- a/drivers/net/igc/igc_ethdev.c +++ b/drivers/net/igc/igc_ethdev.c @@ -341,7 +341,12 @@ eth_igc_configure(struct rte_eth_dev *dev) PMD_INIT_FUNC_TRACE(); - ret = igc_check_mq_mode(dev); + /* Considering vlan tag packet, max frame size should be MTU and + * corresponding ether overhead. + */ + eth_igc_mtu_set(dev, dev->data->mtu); + + ret = igc_check_mq_mode(dev); if (ret != 0) return ret; -- 2.17.1