From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 619C1A04B5; Tue, 22 Sep 2020 12:32:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 481851DBB0; Tue, 22 Sep 2020 12:32:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 7418C1DB90; Tue, 22 Sep 2020 12:32:17 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08MAQMD9025396; Tue, 22 Sep 2020 03:32:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0220; bh=3ROyfUoahb0o1rqptEt6DSOusnnETqp7t5pCkYk1wjo=; b=EvQhXIclwWakOYsPUbV6xEYhD87/0cZDp1Zj+zqHd6uL0WStxjiGNLY02A4qXYEt0u9d 1IbNG08qhr/icx12oL/734LlgG3UG2SxmYnfydVrkmwZa0VcvUnyywoCBztXyRjF0JcY yPNrzbF6eT9CDHocdNnKW3SmAreeaFew1dQAtZgKZuIblQgT8MXEwevnLA7ny2++dXXi ZRHwOjGh2m0eF26Vg/L6IMI8ISaNPmzlLHbzO7eTDb2BVEuLXQBu2LknLqHZxepbKE1x /IuqyLdDZJz26aPsGaTEIeun//E8Ro6eBFvq3UIpZT6CtSr826f6pQehbfUOOVspxt0M TA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 33nhgn9prr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 22 Sep 2020 03:32:15 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 03:32:14 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 03:32:13 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 22 Sep 2020 03:32:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SMakcBgH91uHQRt28215hQmaGDibHlup6XdFk24qGvnHHYBY53+Fm3nT1FG82b4EMa3+LdQ9cPCjAsXDv9quQzIaVhJsrmGJ0GWD8tSQkOxTnV34IjExMAlZu1ghV5qxG+A9KTSLfdxY9kXzp1hL0r9VGHvOzyDjta9wwYMN6x+u6JH2cCD68xPPdrU7ESKvdwebN41OUx/a82RxOqZMqxYSxJDSvgUAn/0B49s0ZqHpG6EpEgWmluO186JiI6ioWQexfLm8xnyOiD3/ktO5z1jYr9/l4SX/1g8ZwUlntO6d1SkWMf4hkk6SwoVwq99Cqm7PB5zpYVVTKCsIEFQenQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ROyfUoahb0o1rqptEt6DSOusnnETqp7t5pCkYk1wjo=; b=hVHpbxQj4jYBTSnpJz9q05Sytw7RXH5jiIvYLyXaxGdCb/+zrThZI+yDFn8lrZrbzE4x8Bga/YD5CV3iHqMeoZuyy2eXBa+ixn2ZFMy8rouhzdmXhoDHFUix7IWOS2kM6R8V8RrXXoTwIztNzILuoUdV1YlW/PALFXdOv5FFFRBgMYXcOC6FMZ6xSn3o6oGx6r7pgiB6OmbYXOEHbscAsj16TJGZR7rcyT4Mo9I+1Qmy75Itp14Rhg00G5HACxzAzaTE55zidTPTFndz/83vJX2rcv1A+9uQYXW/gVreJVhlAVReVquK5XfDdTSddDT1nAMWMP+EfUpJADT5bYCELw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ROyfUoahb0o1rqptEt6DSOusnnETqp7t5pCkYk1wjo=; b=Uo21dffu9yLWQenYn937cqxQR7GpAPvi8sfmBs1IhClmr/SviKw+slNfBiKp9aWedSgm+1YQU4uW+uJiGkyrhV4HQP5fhFY1Zil5KIGuqiSfNy5X0xQ1cXr/8Bk+8/Zm/12dKRe3ZWDEB8hFD18eL7SPgX9Fl9xeT+vv9mlW78s= Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=marvell.com; Received: from MWHPR18MB1070.namprd18.prod.outlook.com (2603:10b6:300:a5::11) by MWHPR18MB0944.namprd18.prod.outlook.com (2603:10b6:300:9b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14; Tue, 22 Sep 2020 10:32:10 +0000 Received: from MWHPR18MB1070.namprd18.prod.outlook.com ([fe80::6133:3e28:6693:beb2]) by MWHPR18MB1070.namprd18.prod.outlook.com ([fe80::6133:3e28:6693:beb2%8]) with mapi id 15.20.3391.026; Tue, 22 Sep 2020 10:32:10 +0000 Date: Tue, 22 Sep 2020 16:01:43 +0530 From: Harman Kalra To: wangyunjian CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , Thomas Monjalon , "Lilijun (Jerry)" , xudingke , "stable@dpdk.org" Message-ID: <20200922103141.GA54896@outlook.office365.com> References: <2dc88362a7dc347547eb24e5d0570db11a59598e.1594780487.git.wangyunjian@huawei.com> <34EFBCA9F01B0748BEB6B629CE643AE60DA5CEA2@dggemm513-mbx.china.huawei.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60DA5CEA2@dggemm513-mbx.china.huawei.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-ClientProxiedBy: SG2PR04CA0144.apcprd04.prod.outlook.com (2603:1096:3:16::28) To MWHPR18MB1070.namprd18.prod.outlook.com (2603:10b6:300:a5::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (1.6.215.26) by SG2PR04CA0144.apcprd04.prod.outlook.com (2603:1096:3:16::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Tue, 22 Sep 2020 10:32:07 +0000 X-Originating-IP: [1.6.215.26] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f07358df-96ae-4dc3-8a02-08d85ee2c30b X-MS-TrafficTypeDiagnostic: MWHPR18MB0944: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OzQI4iJHzcvk7FvS4KwU09+nXTxdWu5xe+ub8aoG3XO6eie52Y/bTM41s2VJLRm+aE1IZ9KVw7wEaNs8hFpyrqfrFFY7BGuvRGgBuMa+PUD0o/113g4ptzbHc1L+zHE720yZSpm/UN04/NCLe/EUQizay9vTbtxm8XNjjCbjMYBcOKEtRsvAOPGutn0pfsNRZbAB/Mn6aA0KS9C6si+JvGB/xJs8iBULE2Ed4eGAyQ9XhHGs0Ov7iIt5oQ0HL/zbL7u5aJJ/v8Bh8MdkoUuSlLVJFl5fKDmxbUWrFJPyZWORyLo+Bc4XTC+L4Icrp+3E1jyTLtmPbvWSCeAkSNTmI9bso2TZylnU0UUtXxYOslMTNPu8lXMJ1D8jMq8XHwSxDwMFcmSrJZ+iRiD43Rrt6w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR18MB1070.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(86362001)(478600001)(9686003)(8676002)(8936002)(6666004)(7696005)(52116002)(1006002)(2906002)(956004)(26005)(316002)(186003)(16526019)(6916009)(55016002)(6506007)(53546011)(66946007)(66556008)(66476007)(33656002)(4326008)(83380400001)(54906003)(1076003)(5660300002)(36456003)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: LeArUKbFTNyIGteADLwk3FE9lquQd3s70ImUfoVR1+S6kFI5C4NtiPUH0kGD/rWS5aS1c8XLK9neEY4oAPKY4hqEWc/q60LEmYznUHPQzDVDi9DrxSXnL3gFw9Naz8gBfRr3STfZ/roNMHU23vCTSaQx3JIJGn4IkWVuKZqPqaKLS72tSeibavW/vSPySB5iA+JK394Ekl6VVLjM2mFPSIqYinv6xc6JGPqoWHlylH5NRcm4+t8Xa2qvPsQoKKMVL6asOoAMXXQ18FgN5S7umunt7MIOGNxlDKXszTUK4nAyQIYdHoL8qMoXBKP4UvOCj0ojmHh0NE/+VUJAqZLsT2VOqiOu8n3oiyQbvxtBIEp87MxXlkR8WiGUpvIM/3y8PJQ8B9Mqfno5zcOMZFEzpSaWD7vpK+tZQERgdVsGK3s5pa1zNXG+kuCSSLU8L7zJnBLRsZ0i/2hiwO0+Xtx1rfz9Em80XGantsfqXFAABEMhZPACpLtmfPRtaZcwMj9d9Ay8b1dtmGN7pJvzFqyq5t2V8wIijzCtKYb5bTqEiJdTU675wvRrlU7Qn5/jp4mtA0AJVsnCPOP1c19C02DPC2Uaezv/3cu69e8hc7qOuCESkKpzxZ0OTizeYE2TkPI93Y0q5v+lJazgLnpSrOrP6Q== X-MS-Exchange-CrossTenant-Network-Message-Id: f07358df-96ae-4dc3-8a02-08d85ee2c30b X-MS-Exchange-CrossTenant-AuthSource: MWHPR18MB1070.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 10:32:10.3827 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lEWZexl+gdmqnm7A+oy4fScEf9tK46BBz8Idobyc7EOG0YwzWitRFVAB9P1D8aXsIxbv+APJkDyiehjjeZh3iQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB0944 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-22_06:2020-09-21, 2020-09-22 signatures=0 Subject: Re: [dpdk-dev] [EXT] RE: [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Sep 19, 2020 at 10:42:30AM +0000, wangyunjian wrote: > External Email > > ---------------------------------------------------------------------- > Friendly ping. Hi Wang, I am sorry for the delay in review, I will surely complete the review by end of this week. Can you please elaborate on the specific case/scenario which caused failure i.e. which lead you to this change. Thanks Harman > > > -----Original Message----- > > From: wangyunjian > > Sent: Wednesday, August 26, 2020 6:56 PM > > To: dev@dpdk.org; hkalra@marvell.com; david.marchand@redhat.com > > Cc: 'ferruh.yigit@intel.com' ; 'Thomas Monjalon' > > ; Lilijun (Jerry) ; xudingke > > ; stable@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > > rte_epoll_event > > > > Ping for review, please. > > > > > -----Original Message----- > > > From: wangyunjian > > > Sent: Wednesday, July 15, 2020 10:40 AM > > > To: dev@dpdk.org; hkalra@marvell.com > > > Cc: Lilijun (Jerry) ; xudingke > > > ; wangyunjian ; > > > stable@dpdk.org > > > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > > > rte_epoll_event > > > > > > From: Yunjian Wang > > > > > > The "rev->epdata.event" assigned to "events.epdata.event" directly, > > > which was wrong in case of epoll events. It should be set to the "evs.events". > > > > > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Yunjian Wang > > > --- > > > lib/librte_eal/linux/eal_interrupts.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > > b/lib/librte_eal/linux/eal_interrupts.c > > > index 13db5c4e8..8a3c95cec 100644 > > > --- a/lib/librte_eal/linux/eal_interrupts.c > > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event *evs, > > > unsigned int n, > > > events[count].status = RTE_EPOLL_VALID; > > > events[count].fd = rev->fd; > > > events[count].epfd = rev->epfd; > > > - events[count].epdata.event = rev->epdata.event; > > > + events[count].epdata.event = evs[i].events; > > > events[count].epdata.data = rev->epdata.data; > > > if (rev->epdata.cb_fun) > > > rev->epdata.cb_fun(rev->fd, > > > -- > > > 2.23.0 > > > >