DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jan Viktorin <viktorin@cesnet.cz>
To: "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>
Cc: Asaf Penso <asafp@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>,
	Ori Kam <orika@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] Duplicating traffic with RTE Flow
Date: Wed, 23 Sep 2020 10:29:43 +0200	[thread overview]
Message-ID: <20200923102943.7ffdf6f4@coaster.localdomain> (raw)
In-Reply-To: <BL0PR12MB241915CB67FAF721100B6A6BC6380@BL0PR12MB2419.namprd12.prod.outlook.com>

On Wed, 23 Sep 2020 02:28:03 +0000
"Jiawei(Jonny) Wang" <jiaweiw@nvidia.com> wrote:

> Hi Jan,
> 
> Sorry for late response, Could you check the below latest patches
> that support flow-based traffic sampling? (based on: net/enic:
> support VXLAN decap action combined with VLAN pop)
> https://patchwork.dpdk.org/project/dpdk/list/?series=12410
> 
> " The solution introduces a new action that will sample the incoming
> traffic and send a duplicated traffic with the specified ratio to the
> application, while the original packet will continue to the target
> destination."
> And,
>  set sample_actions 1 port_id id 1 / end
>    flow create 0 ... pattern eth / end actions
> 	sample ratio 1 index 1 / port_id id 2...
> The flow will result in all the matched ingress packets will be sent
> to port 2, and also mirrored the packets and sent to port 1.

Hi,

excuse me, but what am I doing wrong?

$ git log -1 --oneline
a4ab862 net/enic: support VXLAN decap action combined with VLAN pop

$ curl https://patchwork.dpdk.org/series/12410/mbox/ > sample-action-rte-flow.patch

$ git apply sample-action-rte-flow.patch
error: patch failed: doc/guides/rel_notes/release_20_11.rst:62
error: doc/guides/rel_notes/release_20_11.rst: patch does not apply

Or...

$ git am -3 sample-action-rte-flow.patch
Applying: ethdev: introduce sample action for rte flow
fatal: sha1 information is lacking or useless (doc/guides/prog_guide/rte_flow.rst).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 ethdev: introduce sample action for rte flow

Jan

> 
> Thanks.
> B.R.
> 
> Jonny
> 
> > -----Original Message-----
> > From: Jan Viktorin <viktorin@cesnet.cz>
> > Sent: Tuesday, September 22, 2020 4:04 AM
> > To: Asaf Penso <asafp@nvidia.com>
> > Cc: dev@dpdk.org; Ori Kam <orika@nvidia.com>; Jiawei(Jonny) Wang
> > <jiaweiw@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> > Subject: Re: [dpdk-dev] Duplicating traffic with RTE Flow
> > 
> > On Fri, 18 Sep 2020 14:23:42 +0000
> > Asaf Penso <asafp@nvidia.com> wrote:
> >   
> > > Hello Jan,
> > >
> > > You can have a look in series [1] where we propose to add APIs to
> > >  
> > DPDK20.11 for both mirroring and sampling for packets, with
> > additional actions of the different traffic.  
> > >
> > > [1]
> > >  
> > https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> >  
> > >  
> > es.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D12045&amp;data=
> > 02%7C  
> > >  
> > 01%7Cjiaweiw%40nvidia.com%7C8c9585855f9640f37ae608d85e698dbb%7C43
> > 083d1  
> > >  
> > 5727340c1b7db39efd9ccc17a%7C0%7C1%7C637363154745490399&amp;sdata
> > =mdG51  
> > >  
> > UgntQvMjs%2BPpRozwt2dtAcdWR8j9MXBtZ3%2Bl8k%3D&amp;reserved=0
> > 
> > Thanks! Can you please recommend me a base where I can apply this
> > series? For current main (dc18be1d8) I got:
> > 
> > error: patch failed: drivers/net/mlx5/mlx5_flow_dv.c:9537
> > error: drivers/net/mlx5/mlx5_flow_dv.c: patch does not apply
> > error: patch failed: drivers/net/mlx5/mlx5_flow_dv.c:80
> > error: drivers/net/mlx5/mlx5_flow_dv.c: patch does not apply
> > error: patch failed: drivers/net/mlx5/mlx5_flow_dv.c:9007
> > error: drivers/net/mlx5/mlx5_flow_dv.c: patch does not apply
> > 
> > Jan
> >   
> > >
> > > Regards,
> > > Asaf Penso
> > >  
> > > >-----Original Message-----
> > > >From: dev <dev-bounces@dpdk.org> On Behalf Of Jan Viktorin
> > > >Sent: Friday, September 18, 2020 3:56 PM
> > > >To: dev@dpdk.org
> > > >Subject: [dpdk-dev] Duplicating traffic with RTE Flow
> > > >
> > > >Hello all,
> > > >
> > > >we are looking for a way to duplicate ingress traffic in
> > > >hardware.
> > > >
> > > >There is an example in [1] suggesting to insert two fate actions
> > > >into the RTE Flow actions array like:
> > > >
> > > >  flow create 0 ingress pattern end \
> > > >      actions queue index 0 / void / queue index 1 / end
> > > >
> > > >But our experience is that PMDs reject two fate actions (tried
> > > >with mlx5). Another similar approach would be to deliver every
> > > >single packet into two virtual
> > > >functions:
> > > >
> > > >  flow create 0 ingress pattern end \
> > > >     actions vf index 0 / vf index 1 / end
> > > >
> > > >Third possibility was to use passthru:
> > > >
> > > >  flow create 0 ingress pattern end \
> > > >      actions passthru / vf index 0 / end  flow create 0 ingress
> > > > pattern end \
> > > >      actions vf index 1 / end
> > > >
> > > >Again, tried on mlx5 and it does not support the passthru.
> > > >
> > > >Last idea was to use isolate with passthru (to deliver both to
> > > >DPDK application and to the kernel) but again there was no
> > > >support on mlx5 for  
> > passthru...  
> > > >
> > > >  flow isolate 0 true
> > > >  flow create 0 ingress pattern end actions passthru / rss end /
> > > > end
> > > >
> > > >Is there any other possibility or PMD+NIC that is known to solve
> > > >such  
> > issue?  
> > > >
> > > >Thanks
> > > >Jan Viktorin
> > > >
> > > >[1]
> > > >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fd
> > > > 
> > oc  
> > > >.dpdk
> > > >.org%2Fguides%2Fprog_guide%2Frte_flow.html%23table-rte-flow-  
> > redirect-  
> > > >queue-5-
> > > >3&amp;data=02%7C01%7Casafp%40nvidia.com%7C1a46005bec5245e729e  
> > 708d  
> > > >85bd24caf%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637360  
> > 3060  
> > > >73519816&amp;sdata=EOF%2Fz62crvBZK8rwzwKIWxj5cVlfPVnU3FLmcL9X  
> > 2w0%3  
> > > >D&amp;reserved=0  
> 


  reply	other threads:[~2020-09-23  8:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 12:56 Jan Viktorin
2020-09-18 14:23 ` Asaf Penso
2020-09-21 20:03   ` Jan Viktorin
2020-09-23  2:28     ` Jiawei(Jonny) Wang
2020-09-23  8:29       ` Jan Viktorin [this message]
2020-09-27  6:33         ` Jiawei(Jonny) Wang
2021-03-01 12:21   ` Jan Viktorin
2021-03-01 14:34     ` Slava Ovsiienko
2021-03-01 14:43       ` Jan Viktorin
2021-03-11  2:11         ` Jiawei(Jonny) Wang
2021-03-11 16:32           ` Jan Viktorin
2021-03-12  9:32             ` Jiawei(Jonny) Wang
2021-03-15 13:22               ` Jan Viktorin
2021-03-15 17:57                 ` Jan Viktorin
2021-03-16  4:00                 ` Jiawei(Jonny) Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200923102943.7ffdf6f4@coaster.localdomain \
    --to=viktorin@cesnet.cz \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=jiaweiw@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).