From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE458A04B1; Wed, 23 Sep 2020 20:24:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B94D1DB0B; Wed, 23 Sep 2020 20:24:49 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id C3E5A1D65C for ; Wed, 23 Sep 2020 20:24:47 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id t14so204598pgl.10 for ; Wed, 23 Sep 2020 11:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v5zRX01qtXrrU3318i74/fidYSO995M1vfyg0zlq+Us=; b=f4M7nBJr0/YuFmLWtlr3y40MO071z5It+3S5m4398lqSZ/TjNliLudBREhFa7e3d1l qcnaPAVt6lnC0vZLBoG2eC9TP/dbcI6pNgIXhVW2B+9a81VNaKRL2OBvPF3T9Ybd+Y2e q8Vta6EY5dqhTNqatGMbOILE6GSSvOOwNiBGRCNAm5TV4pgh2xDbKgy0e2T64BgAaSJP cKGELKl7fFR0UeDJH7wwV9616MLa2Fhb9XriU/6HN76Kglk3EqBYpNNhaYCEPc+nos0y LM35uHt0jRDqvOxYcYHNYMsAWqkmWceSk5jXTi1xLIZmKhEpQzrVRX40wGyLgvx87Fln mVyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v5zRX01qtXrrU3318i74/fidYSO995M1vfyg0zlq+Us=; b=C+KTJSaclhO4DAqybcQ3UkWlM1I5ynAUSURC9JoM6+MitE0OM8ccf8MHWsPDEdX0Hq TKGyrxQy/HAb4/ahN11VMj285jhT+m83rHAqSXxrgSCzwy+9sjTEJfdcl7M5rjLOo8SL PW0O17Q3/eEb/6/4vvkTO1v9jaK3ql6S2MA0ghWarQYOiOFwXsKCok4airsBzalkYUB3 auMVblpHgeS8Ml4dBOCOO/N4nVnijTXRvzk/7kDcuh2qCMiPAheaKPWL3WXebBGTl+1g 9+J+FeQQBOEXFJ1vmtLieH5dj8BwLfZSsLUS8AbjOqPBimMD0/5ltiRmzRZsoDMXXqeC wIaA== X-Gm-Message-State: AOAM532Ozi80XBAkD6q2tjpCVwaI4620Dmsx3rLeAZTkaCD0uJeXmjmz GvhWrCJgXZtQG0JR7013W8+Ip92v/VqVRA== X-Google-Smtp-Source: ABdhPJwTIjRGwPk2poeNfAOBYII9TntogZxHFE8vHM6LfsTIhmbC7rBLGr7RC1yOHR4mNJLY0UL6NQ== X-Received: by 2002:a62:62c3:0:b029:151:223b:3ba0 with SMTP id w186-20020a6262c30000b0290151223b3ba0mr658178pfb.28.1600885486896; Wed, 23 Sep 2020 11:24:46 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 203sm356377pfz.131.2020.09.23.11.24.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 11:24:46 -0700 (PDT) Date: Wed, 23 Sep 2020 11:24:38 -0700 From: Stephen Hemminger To: Cristian Dumitrescu Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com Message-ID: <20200923112438.4b3e1328@hermes.lan> In-Reply-To: <20200923180645.55852-2-cristian.dumitrescu@intel.com> References: <20200910152645.9342-2-cristian.dumitrescu@intel.com> <20200923180645.55852-1-cristian.dumitrescu@intel.com> <20200923180645.55852-2-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 01/41] pipeline: add new SWX pipeline type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 23 Sep 2020 19:06:05 +0100 Cristian Dumitrescu wrote: > +/* > + * Pipeline. > + */ > +struct rte_swx_pipeline { > + int build_done; > + int numa_node; > +}; > + Nit, could build_done be a bool type? +void +rte_swx_pipeline_free(struct rte_swx_pipeline *p) +{ + if (!p) + return; + + free(p); +} The free() function in libc is defined to accept NULL as ok. Please remove the if()