From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5712EA04B1;
	Wed, 23 Sep 2020 23:03:12 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 0CED11DB42;
	Wed, 23 Sep 2020 23:03:11 +0200 (CEST)
Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com
 [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 2D0581C2F3
 for <dev@dpdk.org>; Wed, 23 Sep 2020 23:03:09 +0200 (CEST)
Received: by mail-pg1-f195.google.com with SMTP id 34so452879pgo.13
 for <dev@dpdk.org>; Wed, 23 Sep 2020 14:03:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=3kaNJ70ngopzdqvw6B0gMP32/xhrR9HJCL+X+QeUAz4=;
 b=NiJpjDMwg4a3J3CzHb6akt7bSFdgGav628cPruLot4caHNOnpp7uZ0TV2Pe/aUmN4z
 PPWyFMefqli/UOHLtagyXv6JgjYr0d3ZIUwfdbg7NUMv9y+ukoDRddZ4ybYsa6WeQBR2
 yfud33oZRPKc3JODL4/8EBOZ2ctP6ROvb2pU2rJg7An7M47SEH3HRdt2JzaVk3NTBOi3
 CBN+TaW0Jym30dcH32jb9D6iDg10JWDJ1tCGp2UFkjq4PIadzdaBAK4Bt4D3GZl4TnR1
 D3ye0TjHj8DsHCCardsAhMdKVU0QoycRCcida1FkMUP4jCDImDoLaqrgEg8Y4dgUWeSu
 CRcA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=3kaNJ70ngopzdqvw6B0gMP32/xhrR9HJCL+X+QeUAz4=;
 b=h2GANXGcBKNwaGwfv0ONDsnyStjIzLR0mYog5Ctv6GmEqLuAO/uHDGJ2ayjCxOxdev
 zRuMB29XXYq65jF3yy0LTIrMPBYwrk3RW/QflthC0SKy9mR+DIZnu16gJqnDLg/2eisO
 sq6CYIMl9gQ8AAzbyXH+9LmYmrreDJhaCpVIq7vw31Eaa79ROP+UnGOufbKpJATHu3LY
 oeJlhDzdl3nJ//9S3ki5n3AvFbO+KxqaQ+DdEQ1JtOC9kYhd7aJKLC6/UiyQfP0CEruN
 jsihHvKyG/wenpXZYNx00YFwCswwMYy8WFcVymvuWC+kCvYfU8LMLvoPMnLnmb6VhrH+
 DnxQ==
X-Gm-Message-State: AOAM532tKvbEYo3AsKyIygIxDypT6WeEYCFmX0rR6wy22WW8M1eVvmS3
 vFb1CQ/4pkGdcCq6RxcW1BXRoQ==
X-Google-Smtp-Source: ABdhPJwnzd7CXZ+6s0jAJ4A5JsrZRkMMK5+dBFaXTE0Nb74Pd48lj0gEUEPK+QKgaHkuSdrxtvdO8A==
X-Received: by 2002:a63:4a43:: with SMTP id j3mr1387640pgl.42.1600894988276;
 Wed, 23 Sep 2020 14:03:08 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id z4sm511028pfr.197.2020.09.23.14.03.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 23 Sep 2020 14:03:07 -0700 (PDT)
Date: Wed, 23 Sep 2020 14:02:58 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
 arybchenko@solarflare.com, "John W. Linville" <linville@tuxdriver.com>,
 Ciara Loftus <ciara.loftus@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Shepard Siegel <shepard.siegel@atomicrules.com>, Ed Czeck
 <ed.czeck@atomicrules.com>, John Miller <john.miller@atomicrules.com>, Igor
 Russkikh <igor.russkikh@aquantia.com>, Pavel Belous
 <pavel.belous@aquantia.com>, Steven Webster <steven.webster@windriver.com>,
 Matt Peters <matt.peters@windriver.com>, Somalapuram Amaranath
 <asomalap@amd.com>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh
 <shshaikh@marvell.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath
 Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>, "Wei Hu
 (Xavier)" <xavier.huwei@huawei.com>, Rahul Lakkireddy
 <rahul.lakkireddy@chelsio.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@nxp.com>, Wei Zhao <wei.zhao1@intel.com>, Jeff
 Guo <jia.guo@intel.com>, Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk
 <mk@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin
 <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>, Gagandeep Singh
 <g.singh@nxp.com>, John Daley <johndale@cisco.com>, Hyong Youb Kim
 <hyonkim@cisco.com>, Gaetan Rivet <grive@u256.net>, Xiao Wang
 <xiao.w.wang@intel.com>, Ziyang Xuan <xuanziyang2@huawei.com>, Xiaoyun Wang
 <cloud.wangxiaoyun@huawei.com>, Guoyang Zhou <zhouguoyang@huawei.com>, "Min
 Hu (Connor)" <humin29@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>,
 Beilei Xing <beilei.xing@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Qiming Yang <qiming.yang@intel.com>, Alfredo Cardigliano
 <cardigliano@ntop.org>, Rosen Xu <rosen.xu@intel.com>, Shijith Thotton
 <sthotton@marvell.com>, Srisivasubramanian Srinivasan
 <srinivasan@marvell.com>, Jakub Grajciar <jgrajcia@cisco.com>, Matan Azrad
 <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, Viacheslav
 Ovsiienko <viacheslavo@mellanox.com>, Zyta Szpak <zr@semihalf.com>, Liron
 Himi <lironh@marvell.com>, Stephen Hemminger <sthemmin@microsoft.com>, "K.
 Y. Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>,
 Long Li <longli@microsoft.com>, Martin Spinler <spinler@cesnet.cz>,
 Heinrich Kuhn <heinrich.kuhn@netronome.com>, Harman Kalra
 <hkalra@marvell.com>, Jerin Jacob <jerinj@marvell.com>, Nithin Dabilpuram
 <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Akhil
 Goyal <akhil.goyal@nxp.com>, Jasvinder Singh <jasvinder.singh@intel.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Keith Wiles
 <keith.wiles@intel.com>, Maciej Czekaj <mczekaj@marvell.com>, Maxime
 Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>,
 Zhihong Wang <zhihong.wang@intel.com>, Yong Wang <yongwang@vmware.com>
Message-ID: <20200923140258.70ee25e9@hermes.lan>
In-Reply-To: <2789130.svnmZjVqCQ@thomas>
References: <20200913220711.3768597-1-thomas@monjalon.net>
 <20200913220711.3768597-3-thomas@monjalon.net>
 <3cec8608-ff68-5749-7d6d-b97a3d5f3fcf@intel.com>
 <2789130.svnmZjVqCQ@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error
 on close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 23 Sep 2020 22:53:46 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 23/09/2020 18:41, Ferruh Yigit:
> > On 9/13/2020 11:06 PM, Thomas Monjalon wrote:  
> > > The device operation .dev_close was returning void.
> > > This driver interface is changed to return an int.
> > > 
> > > Note that the API rte_eth_dev_close() is still returning void,
> > > although a deprecation notice is pending to change it as well.  
> > 
> > Why not update the 'rte_eth_dev_close()' in this patch? After the 
> > updates below it should be easier.  
> 
> Yes it is a step in the right direction.
> Changing the API means adding some error checks in every apps.
> The reason for not doing is that I did not commit for this task,
> and I am not the author of the deprecation notice.
> We can discuss how to follow up once this series is merged.

Not sure what application can really do if dev_close fails other than call rte_exit()?