From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 854F8A04B1; Wed, 23 Sep 2020 23:47:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34CB71DB47; Wed, 23 Sep 2020 23:47:57 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 2820E1DB21 for ; Wed, 23 Sep 2020 23:47:56 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id o20so470443pfp.11 for ; Wed, 23 Sep 2020 14:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xFoVKvuSBlynIkpEZZ8oebv/gJ/5ie/nZl1aFQk0bQE=; b=UADJWwaKbZgF9c/ivJM+cfcSadhJWxAnn51d8E5YMr3RcJBnUBs67PFHMC+Y3KB1Rn UemCSrnU9sRFYHLKLjhdLBC/iUqwUjvlWtM9V0QteTFjDzylVeQ4rve95URA2AScVEO1 h1Ykvp2AvifH2ErjiuUC/DBPhHWAif09utXSW9/UpjDr8QM4wW1iSy1qINVUUdzNSvT0 q9fNJSRwPteEOl3cGayoEE2eCeQrdFdnP1+Gi52L4Dehu1EK+R+eMfNCoQ2TqE1DD/MD Lm5ucYmaSKoXH8b/5WuKWeTkEgGOnxAqvrJmx/6LPLBTR00Y5wus/aWHIv3/HDYLiBaa xSNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xFoVKvuSBlynIkpEZZ8oebv/gJ/5ie/nZl1aFQk0bQE=; b=bS+BzAYSUNqS/ax/nPXsxNh/f4K+5BKgk1uQzYCQu+W4M8cCF0whcnEOKJLkFPCccT 81daWEDme20LX+7GMJvKaG6o1375fKMAtv4USrjngtEeHhKZ+LxLpTS+5beexfpUKH5r nmn3uYx35w18mjHDI8lwWn1xUdV1Bw4ktDVbyP5x4KAxuOSDVbUSpHDT/tq4GpV7jR7h fc9lS03rP2/ptR+BN8vVsrjZUkGYimqhP7KuUbeWGB4TbyMIZUeukTQEtCI8DcTJHEom ITYTe6tDU2s5xHQFGPcOcgBo/5VIM3/M2sY5CIwDI38pB7rmJvcyDBeKCjBb+ml+BTlj BJiw== X-Gm-Message-State: AOAM531EECkDjncduB+S3LK+/h4eWkxq5N0ppxz2a7WqrSzWzcit3+P+ BxDwlw69oZ/lpgUgOiCq/lwxkw== X-Google-Smtp-Source: ABdhPJwrXYyNYs7uKB6/RQot5+l/K91ha7sApuxWLHlNHc8/h7xPp13lLMMT/J87n9XM7yt1M+Tuuw== X-Received: by 2002:a65:580c:: with SMTP id g12mr1446420pgr.257.1600897675184; Wed, 23 Sep 2020 14:47:55 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f3sm696773pgf.32.2020.09.23.14.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 14:47:54 -0700 (PDT) Date: Wed, 23 Sep 2020 14:47:44 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Ferruh Yigit , dev@dpdk.org, arybchenko@solarflare.com, "John W. Linville" , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wei Zhao , Jeff Guo , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Akhil Goyal , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang Message-ID: <20200923144744.6ebf0065@hermes.lan> In-Reply-To: <3329768.rLCo6hCP44@thomas> References: <20200913220711.3768597-1-thomas@monjalon.net> <2789130.svnmZjVqCQ@thomas> <20200923140258.70ee25e9@hermes.lan> <3329768.rLCo6hCP44@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 23 Sep 2020 23:06:42 +0200 Thomas Monjalon wrote: > 23/09/2020 23:02, Stephen Hemminger: > > On Wed, 23 Sep 2020 22:53:46 +0200 > > Thomas Monjalon wrote: > > > 23/09/2020 18:41, Ferruh Yigit: > > > > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > > > > The device operation .dev_close was returning void. > > > > > This driver interface is changed to return an int. > > > > > > > > > > Note that the API rte_eth_dev_close() is still returning void, > > > > > although a deprecation notice is pending to change it as well. > > > > > > > > Why not update the 'rte_eth_dev_close()' in this patch? After the > > > > updates below it should be easier. > > > > > > Yes it is a step in the right direction. > > > Changing the API means adding some error checks in every apps. > > > The reason for not doing is that I did not commit for this task, > > > and I am not the author of the deprecation notice. > > > We can discuss how to follow up once this series is merged. > > > > Not sure what application can really do if dev_close fails other than call rte_exit()? > > At least, it can show a message to the user. Agree, but no code checks return from close() system call now. At least testpmd should be updated; the examples are fine.