From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E62EA04B1; Thu, 24 Sep 2020 06:02:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DAFD1DCE9; Thu, 24 Sep 2020 06:02:29 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70058.outbound.protection.outlook.com [40.107.7.58]) by dpdk.org (Postfix) with ESMTP id A59781DB3F; Thu, 24 Sep 2020 06:02:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FVwAWxQ3AUtOVhtg/0rW8V+X9f7DXPu2hZdU96aBfs179u0lVPF8Uzw/kFyxh5wPOs26oUYbRF24r8B2/RrmNo9L919UW4R2SL6vM90jx1Gd1WZXDlXQGhXPjej7DF5S0Xus4ffPyW2QDlD7UKCoEqI0tKHocrKfAHa62Je28PuxGY+aS9T0JkvR+TuZOgbdHk5C+vbPgWYCD3RSvvgLKZieNUKrr/voJERAsEHIjI7M2QkAL1k2SV/qQafEpQigFGiCjBdeUshiNKhSGVMaT/6PU4lIY+BkL/LWSQVGbsFpUma3zwn5wOx1meFuN3ZOoDugPZi5Tb43jntYI+A2hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvWCyDpz9zTtQBdb+PVRepHgeFeC4MjPNLnHm7JFm9o=; b=Qalf5/UuYY8yPMX5Rbj78A6Zggpj/RWYu7QUDPjJJn+Mm4vIRleJVCVt6Z4mni2aHc50303GF+nwxweVK86fdN172rZAZN0ZfPJWPor0eD1wMYSq4NIHlDCXGG0jCwTqZIkr+J4oGjBuj8xLPJbQbExllBdNkWUKngtid0etgEMErGBwSotzRg7tiSnExA/2j4t/RRVoPXDWf8hiAqV1olYjQ8DNkdeDjz6DDi7SWlEZgY0M3S5FHzNvq5uvbn0fZZ5Xjdz6D5w/skqGGunhABFAveq7dT13aemakCXbQbZDrJWSkJZHymM4+PEagT/3JO/S/3eYyazPsXZDuEdrwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvWCyDpz9zTtQBdb+PVRepHgeFeC4MjPNLnHm7JFm9o=; b=P2Lcgtg6jQ2oWzunqLqYCwA//u55u6x10ZtM84UCxnkP7Pdx9rYOW37mKCsKq4VXls17pmQPiCFecISYnlLlN/u+ztXQhlolkJ8qHtbnO0MwBG2HJKpJePZfht75AezbbK0gYloYvfMvh7Iyxdh+4CibsXnIlGWuy+Kr1bu9uk0= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=oss.nxp.com; Received: from VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28) by VI1PR04MB5839.eurprd04.prod.outlook.com (2603:10a6:803:e0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Thu, 24 Sep 2020 04:02:24 +0000 Received: from VI1PR04MB5837.eurprd04.prod.outlook.com ([fe80::cc01:9fe2:2544:8a4b]) by VI1PR04MB5837.eurprd04.prod.outlook.com ([fe80::cc01:9fe2:2544:8a4b%7]) with mapi id 15.20.3391.013; Thu, 24 Sep 2020 04:02:24 +0000 From: "Sachin Saxena (OSS)" To: dev@dpdk.org, ferruh.yigit@intel.com Cc: stable@dpdk.org Date: Thu, 24 Sep 2020 09:32:04 +0530 Message-Id: <20200924040209.32719-2-sachin.saxena@oss.nxp.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200924040209.32719-1-sachin.saxena@oss.nxp.com> References: <20200911083520.24020-1-sachin.saxena@oss.nxp.com> <20200924040209.32719-1-sachin.saxena@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SG2PR02CA0010.apcprd02.prod.outlook.com (2603:1096:3:17::22) To VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from lsv03161.swis.in-blr01.nxp.com (14.142.151.118) by SG2PR02CA0010.apcprd02.prod.outlook.com (2603:1096:3:17::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3412.22 via Frontend Transport; Thu, 24 Sep 2020 04:02:23 +0000 X-Mailer: git-send-email 2.28.0 X-Originating-IP: [14.142.151.118] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 191efaba-f27f-4e85-99cc-08d8603ea4db X-MS-TrafficTypeDiagnostic: VI1PR04MB5839: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:370; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9zO1VlGyLJJmqPK9athE1hGF+kgi00t8FhMz3gKsBhgaGx/XPSYrMoM+5yckLGHrodtpggXZnwkteKfDSW4WX1lJOCH8OpO+E5PQaxOEDHbqGN0ynox1Sje/mFhRYWJLHGolQLFgV3KINDwRx5liRdYDi6R9lOM8pwaOjX3IYK9ntdhWj85gxyIJLVZSmLc2KmnRdySRKshwauj1VrItpBZx2jU1d5+suc3fuQnI1ch2X4LZVXVlF5rR7/2S6Y39+urVcnyUpCbn5byI0anxwEgXn5Y9J63nQFXzPmAP2lf95e0FAr19QSdJ/FXK6VLRtEkok4DH9dTL4D6Z0BeDEiqjWIP8NRTFnYNA1LWioiiO6v/6kF4KO0ruD2px5lsi X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5837.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(2616005)(4326008)(16526019)(83380400001)(186003)(6666004)(478600001)(26005)(316002)(6486002)(8936002)(1006002)(6512007)(66556008)(55236004)(66946007)(52116002)(1076003)(956004)(86362001)(2906002)(66476007)(8676002)(6506007)(5660300002)(110426005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ELYf+y1PQv6KY3OkIzlPUOJ6eCBFWxadM8MvsyPQZqfYE+w+Bd/RC3iIztSKfLFFS9Ey/qqq/5Ywxfi8hqTj0ukqBpf2TXDv33iymEooxt+duTmVlQ1XNWLpDyBwNtOYuecOWhlvS19K2r2BgDkXQL+LdsdeO2u65bAlCsc8r2JmmYD6hcZoV7nPqQSUTAHF6dSGUqjzRuZmv/cqt9ZXBZcnWXnsJ4Auvg9J5YgLjN1kdLYESx8y7sF5Q4wUy56G7HYm8Lox8mnhoubNLdClBfXsyD8bzugI90cuHsSLNu5xMwaf1jcF8wIIYEntW8ME9foVH0qYWZPkSx6DxEb/b7ecI1r3X4stjYnrubcgtHJTwm9VIZiV/Fp6fXtlPNpg+fFchmF2PoS3l/dT+9ljdTgPgHz8eowqVBu9Asc12f3wtkVZY75DPByuzqX/1EpFLA+13qm/47lTOFEfLz+we2RBrB3D0T/dPUFgOIxDC994sSle4i9mfVwTO3qAYRCxSMgiRxkTZ3DKg/QHdashl17twSvC0lv4DDCy13S3ZCaTuwHCDCKykJxKnzCW0J05CX2f6PEJ6jnz0EVntvRweyn/boQonbDQzkCVqlA3SuZWThiqsdp8R9ZDbyqhw16S8W8cVgAFMaFx8cZ6jJFRQQ== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 191efaba-f27f-4e85-99cc-08d8603ea4db X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5837.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2020 04:02:24.5297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6vphNuqiHDCCmJl8lCaGaHYhnTECm5im+IDlaxG8QoIZ0rlsQTjSh8IWP2vXLlMIBpoMT9JQDT/t8i2HBkqOyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5839 Subject: [dpdk-dev] [PATCH v3 1/6] bus/fslmc: fix atomic queues on nxp lx2 platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Youri Querry Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index to consumer index") Cc: stable@dpdk.org Signed-off-by: Youri Querry Signed-off-by: Rohit Raj --- drivers/bus/fslmc/qbman/qbman_portal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c index 0a2af7be4..77c9d508c 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.c +++ b/drivers/bus/fslmc/qbman/qbman_portal.c @@ -1201,6 +1201,8 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, QBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask)); memcpy(&p[1], &cl[1], 28); memcpy(&p[8], &fd[i], sizeof(*fd)); + p[0] = cl[0] | s->eqcr.pi_vb; + if (flags && (flags[i] & QBMAN_ENQUEUE_FLAG_DCA)) { struct qbman_eq_desc *d = (struct qbman_eq_desc *)p; @@ -1208,7 +1210,6 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, ((flags[i]) & QBMAN_EQCR_DCA_IDXMASK); } eqcr_pi++; - p[0] = cl[0] | s->eqcr.pi_vb; if (!(eqcr_pi & half_mask)) s->eqcr.pi_vb ^= QB_VALID_BIT; -- 2.28.0