From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A7DEA04B5; Thu, 24 Sep 2020 16:48:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FE421DECD; Thu, 24 Sep 2020 16:48:43 +0200 (CEST) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id BD0091C434 for ; Thu, 24 Sep 2020 16:48:41 +0200 (CEST) Received: by mail-pj1-f66.google.com with SMTP id jw11so1730678pjb.0 for ; Thu, 24 Sep 2020 07:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s5G/4fZ5llHwWS35xsf2aIiuGG1Sv/xcG8SQgk+fjz4=; b=DgmfdO7PzGSZlgGjCNQORixk6skFRqRwfC8Gl11q7EJ1pUX2Q47wIVL2AsNOYOnNtT iPgysRvSQsGFkyTTX52Vwo1ZMav7d8jY0zg8IiemGUlTAgTmfuC3+5OVWzq/KUQC12BP 2ZWiU23hqxH68pgupNU5VAGGO9ZFFRbS/+gKuZQ+sgXObYbVA6YS34FIunU/gVYK5LLQ qAVWnH2Qj4VtyJ5w7ObqeQlrTFGEwPE5hcB8IJY1JQnJ0yQbRVX6cKYVgdxDyxmgsq9C SQ0VcjE6E/tR4py8rqlhbsKV6OWCqSFaBC5oUE+ajTRaS0sh6YPPJ3dt2+RegMlKE0r8 u5Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s5G/4fZ5llHwWS35xsf2aIiuGG1Sv/xcG8SQgk+fjz4=; b=hDl0OInHenfvAZ7ZThGBqrEKbRnbgxG1Na8yJ160Ve/kxN7uo80GZwvmx/uR1Pc8YH SnpjVez1N9jXsQsVIWua0qupv8Me/aPZo/AHuk7yCzwB+rUMLjIravPNCrVdUOADUhbO bzAecuhYQGysOWBidmGNfzqwFEHrD05Xf75hV49e4sBC/fvKT2D5HZLGAQLASNBRheuL tdfJ5IOY48QZXeNY9JsaaZGKostUoaoxTdylGIxca+cKYgYme+n00r5PAzin351Emg+w oMVuXr6Xqb/tafWW+gJpPMEpgW4OSwdU8/qj9u7K0sYEbxWmOGACyG7A2jwKAJvKR1QQ VhSg== X-Gm-Message-State: AOAM532HqezxSOuXWVDOqHBRoDGAkyaxJTinogIbqJzS36k6hSnlcKTP EtRy2zlF8ixqDniEIcheKJpcKw== X-Google-Smtp-Source: ABdhPJwqokEZI7LYCLVA4cLn21AAasxrw/67f5Py0CcWmeFKk3uytiu3TG3QWhw5iz8y6KrYGG60iA== X-Received: by 2002:a17:90a:62c4:: with SMTP id k4mr4243681pjs.174.1600958920851; Thu, 24 Sep 2020 07:48:40 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z129sm3276459pgb.84.2020.09.24.07.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 07:48:40 -0700 (PDT) Date: Thu, 24 Sep 2020 07:48:30 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: Thomas Monjalon , Ferruh Yigit , dev@dpdk.org, arybchenko@solarflare.com, "John W. Linville" , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wei Zhao , Jeff Guo , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Akhil Goyal , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang Message-ID: <20200924074830.0dcff4f1@hermes.lan> In-Reply-To: <20200924091246.GA382@bricha3-MOBL.ger.corp.intel.com> References: <20200913220711.3768597-1-thomas@monjalon.net> <7906978.WFKINk0of7@thomas> <20200923150238.01cbf109@hermes.lan> <4950952.GUjYEhNGMI@thomas> <20200924091246.GA382@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 24 Sep 2020 10:12:46 +0100 Bruce Richardson wrote: > On Thu, Sep 24, 2020 at 12:35:58AM +0200, Thomas Monjalon wrote: > > 24/09/2020 00:02, Stephen Hemminger: > > > On Wed, 23 Sep 2020 23:52:07 +0200 > > > Thomas Monjalon wrote: > > > > > > > > > > > Yes it is a step in the right direction. > > > > > > > > Changing the API means adding some error checks in every apps. > > > > > > > > The reason for not doing is that I did not commit for this task, > > > > > > > > and I am not the author of the deprecation notice. > > > > > > > > We can discuss how to follow up once this series is merged. > > > > > > > > > > > > > > Not sure what application can really do if dev_close fails other than call rte_exit()? > > > > > > > > > > > > At least, it can show a message to the user. > > > > > > > > > > Agree, but no code checks return from close() system call now. > > > > > At least testpmd should be updated; the examples are fine. > > > > > > > > How do you explicitly silence the static code analyzers? > > > > Do you recommend adding (void) in front of the call to close()? > > > > > > Coverity usually gives something like, "return value of foo() is not checked > > > but checked 10 other places" > > > > Yes so it should be silenced with (void) or ret = > > > Does coverity still give the warning if the majority of cases don't > actually check the return value? It looks like coverity only looks at some functions and if majority is checking. For example, it never nags about just calling close().