From: Sarosh Arif <sarosh.arif@emumba.com>
To: jerinj@marvell.com, ndabilpuram@marvell.com
Cc: dev@dpdk.org, Sarosh Arif <sarosh.arif@emumba.com>
Subject: [dpdk-dev] [PATCH v2] common/octeontx2: fix memory mapping API's usage
Date: Thu, 24 Sep 2020 15:39:32 +0500 [thread overview]
Message-ID: <20200924103932.3834392-1-sarosh.arif@emumba.com> (raw)
In-Reply-To: <20200713130053.31851-1-sarosh.arif@emumba.com>
replace mmap() with rte_mem_map()
and replace munmap() with rte_mem_unmap()
Fixes: e1d9a02ad8f0 ("common/octeontx2: introduce common device class")
Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
---
v2:
update description and commit message
---
drivers/common/octeontx2/otx2_dev.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/common/octeontx2/otx2_dev.c b/drivers/common/octeontx2/otx2_dev.c
index d61c712fa..6a84df234 100644
--- a/drivers/common/octeontx2/otx2_dev.c
+++ b/drivers/common/octeontx2/otx2_dev.c
@@ -11,6 +11,7 @@
#include <rte_common.h>
#include <rte_eal.h>
#include <rte_memcpy.h>
+#include <rte_eal_paging.h>
#include "otx2_dev.h"
#include "otx2_mbox.h"
@@ -34,10 +35,11 @@ mbox_mem_map(off_t off, size_t size)
if (mem_fd < 0)
goto error;
- va = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, mem_fd, off);
+ va = rte_mem_map(NULL, size, RTE_PROT_READ | RTE_PROT_WRITE,
+ RTE_MAP_SHARED, mem_fd, off);
close(mem_fd);
- if (va == MAP_FAILED)
+ if (va == NULL)
otx2_err("Failed to mmap sz=0x%zx, fd=%d, off=%jd",
size, mem_fd, (intmax_t)off);
error:
@@ -48,7 +50,7 @@ static void
mbox_mem_unmap(void *va, size_t size)
{
if (va)
- munmap(va, size);
+ rte_mem_unmap(va, size);
}
static int
--
2.25.1
next prev parent reply other threads:[~2020-09-24 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 13:00 [dpdk-dev] [PATCH] drivers/common/octeontx2: use generic memory management Sarosh Arif
2020-09-23 10:58 ` Sunil Kumar Kori
2020-09-24 10:39 ` Sarosh Arif [this message]
2020-09-28 6:08 ` [dpdk-dev] [PATCH v2] common/octeontx2: fix memory mapping API's usage Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924103932.3834392-1-sarosh.arif@emumba.com \
--to=sarosh.arif@emumba.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).