From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85990A04BB; Fri, 25 Sep 2020 01:17:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 690261E499; Fri, 25 Sep 2020 01:17:35 +0200 (CEST) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 61BD31DEE8; Fri, 25 Sep 2020 01:17:34 +0200 (CEST) Received: by mail-lf1-f67.google.com with SMTP id x69so714871lff.3; Thu, 24 Sep 2020 16:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SFGAkY2gEe/DKSe75dHWbCbSH0Rx/K50KTuusdyvjCM=; b=BMgf2kLOQGoOB6scyCBixfya79tee+0fSYLJIQfilkF1w96XUug0vmo/zUKRiqMbUO q20YXcNqgBwsy3BeIWBWaG0aj8S76TI7DoNG72xIneQjTCzrL9Nkh77uAZPmTf2HfgFT 0ZUvHOjRMJwApUNHEw6jh2vKCXd0GvS3rJCE3TP22/jiQ3r0pMTcmdSaC1ZhOHtUbXat mjU55EZEnWBWSPiQeG7PknWlf/ra44/MrNkR4cpJFowDeIorH0Z9Nc9qJ4lSQp1drExm 2hmX8lvfzy1LURtZh/JVuOYrjeczqD39F17RtwFGugEg6dGXNdwhBm2nsvUE5vwtmUn7 WqKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SFGAkY2gEe/DKSe75dHWbCbSH0Rx/K50KTuusdyvjCM=; b=naey6Lr8L8diPVu2Zq29tWEQPQH+G/SEMtENzJfNZ0hYDftmEYsMgMf1EadtX1KpQZ OpyLMxlSd2PvtpKXWU704pB5GN7US065DCbtKcVjKC6iuUl0MgjKKIE4PKwJPpYviHuz OevWtCoUoArXz74nCbp71h/CgqVm1pNqXCj17mElC2JndQrVVFQ+E/o/YuFOobdnzgvF pLej1Mal/GtgzF16J5YgzM2k1DvjGXes7Mrn6gBpKnLl69stPhASzEVKwGhRg+TAgWV5 VsfOtkclaAkhK7IkvynUZP70saolc1VsXdfWZ9TEJTiFWh68SsvgqYBp8lkCMRRo7yVX OZZA== X-Gm-Message-State: AOAM533mjEeHwPFGbw25vmbmanzGkH6SlTOC7C7P8xwV6iFJ4LwuXYk0 WlDq4IWUPWSIVoUO7ZpAzEZssZlXe4awDqRR X-Google-Smtp-Source: ABdhPJyimELbUxUZ+mk4Og7rcrVokAXwGgIG8rFbYhk3z7EogflJivpZ6z8Wjh6Se9QZIprpGdrZFw== X-Received: by 2002:a19:c154:: with SMTP id r81mr376309lff.424.1600989453897; Thu, 24 Sep 2020 16:17:33 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id g63sm630417lfd.28.2020.09.24.16.17.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 16:17:33 -0700 (PDT) Date: Fri, 25 Sep 2020 02:17:32 +0300 From: Dmitry Kozlyuk To: Tal Shnaiderman Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, ranjit.menon@intel.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, stable@dpdk.org Message-ID: <20200925021732.7442a9df@sovereign> In-Reply-To: <20200923141538.9956-1-talshn@nvidia.com> References: <20200923141538.9956-1-talshn@nvidia.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix incorrect free condition in getopt implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 23 Sep 2020 17:15:38 +0300, Tal Shnaiderman wrote: > In the Windows getopt_internal function the condition freeing > the memory allocated by _dupenv_s is correct only for the first > call to the function. Hi Tal, a few days back Khoa To and me privately discussed a patch that makes MinGW and Clang bith use getopt.c from librte_eal (now only Clang does). That patch includes adjustments that just remove _dupenv_s() along with the bug. Just discovered you were not Cc'd, sorry. I put your name in Reported-by and mentioned the bug in commit message: http://patchwork.dpdk.org/patch/78765/