From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35E0DA04C0; Fri, 25 Sep 2020 18:12:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 643351D5C9; Fri, 25 Sep 2020 18:12:42 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 7C7F31D5AD for ; Fri, 25 Sep 2020 18:12:40 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id z19so3633676pfn.8 for ; Fri, 25 Sep 2020 09:12:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PCK3SVxDo1NpdO4mZT5jOW3cF1AZ3mdS4loS8dkwpik=; b=XeL67Q4gr7opdxLhhBm3GefLKRx+TrTrkda7Kmj97aMInlTphcWLuHJ8GLGjLdVdhG HaQPadHoVzBqjcdNTGijwsW2herMBu7pD4uZABB5urlbeGE7dw31dZuDhkrjgpUADC0Q 4Rn4KpnNoRJcMIHY+FnGGAeRoZB4K5EOPc2YIKznwxBNojvbQO3wI05SqegNMt9qDQwF SRmtrizrLdmchQazbD/7TGSXfJ0r7N1sSoVl5LP+/fd3890czBUGoZ8KxJk2ik43RT9G 1sGU86KWbUVnOZ+8/SKK/dk6Vn0c25j8GlVPW31xjcIPgnR5bcZx0uCJKWOdbJyB7RLH zjYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PCK3SVxDo1NpdO4mZT5jOW3cF1AZ3mdS4loS8dkwpik=; b=AjUm1fabpMRdYLZ0T9JAQl0uIk0OifplVuinYYXZgWLs8hqNig4/hQ2n+8HxmccY0p JCQN9WuoV3vg0q4MPZj1peMNouXvGrgXTos2S6UAmln1FWEv4wqkhh2Q/ehNtzBOslz3 jeqCPVNu/iv2Xd3ww8wVCqyaBJoQHl9Tv53trh3mfQRsMi5grGP3LALs1Ie0SdNCZQ0A PvUyOjbXuRwCToCmQusem29hqE9PlFKLisQdm3k8lZel1tBwJA96N+Y4ywdUCr9owFoS 2Yt4qR4HltQvzhNU50WJTzhc1l3kT183wL3/jAvLZT/hOuAXjI/CjM6wh9cZ6qUYI6cZ ow2Q== X-Gm-Message-State: AOAM532czs/YZ+9lQ5iZCxcEaDKQVJazF6NScYsRk0MIZ/9r27Dkq7lf N+/ahjxWdrAjWYCHI9euab5xnQ== X-Google-Smtp-Source: ABdhPJyJhjgXtYcoey2Ef+6tOEqEUOc1OnhCYGGJL6//PCAgXGuGIKQP/IBUOAuaU8/RLdD+qCU3sA== X-Received: by 2002:a17:902:ee01:b029:d1:8c50:aa89 with SMTP id z1-20020a170902ee01b02900d18c50aa89mr164055plb.6.1601050358484; Fri, 25 Sep 2020 09:12:38 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s187sm3217244pfc.134.2020.09.25.09.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 09:12:38 -0700 (PDT) Date: Fri, 25 Sep 2020 09:12:29 -0700 From: Stephen Hemminger To: Ajit Khaparde Cc: "Min Hu (Connor)" , Andrew Rybchenko , dpdk-dev , "Ananyev, Konstantin" , Thomas Monjalon , Ferruh Yigit , linuxarm@huawei.com Message-ID: <20200925091229.6fc8fb43@hermes.lan> In-Reply-To: References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1600952745-55993-1-git-send-email-humin29@huawei.com> <1600952745-55993-2-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH V12 1/4] ethdev: introduce FEC API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 25 Sep 2020 08:36:06 -0700 Ajit Khaparde wrote: > > > > WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment > > #264: FILE: drivers/net/hns3/hns3_ethdev.c:5601: > > + /* fallthrough */ > Try /* FALLTHROUGH */ That won't work either. This is a new warning from upstream Linux kernel checkpatch. The Linux kernel has converted code to use a new macro. The warning should be silenced by the DPDK checkpatch script. diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 78a408ef9823..923ff6f7d9ee 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\ SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\ LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ -NEW_TYPEDEFS,COMPARISON_TO_NULL" +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH" options="$options $DPDK_CHECKPATCH_OPTIONS"