From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB587A04C0; Fri, 25 Sep 2020 13:14:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C45881E90C; Fri, 25 Sep 2020 13:12:42 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 796DF1E90C; Fri, 25 Sep 2020 13:12:40 +0200 (CEST) IronPort-SDR: TrAIdu6M5YA7cpa+6oeNbECMK9xYKhCg9Lr4o/d15oNZGNU+OCpXVWS9NAvxEn6dw62JwsTcFt DaWOPH0Kb9QA== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="140911554" X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="140911554" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 04:12:39 -0700 IronPort-SDR: OfHmpyfH/L6bvU/QANC57T8w0GU51iW7vAp7/1WIEZOsijqAWhPR8j5PX2Y4e8ThavrOpi/yRj vcUN5djbTq9A== X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="487429720" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.51.38]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 25 Sep 2020 04:12:37 -0700 Date: Fri, 25 Sep 2020 12:12:33 +0100 From: Bruce Richardson To: dev@dpdk.org Cc: patrick.fu@intel.com, Kevin Laatz , stable@dpdk.org, Sunil Pai G Message-ID: <20200925111233.GA943@bricha3-MOBL.ger.corp.intel.com> References: <20200721095140.719297-1-bruce.richardson@intel.com> <20200925110910.284098-1-bruce.richardson@intel.com> <20200925110910.284098-3-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925110910.284098-3-bruce.richardson@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 02/25] raw/ioat: fix missing close function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 25, 2020 at 12:08:47PM +0100, Bruce Richardson wrote: > From: Kevin Laatz > > When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a > dev_close function for the device causing a segmentation fault when no > close() function is implemented for a driver. > > This patch resolves the issue by adding a stub function ioat_dev_close(). > > Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver") > Cc: stable@dpdk.org > > Reported-by: Sunil Pai G > Signed-off-by: Kevin Laatz > --- Forgot to add my own reviewed-by to this: Reviewed-by: Bruce Richardson