From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE556A04BB; Sat, 26 Sep 2020 01:33:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D4211EA1D; Sat, 26 Sep 2020 01:33:02 +0200 (CEST) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id EB9D31E9F2 for ; Sat, 26 Sep 2020 01:32:55 +0200 (CEST) Received: by mail-lf1-f68.google.com with SMTP id y11so4602407lfl.5 for ; Fri, 25 Sep 2020 16:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9rN+XIJohh5Oxkprq02nGPvsjiwmwWD0zuwxlDrqGIs=; b=b0JQrTBrrwtC6jVa+lUo3X7yNSRmnJg5pMJb+vN2vRjc/4i1R0vIsbCuKgDqvB2Rm+ O82PKfharU7bSxbJ2woOfFuTkAs1xg2rWZBz8KcVbIUs7PcWX8ajfwsQbi+2yIjpDgbO 55pYU+6nI+UHN21kQhjLOPhtx4DvZikwY2a6QKK40wpAxBscVMsu2k7eB6U+3yfas6C4 NynW37rpM8ruyn3bWMfUsTKGCswU32ESzBuFxZouhI3zs+C4hOeUJnzAeNOBJXfg3WfW 3lIkURgiMdkZ8TB6y0d1vSiBkZk2TaO1pWUF429JUTbwE5iYVCQ+36ocFO0HAZA88GM6 Le2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9rN+XIJohh5Oxkprq02nGPvsjiwmwWD0zuwxlDrqGIs=; b=pE7iUCz++kmcxkXwfhmzaQz9rkDUKcJAbSXN3m9oMW8rM6hf/Eh5jWeQhgdE+FtscL 97jt50+AoFwaIPybpBbPs+0gHVbjw3rcXUKP1vCLX7bjrMZqqLtubqWeE3BDkHI+nVdy lANkXFBJBfLZlW6Z5Ow6KCgU0Q5/WNJg8nZcQqfDH/6c7vJgWGpFxdMMXRRfq1STH39L dxuyng+dajNmCNub845KGIJ/2xCuWg3+DASPe+REOyeGO1E60knvTB9m/G2E3Xur0mw5 lFDLAbgcvO8YkW0Vxci0wrBWxSAcgkkJfZysCIFTmLZStjYMmTlgHKYmPWN4Y1YFfZGh Go2Q== X-Gm-Message-State: AOAM5315jg18sriNUvamKg2QxHxX0xfI5bIqLedf+sfZ4NN2suqOM6sL uLW0xHOUpJVTzhRRO70QFrJV6KprjCxgJoUl X-Google-Smtp-Source: ABdhPJyny1rVbhU395hpp/zxUtu7xz7iHKTMFECYFpLNULpcAAH7kt/pQHDDCK1/U0TPxPN+p9V0Og== X-Received: by 2002:a19:8316:: with SMTP id f22mr365601lfd.303.1601076774017; Fri, 25 Sep 2020 16:32:54 -0700 (PDT) Received: from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v14sm394511lfe.79.2020.09.25.16.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 16:32:53 -0700 (PDT) From: Dmitry Kozlyuk To: dev@dpdk.org Cc: Khoa To , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Date: Sat, 26 Sep 2020 02:32:43 +0300 Message-Id: <20200925233243.7302-3-dmitry.kozliuk@gmail.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20200925233243.7302-1-dmitry.kozliuk@gmail.com> References: <20200911002207.31813-1-dmitry.kozliuk@gmail.com> <20200925233243.7302-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 2/2] eal/windows: implement alarm API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Implementation is based on waitable timers Win32 API. When timer is set, a callback and its argument are supplied to the OS, while timer handle is stored in EAL alarm list. When timer expires, OS wakes up the interrupt thread and runs the callback. Upon completion it removes the alarm. Waitable timers must be set from the thread their callback will run in, eal_intr_thread_schedule() provides a way to schedule asyncronuous code execution in the interrupt thread. Alarm module builds synchronous timer setup on top of it. Windows alarms are not a type of DPDK interrupt handle and do not interact with interrupt module beyond executing in the same thread. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/rte_eal_exports.def | 2 + lib/librte_eal/windows/eal_alarm.c | 219 +++++++++++++++++++++++++++++ lib/librte_eal/windows/meson.build | 1 + 3 files changed, 222 insertions(+) create mode 100644 lib/librte_eal/windows/eal_alarm.c diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index dd8adfa23..8d8300645 100644 --- a/lib/librte_eal/rte_eal_exports.def +++ b/lib/librte_eal/rte_eal_exports.def @@ -11,6 +11,8 @@ EXPORTS rte_devargs_next rte_devargs_parse rte_devargs_remove + rte_eal_alarm_set + rte_eal_alarm_cancel rte_eal_has_hugepages rte_eal_has_pci rte_eal_init diff --git a/lib/librte_eal/windows/eal_alarm.c b/lib/librte_eal/windows/eal_alarm.c new file mode 100644 index 000000000..3b262793a --- /dev/null +++ b/lib/librte_eal/windows/eal_alarm.c @@ -0,0 +1,219 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2020 Dmitry Kozlyuk + */ + +#include +#include + +#include +#include + +#include + +#include "eal_windows.h" + +enum alarm_state { + ALARM_ARMED, + ALARM_TRIGGERED, + ALARM_CANCELLED +}; + +struct alarm_entry { + LIST_ENTRY(alarm_entry) next; + rte_eal_alarm_callback cb_fn; + void *cb_arg; + HANDLE timer; + atomic_uint state; +}; + +static LIST_HEAD(alarm_list, alarm_entry) alarm_list = LIST_HEAD_INITIALIZER(); + +static rte_spinlock_t alarm_lock = RTE_SPINLOCK_INITIALIZER; + +static int intr_thread_exec(void (*func)(void *arg), void *arg); + +static void +alarm_remove_unsafe(struct alarm_entry *ap) +{ + LIST_REMOVE(ap, next); + CloseHandle(ap->timer); + free(ap); +} + +static void +alarm_callback(void *arg, DWORD low __rte_unused, DWORD high __rte_unused) +{ + struct alarm_entry *ap = arg; + unsigned int state = ALARM_ARMED; + + if (!atomic_compare_exchange_strong( + &ap->state, &state, ALARM_TRIGGERED)) + return; + + ap->cb_fn(ap->cb_arg); + + rte_spinlock_lock(&alarm_lock); + alarm_remove_unsafe(ap); + rte_spinlock_unlock(&alarm_lock); +} + +struct alarm_task { + struct alarm_entry *entry; + LARGE_INTEGER deadline; + int ret; +}; + +static void +alarm_set(void *arg) +{ + struct alarm_task *task = arg; + + BOOL ret = SetWaitableTimer( + task->entry->timer, &task->deadline, + 0, alarm_callback, task->entry, FALSE); + task->ret = ret ? 0 : (-1); +} + +int +rte_eal_alarm_set(uint64_t us, rte_eal_alarm_callback cb_fn, void *cb_arg) +{ + struct alarm_entry *ap; + HANDLE timer; + FILETIME ft; + struct alarm_task task; + int ret; + + /* Calculate deadline ASAP, unit of measure = 100ns. */ + GetSystemTimePreciseAsFileTime(&ft); + task.deadline.LowPart = ft.dwLowDateTime; + task.deadline.HighPart = ft.dwHighDateTime; + task.deadline.QuadPart += 10 * us; + + ap = calloc(1, sizeof(*ap)); + if (ap == NULL) { + RTE_LOG(ERR, EAL, "Cannot allocate alarm entry\n"); + ret = -ENOMEM; + goto exit; + } + + timer = CreateWaitableTimer(NULL, FALSE, NULL); + if (timer == NULL) { + RTE_LOG_WIN32_ERR("CreateWaitableTimer()"); + ret = -EINVAL; + goto fail; + } + + ap->timer = timer; + ap->cb_fn = cb_fn; + ap->cb_arg = cb_arg; + task.entry = ap; + + /* Waitable timer must be set in the same thread that will + * do an alertable wait for the alarm to trigger, that is, + * in the interrupt thread. Setting can fail, so do it synchronously. + */ + ret = intr_thread_exec(alarm_set, &task); + if (ret < 0) { + RTE_LOG(ERR, EAL, "Cannot setup alarm in interrupt thread\n"); + goto fail; + } + + ret = task.ret; + if (ret < 0) + goto fail; + + rte_spinlock_lock(&alarm_lock); + LIST_INSERT_HEAD(&alarm_list, ap, next); + rte_spinlock_unlock(&alarm_lock); + + goto exit; + +fail: + if (timer != NULL) + CloseHandle(timer); + if (ap != NULL) + free(ap); + +exit: + rte_eal_trace_alarm_set(us, cb_fn, cb_arg, ret); + return ret; +} + +static bool +alarm_matches(const struct alarm_entry *ap, + rte_eal_alarm_callback cb_fn, void *cb_arg) +{ + bool any_arg = cb_arg == (void *)(-1); + return (ap->cb_fn == cb_fn) && (any_arg || ap->cb_arg == cb_arg); +} + +int +rte_eal_alarm_cancel(rte_eal_alarm_callback cb_fn, void *cb_arg) +{ + struct alarm_entry *ap; + unsigned int state; + int removed; + bool executing; + + removed = 0; + do { + executing = false; + + rte_spinlock_lock(&alarm_lock); + + LIST_FOREACH(ap, &alarm_list, next) { + if (!alarm_matches(ap, cb_fn, cb_arg)) + continue; + + state = ALARM_ARMED; + if (atomic_compare_exchange_strong( + &ap->state, &state, ALARM_CANCELLED)) { + alarm_remove_unsafe(ap); + removed++; + } else if (state == ALARM_TRIGGERED) + executing = true; + } + + rte_spinlock_unlock(&alarm_lock); + } while (executing); + + rte_eal_trace_alarm_cancel(cb_fn, cb_arg, removed); + return removed; +} + +struct intr_task { + void (*func)(void *arg); + void *arg; + rte_spinlock_t lock; /* unlocked at task completion */ +}; + +static void +intr_thread_entry(void *arg) +{ + struct intr_task *task = arg; + task->func(task->arg); + rte_spinlock_unlock(&task->lock); +} + +static int +intr_thread_exec(void (*func)(void *arg), void *arg) +{ + struct intr_task task; + int ret; + + task.func = func; + task.arg = arg; + rte_spinlock_init(&task.lock); + + /* Make timers more precise by synchronizing in userspace. */ + rte_spinlock_lock(&task.lock); + ret = eal_intr_thread_schedule(intr_thread_entry, &task); + if (ret < 0) { + RTE_LOG(ERR, EAL, "Cannot schedule task to interrupt thread\n"); + return -EINVAL; + } + + /* Wait for the task to complete. */ + rte_spinlock_lock(&task.lock); + return 0; +} diff --git a/lib/librte_eal/windows/meson.build b/lib/librte_eal/windows/meson.build index b690bc6b0..3b2faf29e 100644 --- a/lib/librte_eal/windows/meson.build +++ b/lib/librte_eal/windows/meson.build @@ -5,6 +5,7 @@ subdir('include') sources += files( 'eal.c', + 'eal_alarm.c', 'eal_debug.c', 'eal_file.c', 'eal_hugepages.c', -- 2.25.4