From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 06595A04BB;
	Sat, 26 Sep 2020 01:41:28 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id B700A1E9F5;
	Sat, 26 Sep 2020 01:41:26 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by dpdk.org (Postfix) with ESMTP id 0B0881E9F1
 for <dev@dpdk.org>; Sat, 26 Sep 2020 01:41:25 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id 6736320B7179; Fri, 25 Sep 2020 16:41:23 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6736320B7179
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1601077283;
 bh=sxQ4y1Sd8Aq7WaNXVfi/d1XdMaAJq0asWuEAnf18VY8=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=fffZu0+b8xnM/zx/SRhsIVEqXpbo4/Ephc+EZToiLlNn60il5M7NuTmvccPDJCLBC
 awCZWtzJpY7Qb9yZ/PCe1ESwW5D50hm+IhlJ6Y4tPFezp1DAgcsQJS/Wvt+zI5hju7
 5U9i9wrAQEmSrhvoLGI0ZvXPROXoyK1PdEAIOAwU=
Date: Fri, 25 Sep 2020 16:41:23 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Khoa To <khot@microsoft.com>,
 Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
Message-ID: <20200925234123.GB2470@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20200911002207.31813-1-dmitry.kozliuk@gmail.com>
 <20200925233243.7302-1-dmitry.kozliuk@gmail.com>
 <20200925233243.7302-3-dmitry.kozliuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200925233243.7302-3-dmitry.kozliuk@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal/windows: implement alarm API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, Sep 26, 2020 at 02:32:43AM +0300, Dmitry Kozlyuk wrote:
> Implementation is based on waitable timers Win32 API. When timer is set,
> a callback and its argument are supplied to the OS, while timer handle
> is stored in EAL alarm list. When timer expires, OS wakes up the
> interrupt thread and runs the callback. Upon completion it removes the
> alarm.
> 
> Waitable timers must be set from the thread their callback will run in,
> eal_intr_thread_schedule() provides a way to schedule asyncronuous code
> execution in the interrupt thread. Alarm module builds synchronous timer
> setup on top of it.
> 
> Windows alarms are not a type of DPDK interrupt handle and do not
> interact with interrupt module beyond executing in the same thread.
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>  lib/librte_eal/rte_eal_exports.def |   2 +
>  lib/librte_eal/windows/eal_alarm.c | 219 +++++++++++++++++++++++++++++
>  lib/librte_eal/windows/meson.build |   1 +
>  3 files changed, 222 insertions(+)
>  create mode 100644 lib/librte_eal/windows/eal_alarm.c
> 

Acked-by: Narcisa Vasile <navasile@linux.microsoft.com>