From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 886BEA04BC; Tue, 29 Sep 2020 17:49:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 647031D5C2; Tue, 29 Sep 2020 17:48:59 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 26A5C1D166 for ; Tue, 29 Sep 2020 17:48:57 +0200 (CEST) IronPort-SDR: OIU8LN060cYCZYTg7v+W20+xRi3Wdkpy1UC4X344n8iPwpUicULGIE7qfC2nFt1F/Hk6ZJArnf ZEwV476FRtFw== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="142236187" X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="142236187" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 08:48:55 -0700 IronPort-SDR: JGiB2s19kciprQYV6gl3km0xsYi9HfLy3bJSd4aZl93UHSbbgPj2Z5L0fbqlTvUlF/jJNweo9w MJ//8NElEpHA== X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="312259069" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.220.178]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 29 Sep 2020 08:48:52 -0700 Date: Tue, 29 Sep 2020 16:48:49 +0100 From: Bruce Richardson To: Kevin Laatz Cc: David Marchand , dev , "Burakov, Anatoly" , Robin Jarry Message-ID: <20200929154849.GB966@bricha3-MOBL.ger.corp.intel.com> References: <20200928104328.409055-1-kevin.laatz@intel.com> <20200929102224.440322-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v9 00/11] adding support for python 3 only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 29, 2020 at 04:25:40PM +0100, Kevin Laatz wrote: > On 29/09/2020 13:22, David Marchand wrote: > > Hello Kevin, > > > > On Tue, Sep 29, 2020 at 12:27 PM Kevin Laatz wrote: > > > This patch set converts all python scripts in the project to use > > > python3 only and removes all deprecation notices associated with these > > > changes. This is due to python2 being EOL in January 2020. > > > > > > --- > > > v6: > > > - rebased, removing conflict with make removal patchset. > > > - added changes to buildtools/map_to_win.py > > > > > > v7: > > > - typo in email Cc'ing David Marchand > > > - added maintainers for buildtools patch > > > > > > v8: > > > - removed unrelated cleanup > > > - replaced integer cast with integer division operator > > > > > > v9: > > > - include documentation updates > > > > > > Kevin Laatz (4): > > > app/test-cmdline: support python3 only > > > app/test: support python3 only > > > buildtools: support python3 only > > > doc: support python3 only > > > > > > Louise Kilheeney (7): > > > usertools/dpdk-telemetry-client: support python3 only > > > usertools/dpdk-devbind: support python3 only > > > usertools/dpdk-pmdinfo: support python3 only > > > usertools/cpu_layout: support python3 only > > > devtools: support python3 only > > > config/arm: support python3 only > > > app/test-bbdev: support python3 only > > Hi David, > > > I can still see one issue in doc/guides/conf.py as you mentioned yesterday. > > There is also a script that directly calls /usr/bin/python3, worth > > fixing from my pov. > > > > $ for file in $(find app/ buildtools/ config/ devtools/ doc/ drivers/ > > examples/ kernel/ lib/ license/ usertools/ -name "*.py"); do head -1 > > $file |grep -q env.*python3 || echo $file; done > > doc/guides/conf.py > > usertools/dpdk-telemetry.py > > doc/guides/conf.py is indirectly called from sphinx which potentially causes some compatibilty issues when we make conf.py only support python3 (if sphinx in using python2) - this is why I left this out of the patchset, otherwise the doc build will be broken :-( > > I can change direct call to /usr/bin/python3. > I think we should err on the side of caution for the doc one - it can always be changed by a later patch anyway. Cleaning up the dpdk-telemetry one is probably worth doing though, I agree. /Bruce