DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/procinfo: close devices before exit
@ 2020-09-30 12:06 Ferruh Yigit
  2020-10-06 20:02 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2020-09-30 12:06 UTC (permalink / raw)
  To: Maryam Tahhan, Reshma Pattan; +Cc: dev, Ferruh Yigit, Thomas Monjalon

As well as this is correct thing to close devices before exit, it is
also useful to test the closing devices from secondary process.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Thomas Monjalon <thomas@monjalon.net>
---
 app/proc-info/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 64fb83b38d..b0de39489a 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1349,6 +1349,9 @@ main(int argc, char **argv)
 	if (enable_iter_mempool)
 		iter_mempool(mempool_iter_name);
 
+	RTE_ETH_FOREACH_DEV(i)
+		rte_eth_dev_close(i);
+
 	ret = rte_eal_cleanup();
 	if (ret)
 		printf("Error from rte_eal_cleanup(), %d\n", ret);
-- 
2.26.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] app/procinfo: close devices before exit
  2020-09-30 12:06 [dpdk-dev] [PATCH] app/procinfo: close devices before exit Ferruh Yigit
@ 2020-10-06 20:02 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-10-06 20:02 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: Maryam Tahhan, Reshma Pattan, dev

> As well as this is correct thing to close devices before exit, it is
> also useful to test the closing devices from secondary process.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Closing in secondary should not affect the primary. Good to test :)

Applied, thanks.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-06 20:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 12:06 [dpdk-dev] [PATCH] app/procinfo: close devices before exit Ferruh Yigit
2020-10-06 20:02 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).