From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50EF4A04B5; Wed, 30 Sep 2020 17:26:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0509B1DB79; Wed, 30 Sep 2020 17:26:40 +0200 (CEST) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id DBDCC1DB72 for ; Wed, 30 Sep 2020 17:26:37 +0200 (CEST) Received: by mail-lf1-f68.google.com with SMTP id y2so2635133lfy.10 for ; Wed, 30 Sep 2020 08:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UDCoFO+Vw0Iku3gG1LHcWTF1AO1fN3MEIVzq4jDD+uU=; b=c8niPBaq8WmMQ1s3Wu2MUpjhQ0ZC0d6sDwoKaLdaOykgjUdBptmbxhLZsQklJ3fO56 6dmzrzSdbJm8ZZklFQ81IZnsi45uEsjKMphSAerVUnvUe8qhKLtDF+BbU2C1i8H2NHM3 cZ34AKQr2ny2WHA4xduHEf7bI2kM7I1ghYZt7zPt/GfF5X11JOFDGzIi/2FlrOBT3wv5 rppPMmsy+19W1ccvafayeBI6k3IHTaIbCVisWKT68SUXGq3L4c6UkZHKf1WLpagjMuja /y1FWuOlJj0GSUWzTap/mwb3FPz2Cw5uVJ8gGfTgecU/lWuoCekyIgnB+rI5cBJIOitm OSDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UDCoFO+Vw0Iku3gG1LHcWTF1AO1fN3MEIVzq4jDD+uU=; b=l9sRcK8Y4U8vGx7WwPz/H94KQ6ZSifaw6eXEbkzlsyxUR78TrfAPpHOk8OHOnCoEVY I76L9lX6TlUm7KmdtUpvZ8V8W8iZsE084mOY1U0DNgk0wyW8aNRoLbJCwEOh7O/f5fpf oQxDKEJUStPIO31won9DYruv4SesuZEvUHabul6jVq3S4UxPrmiLTAwnm3R/Te2tayZV pRuy1vZWO1WXmhG7lYhGxOOUXSMM0xr+QDsm4meLFZ5DCwcMIe7tU5cXGqydv0CeXBam MVIjZAopiPos3R/qkVrH7yQamnFO4iZXx23/geaLv4GEElYk4Ni2swjAuP/TxqMGL7JD 2rag== X-Gm-Message-State: AOAM531IlqO+i3365cqbJuAtQjHbk+xqPsOAccsSTbDUvgMXzbA46wVL ut0J3ZNsp0Y2LwNwFARD8Fs= X-Google-Smtp-Source: ABdhPJx3Gt1J3nLYrNsDTu4DcazVxap9LvOt2F8NWYr12dxRxaHsJfNkj6H2nGaRYeF1GS6HATTpHw== X-Received: by 2002:ac2:4c19:: with SMTP id t25mr997023lfq.375.1601479597410; Wed, 30 Sep 2020 08:26:37 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id c28sm228526lfh.98.2020.09.30.08.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 08:26:36 -0700 (PDT) Date: Wed, 30 Sep 2020 18:26:35 +0300 From: Dmitry Kozlyuk To: "Kinsella, Ray" Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , "Kadam, Pallavi" , Olivier Matz , Neil Horman Message-ID: <20200930182635.06184920@sovereign> In-Reply-To: <8d940195-2e48-bc21-5eb4-88ed68ba4743@ashroe.eu> References: <20200620210511.13134-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-2-dmitry.kozliuk@gmail.com> <727edaf3-a8a8-e55a-ce36-8bde541c810d@ashroe.eu> <20200805141755.10c9c324@sovereign> <8d940195-2e48-bc21-5eb4-88ed68ba4743@ashroe.eu> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 30 Sep 2020 09:11:41 +0100, Kinsella, Ray wrote: > On 05/08/2020 12:17, Dmitry Kozlyuk wrote: > > On Wed, 5 Aug 2020 10:31:31 +0100, Kinsella, Ray wrote: > >> On 30/07/2020 22:06, Dmitry Kozlyuk wrote: > >>> struct cmdline exposes platform-specific members it contains, most > >>> notably struct termios that is only available on Unix. Make the > >>> structure opaque. > >>> > >>> Remove tests checking struct cmdline content as meaningless. > >>> > >>> Add cmdline_get_rdline() to access history buffer. > >>> The new function is currently used only in tests. > >> > >> Should it be INTERNAL then? Is it useful outside of the test cases? > > > > There are already exposed rdline_*() functions that require struct rdline > > pointer, which is now only accessible via this function for struct cmdline > > instances. Thus, public API would be broken with INTERNAL for such use cases. > > > > Right but that runs a bit contrary to what you said in the commit log. > > "Add cmdline_get_rdline() to access history buffer. > The new function is currently used only in tests." > > In anycase, given the elapse in time since my feedback. > I will ACK the changes to MAP file. I rather meant logical breakage that technical one: no functions are removed, yes, but if existing applications use cmdline::rdline, they won't have a legitimate way of getting it anymore. The comment you're quoting was before the workaround, but the WA exists only to keep ABI and we'd prefer the users to remove direct accesses of the structure fields by 21.11. To do that, we give them cmdline_get_rdline() and make it public, not internal.