From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48F1CA04BA; Thu, 1 Oct 2020 17:17:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 03CFA1DB7A; Thu, 1 Oct 2020 17:17:43 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CB4601B222 for ; Thu, 1 Oct 2020 17:17:40 +0200 (CEST) IronPort-SDR: LwGeXrx1n5n8QtU+Ptb9TG14c0yxfOIv2UrFBm35b5bhb0/WuNkFUjE0w0Q2T7tOQAwdi2w3EC IMRT8M+/omeg== X-IronPort-AV: E=McAfee;i="6000,8403,9761"; a="160163436" X-IronPort-AV: E=Sophos;i="5.77,323,1596524400"; d="scan'208";a="160163436" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2020 08:17:34 -0700 IronPort-SDR: NPvfRUpuhz93ETqDn9Zzl31YEoJS7auHdNZMgL2AjO4AWM5Sn1mb4Os6B5VnzwEb+9r8Ynqlyp UzgYtyTucuPA== X-IronPort-AV: E=Sophos;i="5.77,323,1596524400"; d="scan'208";a="504079813" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.208.13]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Oct 2020 08:17:28 -0700 Date: Thu, 1 Oct 2020 16:17:22 +0100 From: Bruce Richardson To: Ciara Power Cc: dev@dpdk.org, Nipun Gupta , John McNamara , Marko Kovacevic , Rosen Xu , Tianfei zhang , Xiaoyun Li , Jingjing Wu , Satha Rao , Mahipal Challa Message-ID: <20201001151722.GA984@bricha3-MOBL.ger.corp.intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20200921135931.13355-1-ciara.power@intel.com> <20200921135931.13355-16-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921135931.13355-16-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH v5 15/20] doc: remove references to make from rawdevs guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 21, 2020 at 02:59:26PM +0100, Ciara Power wrote: > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > > Signed-off-by: Ciara Power > Reviewed-by: Kevin Laatz > --- > doc/guides/rawdevs/dpaa2_cmdif.rst | 21 --------------------- > doc/guides/rawdevs/dpaa2_qdma.rst | 21 --------------------- > doc/guides/rawdevs/ifpga.rst | 10 ---------- > doc/guides/rawdevs/ioat.rst | 8 +------- > doc/guides/rawdevs/ntb.rst | 6 ------ > doc/guides/rawdevs/octeontx2_dma.rst | 12 ------------ > doc/guides/rawdevs/octeontx2_ep.rst | 8 -------- > 7 files changed, 1 insertion(+), 85 deletions(-) > > diff --git a/doc/guides/rawdevs/ioat.rst b/doc/guides/rawdevs/ioat.rst > index c46460ff45..b1b10c7fad 100644 > --- a/doc/guides/rawdevs/ioat.rst > +++ b/doc/guides/rawdevs/ioat.rst > @@ -54,13 +54,7 @@ shows: > Compilation > ------------ > > -For builds done with ``make``, the driver compilation is enabled by the > -``CONFIG_RTE_LIBRTE_PMD_IOAT_RAWDEV`` build configuration option. This is > -enabled by default in builds for x86 platforms, and disabled in other > -configurations. > - > -For builds using ``meson`` and ``ninja``, the driver will be built when the > -target platform is x86-based. > +The driver will be built when the target platform is x86-based. > This change for ioat is good, but the sentence now feels a little incomplete. Can we perhaps just add on a bit to make it something like: "The driver will be enabled in the DPDK build when the target platform is x86-based; no additional build configuration steps are necessary." Otherwise for the ioat part: Acked-by: Bruce Richardson